Page MenuHomePhabricator
Create Task
Maniphest T123219

Figure out whether we can get rid of IE8 scrolling hack from WikiEditor
Closed, ResolvedPublic
Actions

Description

Investigate whether we can get rid of @Catrope's infamous var IHateIE scrolling hack from WikiEditor. Some comments indicate that this is an IE8 hack, others say <= 10, and we still serve JS to IE9 users.

See also:

Details

SubjectRepoBranchLines +/-
Remove rest of partially-removed IE hackmediawiki/extensions/WikiEditormaster+0 -24
Drop call of deprecated IE8-support methodmediawiki/coremaster+0 -3
Remove workarounds for IE8mediawiki/extensions/WikiEditormaster+0 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Jan 11 2016, 7:02 AM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: Technical-Debt, WikiEditor (2010).
Legoktm added subscribers: Aklapper, Legoktm, StudiesWorld, Catrope.
Catrope updated the task description. (Show Details)Jan 15 2016, 11:00 PM
Catrope set Security to None.
Danny_B moved this task from Unsorted to IE8 on the Technical-Debt board.Jan 22 2016, 11:31 PM
Danny_B moved this task from IE8 to Needs removal on the Technical-Debt board.Jan 23 2016, 12:10 AM
gerritbot subscribed.Apr 26 2017, 4:29 PM

Change 350441 had a related patch set uploaded (by Fomafix):
[mediawiki/extensions/WikiEditor@master] Remove workarounds for IE8

https://gerrit.wikimedia.org/r/350441

gerritbot added a project: Patch-For-Review.Apr 26 2017, 4:29 PM
Krinkle updated the task description. (Show Details)Apr 26 2017, 5:00 PM
gerritbot added a comment.Apr 26 2017, 5:02 PM

Change 350441 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove workarounds for IE8

https://gerrit.wikimedia.org/r/350441

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 26 2017, 6:00 PM
gerritbot added a comment.Oct 12 2017, 3:04 PM

Change 383850 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikiEditor@master] Remove rest of partially-removed IE hack

https://gerrit.wikimedia.org/r/383850

gerritbot added a comment.Oct 12 2017, 3:12 PM

Change 383851 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Drop call of deprecated IE8-support method

https://gerrit.wikimedia.org/r/383851

gerritbot added a comment.Oct 12 2017, 5:35 PM

Change 383851 merged by jenkins-bot:
[mediawiki/core@master] Drop call of deprecated IE8-support method

https://gerrit.wikimedia.org/r/383851

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 12 2017, 6:00 PM
gerritbot added a comment.Oct 12 2017, 6:04 PM

Change 383850 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove rest of partially-removed IE hack

https://gerrit.wikimedia.org/r/383850

Krinkle closed this task as Resolved.Jun 15 2018, 12:28 PM
Krinkle assigned this task to Esanders.
happy5214 moved this task from Backlog to Closed on the WikiEditor (2010) board.Aug 4 2019, 11:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL