Page MenuHomePhabricator
Create Task
Maniphest T124149

SF_AutoeditAPI.php: Call to a member function formHTML() on a non-object (null)
Closed, ResolvedPublic
Actions

Description

Seeing this error on translatewiki.net a lot lately. [no req] means that it is a command line request. First observed in 2016-01-17.

2016-01-20 08:13:32 translatewiki.net translatewiki_net-bw_: [90ee8af6] [no req] BadMethodCallException from line 933 of /srv/mediawiki/tags/2016-01-19_16:04:04/extensions/SemanticForms/includes/SF_AutoeditAPI.php: Call to a member function formHTML() on a non-object (null)
#0 /srv/mediawiki/tags/2016-01-19_16:04:04/extensions/SemanticForms/includes/SF_AutoeditAPI.php(115): SFAutoeditAPI->doAction()
#1 /srv/mediawiki/tags/2016-01-19_16:04:04/extensions/SemanticForms/specials/SF_FormEdit.php(92): SFAutoeditAPI->execute()
#2 /srv/mediawiki/tags/2016-01-19_16:04:04/extensions/SemanticForms/specials/SF_FormEdit.php(43): SFFormEdit->printForm(string, string, NULL)
#3 /srv/mediawiki/tags/2016-01-19_16:04:04/includes/specialpage/SpecialPage.php(384): SFFormEdit->execute(string)
#4 /srv/mediawiki/tags/2016-01-19_16:04:04/includes/specialpage/SpecialPageFactory.php(563): SpecialPage->run(string)
#5 /srv/mediawiki/tags/2016-01-19_16:04:04/includes/MediaWiki.php(280): SpecialPageFactory::executePath(Title, RequestContext)
#6 /srv/mediawiki/tags/2016-01-19_16:04:04/includes/MediaWiki.php(738): MediaWiki->performRequest()
#7 /srv/mediawiki/tags/2016-01-19_16:04:04/includes/MediaWiki.php(510): MediaWiki->main()
#8 /srv/mediawiki/tags/2016-01-19_16:04:04/index.php(43): MediaWiki->run()
#9 {main}

Details

SubjectRepoBranchLines +/-
Move defined( 'SF_VERSION' ) down to below wfLoadExtension callmediawiki/extensions/SemanticFormsmaster+9 -10
Set global sfgFormPrintermediawiki/extensions/SemanticFormswmf/1.27.0-wmf.10+9 -2
Set global sfgFormPrintermediawiki/extensions/SemanticFormswmf/1.27.0-wmf.11+3 -3
Set global sfgFormPrintermediawiki/extensions/SemanticFormsmaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Jan 20 2016, 8:31 AM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a project: MediaWiki-extensions-Page_Forms.
Nikerabbit subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 20 2016, 8:31 AM
Nemo_bis added a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Jan 20 2016, 8:33 AM
Yaron_Koren subscribed.Jan 20 2016, 2:44 PM

Does this happen every time you go to a form, or only sometimes, or what?

The issue is that the $sfgFormPrinter global variable is not getting set. I assume this has to do with the recent change in the the code to use extension.json, but beyond that I don't know.

Nikerabbit added a comment.Jan 20 2016, 4:32 PM

I thought it comes from the job queue since there is no url for the request, but it is definitely executing a special page as if it were a request...
I am not using extension.json for SemanticForms at this time.

Foxtrott subscribed.Jan 20 2016, 7:16 PM

Getting this as well when calling .../Special:FormEdit/SomeForm

Reedy subscribed.Jan 20 2016, 8:30 PM

This is affecting Wikitech too on https://wikitech.wikimedia.org/wiki/Special:FormEdit/Tools_Access_Request

Reedy added a comment.Jan 20 2016, 8:31 PM

902 is another possible line with a problem. PhpStorm sees it as undefined too

Reedy added a comment.Jan 20 2016, 8:34 PM

I guess, it's still a stub object

reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/extensions/SemanticForms$ grep -R sfgFormPrinter * | grep "\$sfgFormPrinter ="
includes/SF_Utils.php:				$sfgFormPrinter = new StubObject( 'sfgFormPrinter', 'SFFormPrinter' );
includes/SF_Utils.php:			$sfgFormPrinter = new StubObject( 'sfgFormPrinter', 'SFFormPrinter' );
reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/extensions/SemanticForms$

Where is it ever assigned to anything else?

Reedy added a parent task: T123583: https://wikitech.wikimedia.org/wiki/Special:FormEdit/Tools_Access_Request down.Jan 20 2016, 8:36 PM
Reedy added a comment.Jan 20 2016, 8:38 PM

https://github.com/wikimedia/mediawiki-extensions-SemanticForms/blob/master/SemanticForms.php#L113-L121 too

gerritbot subscribed.Jan 20 2016, 8:47 PM

Change 265376 had a related patch set uploaded (by Foxtrott):
Set global sfgFormPrinter

https://gerrit.wikimedia.org/r/265376

gerritbot added a project: Patch-For-Review.Jan 20 2016, 8:47 PM
gerritbot added a comment.Jan 20 2016, 9:00 PM

Change 265376 merged by jenkins-bot:
Set global sfgFormPrinter

https://gerrit.wikimedia.org/r/265376

Reedy closed this task as Resolved.Jan 20 2016, 9:02 PM
Reedy assigned this task to Foxtrott.
gerritbot added a comment.Jan 20 2016, 9:04 PM

Change 265382 had a related patch set uploaded (by Reedy):
Set global sfgFormPrinter

https://gerrit.wikimedia.org/r/265382

gerritbot added a comment.Jan 20 2016, 9:05 PM

Change 265382 merged by jenkins-bot:
Set global sfgFormPrinter

https://gerrit.wikimedia.org/r/265382

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 20 2016, 11:01 PM
gerritbot added a comment.Jan 20 2016, 11:53 PM

Change 265426 had a related patch set uploaded (by Reedy):
Set global sfgFormPrinter

https://gerrit.wikimedia.org/r/265426

gerritbot added a comment.Jan 20 2016, 11:55 PM

Change 265426 merged by jenkins-bot:
Set global sfgFormPrinter

https://gerrit.wikimedia.org/r/265426

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 21 2016, 12:00 AM
Nikerabbit reopened this task as Open.Jan 28 2016, 6:48 PM

Still happening on master. See also https://gerrit.wikimedia.org/r/#/c/265376/1/includes/SF_Utils.php

Paladox subscribed.Jan 28 2016, 8:24 PM

Seems this is an extension registration problem since we are using a callback for sfgFormPrinter. We should add configuration project.

@Nikerabbit could you test this with mediawiki 1.24 to confirm that it is indeed an extension registration problem please.

gerritbot added a comment.Jan 28 2016, 10:19 PM

Change 267161 had a related patch set uploaded (by Paladox):
Fix $sfgFormPrinter setting

https://gerrit.wikimedia.org/r/267161

Paladox added a comment.Jan 28 2016, 10:23 PM

@Nikerabbit I have now fixed the problem with the patch above. I have tested it and the errors go away with the patch.

gerritbot added a comment.Jan 29 2016, 6:49 PM

Change 267161 merged by Yaron Koren:
Move defined( 'SF_VERSION' ) down to below wfLoadExtension call

https://gerrit.wikimedia.org/r/267161

Paladox added a comment.Jan 29 2016, 8:52 PM

@Nikerabbit does the patch above work for you it was merged and should resolve the problem now.

Nikerabbit added a comment.Jan 30 2016, 8:40 PM

Yes.

Paladox added a comment.Jan 30 2016, 9:31 PM

Should this be re closed as resolved now.

Yaron_Koren closed this task as Resolved.Feb 3 2016, 3:54 AM

Closing again...

• Phabricator_maintenance edited projects, added affects-translatewiki.net; removed MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Sep 26 2019, 1:53 PM
• Phabricator_maintenance removed a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Sep 26 2019, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL