Page MenuHomePhabricator

Deprecation warnings in GeSHi while importing pages
Closed, DuplicatePublic

Description

I was importing a number of pages into my local wiki, and received these two warnings:

( ! ) Deprecated: Use of SyntaxHighlight_GeSHi::prepare is deprecated. [Called from ScribuntoContent::fillParserOutput in /vagrant/mediawiki/extensions/Scribunto/common/ScribuntoContent.php at line 123] in /vagrant/mediawiki/includes/debug/MWDebug.php on line 300
Call Stack
#	Time	Memory	Function	Location
1	0.0000	247216	{main}( )	../index.php:0
2	0.0007	260200	require( '/vagrant/mediawiki/index.php' )	../index.php:5
3	0.0514	3853656	MediaWiki->run( )	../index.php:43
4	0.0514	3854856	MediaWiki->main( )	../MediaWiki.php:517
5	0.0766	4137768	MediaWiki->performRequest( )	../MediaWiki.php:745
6	0.0830	4399536	SpecialPageFactory::executePath( )	../MediaWiki.php:280
7	0.0832	4402192	SpecialPage->run( )	../SpecialPageFactory.php:564
8	0.0875	4495784	SpecialImport->execute( )	../SpecialPage.php:384
9	0.1582	6353592	SpecialImport->doImport( )	../SpecialImport.php:104
10	0.1953	6507784	WikiImporter->doImport( )	../SpecialImport.php:214
11	83.7944	14830712	WikiImporter->handlePage( )	../WikiImporter.php:567
12	83.8092	14836216	WikiImporter->handleRevision( )	../WikiImporter.php:759
13	83.8168	14841800	WikiImporter->processRevision( )	../WikiImporter.php:817
14	83.8219	14861656	WikiImporter->revisionCallback( )	../WikiImporter.php:895
15	83.8219	14862096	call_user_func_array ( )	../WikiImporter.php:473
16	83.8219	14862128	WikiImporter->importRevision( )	../WikiImporter.php:473
17	83.8220	14862744	DatabaseBase->deadlockLoop( )	../WikiImporter.php:336
18	83.8336	14856120	call_user_func_array ( )	../Database.php:2402
19	83.8336	14856288	WikiRevision->importOldRevision( )	../Database.php:2402
20	83.8834	14890776	WikiPage->doEditUpdates( )	../WikiRevision.php:555
21	83.8867	14891752	WikiPage->prepareContentForEdit( )	../WikiPage.php:2220
22	83.9013	14923056	AbstractContent->getParserOutput( )	../WikiPage.php:2161
23	83.9015	14924872	ScribuntoContent->fillParserOutput( )	../AbstractContent.php:497
24	83.9405	15592560	SyntaxHighlight_GeSHi::prepare( )	../ScribuntoContent.php:123
25	83.9405	15592640	wfDeprecated( )	../SyntaxHighlight_GeSHi.class.php:491
26	83.9405	15593048	MWDebug::deprecated( )	../GlobalFunctions.php:1180
27	83.9406	15599168	MWDebug::sendMessage( )	../MWDebug.php:233
28	83.9406	15599472	trigger_error ( )	../MWDebug.php:300
(10.0.2.15)

( ! ) Deprecated: Use of SyntaxHighlight_GeSHi::buildHeadItem is deprecated. [Called from ScribuntoContent::fillParserOutput in /vagrant/mediawiki/extensions/Scribunto/common/ScribuntoContent.php at line 136] in /vagrant/mediawiki/includes/debug/MWDebug.php on line 300
Call Stack
#	Time	Memory	Function	Location
1	0.0000	247216	{main}( )	../index.php:0
2	0.0007	260200	require( '/vagrant/mediawiki/index.php' )	../index.php:5
3	0.0514	3853656	MediaWiki->run( )	../index.php:43
4	0.0514	3854856	MediaWiki->main( )	../MediaWiki.php:517
5	0.0766	4137768	MediaWiki->performRequest( )	../MediaWiki.php:745
6	0.0830	4399536	SpecialPageFactory::executePath( )	../MediaWiki.php:280
7	0.0832	4402192	SpecialPage->run( )	../SpecialPageFactory.php:564
8	0.0875	4495784	SpecialImport->execute( )	../SpecialPage.php:384
9	0.1582	6353592	SpecialImport->doImport( )	../SpecialImport.php:104
10	0.1953	6507784	WikiImporter->doImport( )	../SpecialImport.php:214
11	83.7944	14830712	WikiImporter->handlePage( )	../WikiImporter.php:567
12	83.8092	14836216	WikiImporter->handleRevision( )	../WikiImporter.php:759
13	83.8168	14841800	WikiImporter->processRevision( )	../WikiImporter.php:817
14	83.8219	14861656	WikiImporter->revisionCallback( )	../WikiImporter.php:895
15	83.8219	14862096	call_user_func_array ( )	../WikiImporter.php:473
16	83.8219	14862128	WikiImporter->importRevision( )	../WikiImporter.php:473
17	83.8220	14862744	DatabaseBase->deadlockLoop( )	../WikiImporter.php:336
18	83.8336	14856120	call_user_func_array ( )	../Database.php:2402
19	83.8336	14856288	WikiRevision->importOldRevision( )	../Database.php:2402
20	83.8834	14890776	WikiPage->doEditUpdates( )	../WikiRevision.php:555
21	83.8867	14891752	WikiPage->prepareContentForEdit( )	../WikiPage.php:2220
22	83.9013	14923056	AbstractContent->getParserOutput( )	../WikiPage.php:2161
23	83.9015	14924872	ScribuntoContent->fillParserOutput( )	../AbstractContent.php:497
24	84.0811	15800704	SyntaxHighlight_GeSHi::buildHeadItem( )	../ScribuntoContent.php:136
25	84.0811	15800752	wfDeprecated( )	../SyntaxHighlight_GeSHi.class.php:497
26	84.0811	15800944	MWDebug::deprecated( )	../GlobalFunctions.php:1180
27	84.0813	15802576	MWDebug::sendMessage( )	../MWDebug.php:233
28	84.0813	15802880	trigger_error ( )	../MWDebug.php:300
(10.0.2.15)

Event Timeline

Yurik raised the priority of this task from to Needs Triage.
Yurik updated the task description. (Show Details)
Yurik added a project: SyntaxHighlight.
Yurik added subscribers: Yurik, MaxSem.

2 different issues...

					if ( isset( $wgAutoloadClasses['ResourceLoaderGeSHiModule'] ) ) {
						$output->addModuleStyles( "ext.geshi.language.$language" );
					} else {
						// Backwards compatibility
						$output->addHeadItem( SyntaxHighlight_GeSHi::buildHeadItem( $geshi ), "source-{$language}" );
					}

ResourceLoaderGeSHiModule looks to be gone in master. Should it be ResourceLoaderGeSHiVisualEditorModule ? Or is that just some weird back compat