Scribunto uses deprecated SyntaxHighlight_GeSHi methods
Closed, ResolvedPublic
Actions

Description

When viewing a page in the Module namespace on my test wiki, I am getting the following deprecation warnings:

Deprecated: Use of SyntaxHighlight_GeSHi::prepare is deprecated. [Called from ScribuntoContent::fillParserOutput in /home/ki/Projects/mediawiki/extensions/Scribunto/common/ScribuntoContent.php at line 123] in /home/ki/Projects/mediawiki/core/includes/debug/MWDebug.php on line 300
Deprecated: Use of SyntaxHighlight_GeSHi::buildHeadItem is deprecated. [Called from ScribuntoContent::fillParserOutput in /home/ki/Projects/mediawiki/extensions/Scribunto/common/ScribuntoContent.php at line 136] in /home/ki/Projects/mediawiki/core/includes/debug/MWDebug.php on line 300

Details

	Subject	Repo	Branch	Lines +/-
	Fix SyntaxHighlight incompatibility	mediawiki/extensions/Scribunto	REL1_31	+26 -27
	Fix SyntaxHighlight incompatibility	mediawiki/extensions/Scribunto	master	+26 -27

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Duplicate		None	T194266 Expand the set of bundled skins
Invalid		None	T178349 Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites
Resolved		None	T209220 Expand the set of bundled extensions and skins in MediaWiki 1.34
Resolved		Jdforrester-WMF	T191737 Bundle Scribunto extension with MediaWiki
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T162885 Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13
Resolved	PRODUCTION ERROR	None	T181834 Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01
Resolved	PRODUCTION ERROR	None	T186337 Fix MediaWiki deprecated calls in Wikimedia production, 2018-02-02
Resolved		CCicalese_WMF	T109873 Scribunto uses deprecated SyntaxHighlight_GeSHi methods

Event Timeline

PleaseStand created this task.Aug 21 2015, 6:20 PM

PleaseStand raised the priority of this task from to Needs Triage.

PleaseStand updated the task description. (Show Details)

PleaseStand added a project: Scribunto.

PleaseStand subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2015, 6:20 PM

Aklapper added a project: Technical-Debt.Aug 22 2015, 2:53 PM

Ricordisamoa subscribed.Aug 23 2015, 11:39 AM

This also breaks Vagrant's import::dump somehow.

SyntaxHighlight_GeSHi::prepare() is deprecated but it's not clear what the replacement is supposed to be.

Change 245580 had a related patch set uploaded (by Gergő Tisza):
[DO NOT MERGE] Make SyntaxHighlight_GeSHi::highlight public

https://gerrit.wikimedia.org/r/245580

Change 245581 had a related patch set uploaded (by Gergő Tisza):
[DO NOT MERGE] Fix SyntaxHighlight incompatibility

https://gerrit.wikimedia.org/r/245581

The above is a workaround for vagrant.

Rical subscribed.Oct 14 2015, 8:03 AM

I don't really like that we have to explicitly add the Geshi modules from inside Scribunto. Shouldn't we pass an 'output' object into the highlight function ? Or at the very least have a public method inside Geshi::addRLModules( output, language ) or something ?

As long as the semantics are "add RL modules to $output" rather than "call $output->setText()", either way seems like it would work for Scribunto.

Anomie merged a task: T125330: Deprecation warnings in GeSHi while importing pages.Feb 1 2016, 9:40 PM

Anomie added subscribers: Reedy, MaxSem, Yurik, StudiesWorld.

Jdforrester-WMF moved this task from Backlog to Accepted on the SyntaxHighlight board.Sep 20 2016, 10:34 PM

Anomie merged a task: T161572: Remove old SyntaxHightlight_GeSHi back compat in Scribunto.Mar 28 2017, 2:02 PM

Anomie mentioned this in T161572: Remove old SyntaxHightlight_GeSHi back compat in Scribunto.

Anomie merged a task: T162908: Update Scribunto not to use deprecated SyntaxHighlight_GeSHi::prepare & SyntaxHighlight_GeSHi::buildHeadItem calls.Apr 13 2017, 4:12 PM

Anomie added subscribers: Jdforrester-WMF, TerraCodes, Volans.

Jdforrester-WMF added a parent task: T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Apr 13 2017, 4:13 PM

Jdforrester-WMF mentioned this in T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.

This is one of the most spammy things in WMF logs. See T181834

Reedy triaged this task as High priority.Dec 1 2017, 7:46 PM

Jdforrester-WMF mentioned this in T181834: Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01.Dec 1 2017, 8:28 PM

Jdforrester-WMF mentioned this in T186337: Fix MediaWiki deprecated calls in Wikimedia production, 2018-02-02.Feb 2 2018, 6:12 PM

Jdforrester-WMF added a parent task: T186337: Fix MediaWiki deprecated calls in Wikimedia production, 2018-02-02.

Rical unsubscribed.Mar 20 2018, 9:54 AM

Krinkle moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.Mar 27 2018, 12:41 AM

TheDJ unsubscribed.Mar 28 2018, 9:30 AM

Legoktm added a parent task: T191737: Bundle Scribunto extension with MediaWiki.Apr 17 2018, 8:43 PM

Krinkle added a project: MW-1.31-release.Apr 18 2018, 6:05 PM

Change 245581 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Fix SyntaxHighlight incompatibility

https://gerrit.wikimedia.org/r/245581

CCicalese_WMF closed this task as Resolved.Apr 18 2018, 6:21 PM

CCicalese_WMF claimed this task.

Change 427463 had a related patch set uploaded (by Cicalese; owner: Gergő Tisza):
[mediawiki/extensions/Scribunto@REL1_31] Fix SyntaxHighlight incompatibility

https://gerrit.wikimedia.org/r/427463

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 18 2018, 7:00 PM

Change 427463 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@REL1_31] Fix SyntaxHighlight incompatibility

https://gerrit.wikimedia.org/r/427463

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM