Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Volans
	Apr 13 2017, 1:20 PM

Description

I've noticed that we have a tons of INFO messages in Kibana for deprecated calls (~14.5M/24h, ~10k/min). Most of them were deprecated in MW 1.29 but there are older too, up to MW 1.22.

This aim to be the parent task, I'm reporting here below the list gathered from the last 24h. I guess that one task each will be the easiest way to fix them.

Logged message	Count (last 24h)
`Use of ChangesListSpecialPageFilters hook (used in WikimediaEventsHooks::onChangesListSpecialPageFilters) was deprecated in MediaWiki 1.29. [Called from ChangesListSpecialPage::getCustomFilters in /srv/mediawiki/php-1.29.0-wmf.19/includes/specialpage/Chan`	4584461
`Use of EditPageBeforeEditChecks hook (used in \Wikibase\ClientHooks::onEditAction) was deprecated in MediaWiki 1.29. [Called from EditPage::getCheckboxes in /srv/mediawiki/php-1.29.0-wmf.19/includes/EditPage.php at line 4118]`	3562400
`Use of ChangesListSpecialPageFilters hook (used in FlaggedRevsUIHooks::addHideReviewedFilter) was deprecated in MediaWiki 1.29. [Called from ChangesListSpecialPage::getCustomFilters in /srv/mediawiki/php-1.29.0-wmf.19/includes/specialpage/ChangesListSpeci`	2465062
`Use of SpecialRecentChangesQuery hook (used in FlaggedRevsUIHooks::modifyRecentChangesQuery) was deprecated in MediaWiki 1.23. [Called from SpecialRecentChanges::runMainQueryHook in /srv/mediawiki/php-1.29.0-wmf.19/includes/specials/SpecialRecentchanges.p`	1973682
`Use of ChangesListSpecialPageFilters hook (used in WikimediaEventsHooks::onChangesListSpecialPageFilters) was deprecated in MediaWiki 1.29. [Called from ChangesListSpecialPage::getCustomFilters in /srv/mediawiki/php-1.29.0-wmf.20/includes/specialpage/Chan`	1033244
`Use of EditPageBeforeEditChecks hook (used in \Wikibase\ClientHooks::onEditAction) was deprecated in MediaWiki 1.29. [Called from EditPage::getCheckboxes in /srv/mediawiki/php-1.29.0-wmf.20/includes/EditPage.php at line 4118]`	421124
`Use of EditPageBeforeEditChecks hook (used in LqtHooks::editCheckBoxes) was deprecated in MediaWiki 1.29. [Called from EditPage::getCheckboxes in /srv/mediawiki/php-1.29.0-wmf.20/includes/EditPage.php at line 4118]`	155766
`Use of SpecialWatchlistQuery hook (used in FlaggedRevsUIHooks::modifyChangesListQuery) was deprecated in MediaWiki 1.23. [Called from SpecialWatchlist::runMainQueryHook in /srv/mediawiki/php-1.29.0-wmf.19/includes/specials/SpecialWatchlist.php at line 371`	137717
`Use of ChangesListSpecialPageFilters hook (used in FlaggedRevsUIHooks::addHideReviewedFilter) was deprecated in MediaWiki 1.29. [Called from ChangesListSpecialPage::getCustomFilters in /srv/mediawiki/php-1.29.0-wmf.20/includes/specialpage/ChangesListSpeci`	88662
`Use of SpecialRecentChangesQuery hook (used in FlaggedRevsUIHooks::modifyRecentChangesQuery) was deprecated in MediaWiki 1.23. [Called from SpecialRecentChanges::runMainQueryHook in /srv/mediawiki/php-1.29.0-wmf.20/includes/specials/SpecialRecentchanges.p`	82742
`Use of wfSetupSession was deprecated in MediaWiki 1.27. [Called from CollectionSession::startSession in /srv/mediawiki/php-1.29.0-wmf.19/extensions/Collection/Collection.session.php at line 38]`	66857
`Use of EditPageBeforeEditChecks hook (used in LqtHooks::editCheckBoxes) was deprecated in MediaWiki 1.29. [Called from EditPage::getCheckboxes in /srv/mediawiki/php-1.29.0-wmf.19/includes/EditPage.php at line 4118]`	33255
`Use of SyntaxHighlight_GeSHi::prepare is deprecated. [Called from ScribuntoContent::fillParserOutput in /srv/mediawiki/php-1.29.0-wmf.19/extensions/Scribunto/common/ScribuntoContent.php at line 128]`	13603
`Use of SyntaxHighlight_GeSHi::buildHeadItem is deprecated. [Called from ScribuntoContent::fillParserOutput in /srv/mediawiki/php-1.29.0-wmf.19/extensions/Scribunto/common/ScribuntoContent.php at line 141]`	13599
`Use of wfSetupSession was deprecated in MediaWiki 1.27. [Called from CollectionSession::startSession in /srv/mediawiki/php-1.29.0-wmf.20/extensions/Collection/Collection.session.php at line 38]`	9372
`Use of User::getGroupName was deprecated in MediaWiki 1.29. [Called from Closure$SpecialCentralAuth::getInfoFields in /srv/mediawiki/php-1.29.0-wmf.19/extensions/CentralAuth/includes/specials/SpecialCentralAuth.php at line 350]`	7041
`Use of User::getGroupName was deprecated in MediaWiki 1.29. [Called from Closure$SpecialCentralAuth::getInfoFields in /srv/mediawiki/php-1.29.0-wmf.20/extensions/CentralAuth/includes/specials/SpecialCentralAuth.php at line 350]`	4112
`Use of ExtractThumbParameters was deprecated in MediaWiki 1.22. [Called from wfStreamThumb in /srv/mediawiki/php-1.29.0-wmf.20/thumb.php at line 175]`	4048
`Use of Revision::getRawUser was deprecated in MediaWiki 1.25. [Called from FlaggedRevsHooks::incrementReverts in /srv/mediawiki/php-1.29.0-wmf.19/extensions/FlaggedRevs/backend/FlaggedRevs.hooks.php at line 702]`	2911
`Use of ExtractThumbParameters was deprecated in MediaWiki 1.22. [Called from wfStreamThumb in /srv/mediawiki/php-1.29.0-wmf.19/thumb.php at line 175]`	2669
`Use of User::getGroupName was deprecated in MediaWiki 1.29. [Called from GlobalUsersPager::getAllGroups in /srv/mediawiki/php-1.29.0-wmf.20/extensions/CentralAuth/includes/specials/SpecialGlobalUsers.php at line 275]`	1993
`Use of User::getGroupName was deprecated in MediaWiki 1.29. [Called from GlobalUsersPager::getAllGroups in /srv/mediawiki/php-1.29.0-wmf.19/extensions/CentralAuth/includes/specials/SpecialGlobalUsers.php at line 275]`	1600
`Use of Revision::getRawUserText was deprecated in MediaWiki 1.25. [Called from FlaggablePageView::addToDiffView in /srv/mediawiki/php-1.29.0-wmf.19/extensions/FlaggedRevs/frontend/FlaggablePageView.php at line 1498]`	1127
`Use of wfSetupSession was deprecated in MediaWiki 1.27. [Called from AbuseFilter::executeFilterActions in /srv/mediawiki/php-1.29.0-wmf.19/extensions/AbuseFilter/includes/AbuseFilter.class.php at line 796]`	1114
`Use of User::getGroupMember was deprecated in MediaWiki 1.29. [Called from SpecialGlobalGroupPermissions::buildGroupView in /srv/mediawiki/php-1.29.0-wmf.19/extensions/CentralAuth/includes/specials/SpecialGlobalGroupPermissions.php at line 249]`	686
`Use of User::getGroupName was deprecated in MediaWiki 1.29. [Called from SpecialGlobalGroupPermissions::buildGroupView in /srv/mediawiki/php-1.29.0-wmf.19/extensions/CentralAuth/includes/specials/SpecialGlobalGroupPermissions.php at line 248]`	686
`Use of User::getGroupMember was deprecated in MediaWiki 1.29. [Called from GlobalUsersPager::getUserGroups in /srv/mediawiki/php-1.29.0-wmf.19/extensions/CentralAuth/includes/specials/SpecialGlobalUsers.php at line 259]`	664
`Use of User::makeGroupLinkWiki was deprecated in MediaWiki 1.29. [Called from GlobalUsersPager::getUserGroups in /srv/mediawiki/php-1.29.0-wmf.19/extensions/CentralAuth/includes/specials/SpecialGlobalUsers.php at line 260]`	663
`Use of User::getGroupMember was deprecated in MediaWiki 1.29. [Called from GlobalUsersPager::getUserGroups in /srv/mediawiki/php-1.29.0-wmf.20/extensions/CentralAuth/includes/specials/SpecialGlobalUsers.php at line 259]`	539
`Use of User::makeGroupLinkWiki was deprecated in MediaWiki 1.29. [Called from GlobalUsersPager::getUserGroups in /srv/mediawiki/php-1.29.0-wmf.20/extensions/CentralAuth/includes/specials/SpecialGlobalUsers.php at line 260]`	539
`Use of User::makeGroupLinkWiki was deprecated in MediaWiki 1.29. [Called from SpecialGlobalGroupPermissions::getGlobalGroupsTable in /srv/mediawiki/php-1.29.0-wmf.20/extensions/CentralAuth/includes/specials/SpecialGlobalGroupPermissions.php at line 133]`	521
`Use of Revision::getRawUser was deprecated in MediaWiki 1.25. [Called from RevisionReviewForm::doSubmit in /srv/mediawiki/php-1.29.0-wmf.19/extensions/FlaggedRevs/business/RevisionReviewForm.php at line 384]`	509
`Use of User::getGroupMember was deprecated in MediaWiki 1.29. [Called from SpecialGlobalGroupPermissions::buildGroupView in /srv/mediawiki/php-1.29.0-wmf.20/extensions/CentralAuth/includes/specials/SpecialGlobalGroupPermissions.php at line 249]`	491
`Use of User::getGroupName was deprecated in MediaWiki 1.29. [Called from SpecialGlobalGroupPermissions::buildGroupView in /srv/mediawiki/php-1.29.0-wmf.20/extensions/CentralAuth/includes/specials/SpecialGlobalGroupPermissions.php at line 248]`	491
`Use of SpecialWatchlistQuery hook (used in FlaggedRevsUIHooks::modifyChangesListQuery) was deprecated in MediaWiki 1.23. [Called from SpecialWatchlist::runMainQueryHook in /srv/mediawiki/php-1.29.0-wmf.20/includes/specials/SpecialWatchlist.php at line 371`	389
`Use of User::makeGroupLinkWiki was deprecated in MediaWiki 1.29. [Called from SpecialGlobalGroupPermissions::getGlobalGroupsTable in /srv/mediawiki/php-1.29.0-wmf.19/extensions/CentralAuth/includes/specials/SpecialGlobalGroupPermissions.php at line 133]`	358
`Use of wfSetupSession was deprecated in MediaWiki 1.27. [Called from AbuseFilter::executeFilterActions in /srv/mediawiki/php-1.29.0-wmf.20/extensions/AbuseFilter/includes/AbuseFilter.class.php at line 796]`	117

Follow-up: T181834: Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01

Details

	Subject	Repo	Branch	Lines +/-
	Fix various User related deprecated function calls	mediawiki/extensions/CentralAuth	master	+27 -9

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T162885 Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13
Duplicate	PRODUCTION ERROR	None	T162880 Update deprecated hook usage EditPageBeforeEditChecks
Resolved	PRODUCTION ERROR	Reedy	T162879 Replace deprecated hook usage ChangesListSpecialPageFilters in WikimediaEvents
Resolved	PRODUCTION ERROR	• Mattflaschen-WMF	T162902 Update FlaggedRevs not to use deprecated ChangesListSpecialPageFilters hook
Resolved	PRODUCTION ERROR	• Mattflaschen-WMF	T162903 Update FlaggedRevs not to use deprecated SpecialRecentChangesQuery hook
Resolved	PRODUCTION ERROR	• Mattflaschen-WMF	T162904 Update FlaggedRevs not to use deprecated SpecialWatchlistQuery hook
Resolved	PRODUCTION ERROR	Reedy	T162906 Update FlaggedRevs not to use deprecated Revision::getRawUser call
Resolved	PRODUCTION ERROR	Reedy	T162907 Update FlaggedRevs not to use deprecated Revision::getRawUserText call
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T162909 Update AbuseFilter not to use deprecated wfSetupSession call
Resolved	PRODUCTION ERROR	pmiazga	T162910 Update Collection not to use deprecated wfSetupSession call
Resolved	PRODUCTION ERROR	Reedy	T162911 Update CentralAuth not to use deprecated User::getGroupMember / User::getGroupName / User::makeGroupLinkWiki calls
Resolved		CCicalese_WMF	T109873 Scribunto uses deprecated SyntaxHighlight_GeSHi methods
Resolved		matmarex	T161810 Update FlaggedRevs not to use deprecated EditPageBeforeEditChecks hook
Resolved		Jdforrester-WMF	T161811 Update LiquidThreads not to use deprecated EditPageBeforeEditChecks hook
Resolved		matmarex	T161813 Update Scribunto not to use deprecated EditPageBeforeEditChecks hook
Resolved		Jdforrester-WMF	T161815 Update Wikibase not to use deprecated EditPageBeforeEditChecks hook
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T162962 Update PagedTiffHandler not to use deprecated ExtractThumbParameters hook

Event Timeline

Volans created this task.Apr 13 2017, 1:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2017, 1:20 PM

Volans added a subtask: T162878: Update deprecated hooks in Flagged Revs.Apr 13 2017, 1:20 PM

Reedy added projects: Wikimedia-production-error, Technical-Debt.Apr 13 2017, 1:22 PM

Reedy added a subtask: T162881: Hooks: ChangesListSpecialPageFilters, SpecialRecentChangesFilters, SpecialRecentChangesQuery, SpecialWatchlistFilters and SpecialWatchlistQuery are deprecated.

Volans added a subtask: T162880: Update deprecated hook usage EditPageBeforeEditChecks.Apr 13 2017, 1:23 PM

Volans added a subtask: T162879: Replace deprecated hook usage ChangesListSpecialPageFilters in WikimediaEvents.

matmarex added a subtask: T161809: Update extensions not to use deprecated EditPageBeforeEditChecks hook.Apr 13 2017, 1:51 PM

Jdforrester-WMF renamed this task from MediaWiki deprecated calls to Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Apr 13 2017, 3:41 PM

Jdforrester-WMF triaged this task as High priority.

Change 348091 had a related patch set uploaded (by Reedy):
[mediawiki/extensions/CentralAuth@master] Fix various User related deprecated function calls

https://gerrit.wikimedia.org/r/348091

gerritbot added a project: Patch-For-Review.Apr 13 2017, 3:43 PM

Reedy closed subtask T162879: Replace deprecated hook usage ChangesListSpecialPageFilters in WikimediaEvents as Resolved.Apr 13 2017, 3:45 PM

Update/triage based on numbers:

ChangesListSpecialPageFilters
- WikimediaEvents (T162879) – Fixed.
- FlaggedRevs (T162902) – Fixed.
EditPageBeforeEditChecks
- Wikibase (T161815) – Fixed.
- LQT (T161811) – Fixed.
Revision::getRawUser
- FlaggedRevs (T162906) – Fixed.
Revision::getRawUserText
- FlaggedRevs (T162907) – Fixed.
SpecialRecentChangesQuery
- FlaggedRevs (T162903) – Fixed.
SpecialWatchlistQuery
- FlaggedRevs (T162904) – Fixed.
SyntaxHighlight_GeSHi::prepare & SyntaxHighlight_GeSHi::buildHeadItem
- Scribunto (T109873) – Needs a fix writing.
wfSetupSession
- AbuseFilter (T162909) – Needs a fix writing.
- Collection (T162910) – Needs a fix writing.
User::getGroupMember & User::getGroupName & User::makeGroupLinkWiki
- CentralAuth (T162911) – Fixed.
ExtractThumbParameters
- PagedTiffHandler (T162962) – Fixed in master only.

Jdforrester-WMF created subtask T162902: Update FlaggedRevs not to use deprecated ChangesListSpecialPageFilters hook.Apr 13 2017, 4:04 PM

Jdforrester-WMF created subtask T162903: Update FlaggedRevs not to use deprecated SpecialRecentChangesQuery hook.

Jdforrester-WMF created subtask T162904: Update FlaggedRevs not to use deprecated SpecialWatchlistQuery hook.

Jdforrester-WMF created subtask T162906: Update FlaggedRevs not to use deprecated Revision::getRawUser call.Apr 13 2017, 4:08 PM

Jdforrester-WMF created subtask T162907: Update FlaggedRevs not to use deprecated Revision::getRawUserText call.

Jdforrester-WMF created subtask T162908: Update Scribunto not to use deprecated SyntaxHighlight_GeSHi::prepare & SyntaxHighlight_GeSHi::buildHeadItem calls.

Jdforrester-WMF created subtask T162909: Update AbuseFilter not to use deprecated wfSetupSession call.

Jdforrester-WMF created subtask T162910: Update Collection not to use deprecated wfSetupSession call.

Jdforrester-WMF created subtask T162911: Update CentralAuth not to use deprecated User::getGroupMember / User::getGroupName / User::makeGroupLinkWiki calls.Apr 13 2017, 4:10 PM

Jdforrester-WMF edited subtasks, added: T109873: Scribunto uses deprecated SyntaxHighlight_GeSHi methods; removed: T162908: Update Scribunto not to use deprecated SyntaxHighlight_GeSHi::prepare & SyntaxHighlight_GeSHi::buildHeadItem calls.Apr 13 2017, 4:13 PM

Jdforrester-WMF edited subtasks, added: T161810: Update FlaggedRevs not to use deprecated EditPageBeforeEditChecks hook, T161811: Update LiquidThreads not to use deprecated EditPageBeforeEditChecks hook, T161813: Update Scribunto not to use deprecated EditPageBeforeEditChecks hook, T161815: Update Wikibase not to use deprecated EditPageBeforeEditChecks hook; removed: T161809: Update extensions not to use deprecated EditPageBeforeEditChecks hook, T162881: Hooks: ChangesListSpecialPageFilters, SpecialRecentChangesFilters, SpecialRecentChangesQuery, SpecialWatchlistFilters and SpecialWatchlistQuery are deprecated, T162878: Update deprecated hooks in Flagged Revs.Apr 13 2017, 4:17 PM

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Apr 13 2017, 7:29 PM

Change 348091 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Fix various User related deprecated function calls

https://gerrit.wikimedia.org/r/348091

Jdforrester-WMF closed subtask T162911: Update CentralAuth not to use deprecated User::getGroupMember / User::getGroupName / User::makeGroupLinkWiki calls as Resolved.Apr 13 2017, 7:33 PM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 13 2017, 8:00 PM

Jdforrester-WMF created subtask T162962: Update PagedTiffHandler not to use deprecated ExtractThumbParameters hook .Apr 13 2017, 10:32 PM

Jdforrester-WMF removed projects: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review.Apr 13 2017, 10:35 PM

Jdforrester-WMF closed subtask T162907: Update FlaggedRevs not to use deprecated Revision::getRawUserText call as Resolved.Apr 14 2017, 12:29 AM

Jdforrester-WMF closed subtask T162906: Update FlaggedRevs not to use deprecated Revision::getRawUser call as Resolved.

Jdforrester-WMF closed subtask T162962: Update PagedTiffHandler not to use deprecated ExtractThumbParameters hook as Resolved.May 3 2017, 12:51 AM

Jdforrester-WMF closed subtask T162902: Update FlaggedRevs not to use deprecated ChangesListSpecialPageFilters hook as Resolved.May 3 2017, 12:55 AM

Jdforrester-WMF closed subtask T162903: Update FlaggedRevs not to use deprecated SpecialRecentChangesQuery hook as Resolved.

Jdforrester-WMF closed subtask T162904: Update FlaggedRevs not to use deprecated SpecialWatchlistQuery hook as Resolved.

Status update as of 2017-05-02: We're now down to ~ 120k/24h / <100/min; will try to get the three remaining tasks fixed laster this week, and then do another one of these in a couple of weeks, after it's all deployed.

• demon created subtask T181758: Stop using deprecated ApiBase::dieUsage() in Linter extension.Nov 30 2017, 9:37 PM

• demon created subtask T181828: Remove deprecated call to EditPage::isOouiEnabled() in TranslateEditAddons::buttonHack().Dec 1 2017, 6:23 PM

• demon created subtask T181829: Remove deprecated User::makeGroupLinkWiki() calls in SpecialGlobalUsers.

• demon renamed this task from Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13 to Fix MediaWiki deprecated calls in Wikimedia production.Dec 1 2017, 6:34 PM