Page MenuHomePhabricator
Create Task
Maniphest T162910

Update Collection not to use deprecated wfSetupSession call
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

https://github.com/wikimedia/mediawiki-extensions-Collection/blob/a91270a06beed929e9ca6c00c62a8612c60edae3/Collection.session.php

  • wfSetupSession()
  • session_id()
  • $_SESSION['wsCollection']

Details

SubjectRepoBranchLines +/-
[WIP] Use SessionManager instead of wfSetupSessionmediawiki/extensions/Collectionmaster+3 -6
Avoid calls to deprecated wfSetupSession, $_SESSION, and session_idmediawiki/extensions/Collectionmaster+91 -58
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Apr 13 2017, 4:10 PM
Jdforrester-WMF mentioned this in T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Apr 13 2017, 7:29 PM
Krinkle updated the task description. (Show Details)Jun 23 2017, 3:21 PM
Jdlrobson lowered the priority of this task from High to Medium.Sep 5 2017, 7:16 PM
Jdlrobson added a project: Web-Team-Backlog (Tracking).
Jdlrobson subscribed.

This has been high for a couple of years now so reflecting reality.
What would we use instead?
It seems Collection extension uses wfSetupSession to change HTML for anonymous users using the book creator....

Jdlrobson moved this task from Untriaged to Discuss further on the Web-Team-Backlog (Tracking) board.Sep 6 2017, 6:36 PM
Krenair subscribed.EditedSep 7 2017, 9:23 PM
In T162910#3581504, @Jdlrobson wrote:

What would we use instead?

https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/GlobalFunctions.php;5ec0132821f4dca98a53b466a3d35b7a2853c616$2952-2955

Jdlrobson added a comment.Sep 8 2017, 2:11 PM

Interesting. I didn't realise we didn't allow for sessions for anonymous users. I'm curious how this works with Varnish now.

pmiazga subscribed.Oct 2 2017, 3:14 PM
gerritbot subscribed.Oct 2 2017, 4:58 PM

Change 381806 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/Collection@master] [WIP] Use SessionManager instead of wfSetupSession

https://gerrit.wikimedia.org/r/381806

gerritbot added a project: Patch-For-Review.Oct 2 2017, 4:58 PM
Jdlrobson added a subscriber: BBlack.Oct 2 2017, 5:20 PM

Hi @BBlack we have a few questions relating to this on how sessions are managed in mediawiki for anons on Varnish layer. Would appreciate your insight!

pmiazga claimed this task.Oct 2 2017, 9:22 PM
Anomie added a parent task: T124371: Clean up usage of $_SESSION in WMF-deployed extensions.Dec 1 2017, 7:29 PM
Reedy added a parent task: T181834: Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01.Dec 1 2017, 7:47 PM
Jdforrester-WMF mentioned this in T181834: Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01.Dec 1 2017, 8:28 PM
Jdforrester-WMF mentioned this in T186337: Fix MediaWiki deprecated calls in Wikimedia production, 2018-02-02.Feb 2 2018, 6:12 PM
Jdforrester-WMF added a parent task: T186337: Fix MediaWiki deprecated calls in Wikimedia production, 2018-02-02.
gerritbot added a comment.Mar 1 2018, 10:36 PM

Change 415760 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Collection@master] Avoid calls to deprecated wfSetupSession, $_SESSION, and session_id

https://gerrit.wikimedia.org/r/415760

gerritbot added a comment.Mar 2 2018, 12:12 AM

Change 415760 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Avoid calls to deprecated wfSetupSession, $_SESSION, and session_id

https://gerrit.wikimedia.org/r/415760

Jdforrester-WMF closed this task as Resolved.Mar 2 2018, 12:15 AM

Oh, oops, sorry @pmiazga, didn't see the existing work.

gerritbot added a comment.Mar 2 2018, 12:15 AM

Change 381806 abandoned by Jforrester:
[WIP] Use SessionManager instead of wfSetupSession

Reason:
Done in I3ea8287e1f.

https://gerrit.wikimedia.org/r/381806

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 12:01 PM
Reedy removed a project: Patch-For-Review.May 17 2019, 9:47 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits