Page MenuHomePhabricator
Create Task
Maniphest T123451

Deploy SessionManager and bot passwords
Closed, ResolvedPublic
Actions

Description

  • merge Brad's commits
  • test on Beta
  • create production DB - probably on metawiki, per https://gerrit.wikimedia.org/r/#/c/259066/ comment Dec 15 09:54
  • create non-SUL DBs or disable bot passords on those wikis for now
  • config patch for central bot password DB on prod
  • bot password announcement
  • SessionManager announcement
  • watch beta & prod metrics

Details

SubjectRepoBranchLines +/-
Configure bot passwordsoperations/mediawiki-configmaster+20 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• DeskanaT75616 Tracking: API/backend issues blocking Wikipedia app development
 ResolvedAnomieT32788 Allow triggering of user password reset email via the API
 OpenNoneT90925 General authentication improvements for MediaWiki
 ResolvedAnomieT48179 Allow a challenge stage during authentication
 OpenNoneT5709 Refactoring to make external authentication and identity systems easier
 ResolvedTgrT43201 UserLoadFromSession considered evil
 ResolvedAnomieT67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
 OpenFeatureNoneT55156 Provide option to force a login session to end within a certain time
 OpenNoneT89459 Modernize MediaWiki authentication system (AuthManager)
 ResolvedAnomieT123451 Deploy SessionManager and bot passwords
 ResolvedPRODUCTION ERRORAnomieT124126 Can neither load the session nor create an empty session
 ResolvedPRODUCTION ERRORTgrT124143 Infinite recursion between user and session loading
 ResolvedPRODUCTION ERRORTgrT124252 NEED_TOKEN error spike when 1.27-wmf.11 SessionManager was deployed to group1
 ResolvedDbrantT124384 [Panic] Login broken in app?
 DeclinedNoneT124428 SessionHandler causing login problems for Huggle 2 and older
 ResolvedLegoktmT74791 Newly created accounts are not global (at least, according to OAuth)
 ResolvedAnomieT124335 bot_passwords table expected to exist despite wgEnableBotPasswords = false
 OpenNoneT124371 Clean up usage of $_SESSION in WMF-deployed extensions
 ResolvedFlorianT132251 CentralNotice shouldn't use wfSetupSession() anymore
 ResolvedPRODUCTION ERRORpmiazgaT162910 Update Collection not to use deprecated wfSetupSession call
 ResolvedPRODUCTION ERRORJdforrester-WMFT186339 Update SecurePoll not to use deprecated wfSetupSession call
 ResolvedPRODUCTION ERRORNoneT124367 User::loadFromSession called before the end of Setup.php
 ResolvedPRODUCTION ERRORCatropeT139665 "User::loadFromSession called before the end of Setup.php" warning due to Echo
 ResolvedPRODUCTION ERRORNoneT151291 "User::loadFromSession called before the end of Setup.php" warning due to AbuseFilter
 ResolvedPRODUCTION ERRORUmherirrenderT151292 "User::loadFromSession called before the end of Setup.php" warning due to AntiSpoof
 ResolvedPRODUCTION ERRORAddshoreT177524 "User::loadFromSession called before the end of Setup.php" due to a combination of TwoColConflict and BetaFeatures
 ResolvedNoneT177590 New filters for edit review can't be opt-out on some wikis
 ResolvedPRODUCTION ERRORAnomieT240083 "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]
 ResolvedUmherirrenderT267445 UserGetLanguageObjectHook is unsafe: "User::loadFromSession called before the end of Setup.php" [8H investigate]
 ResolvedPRODUCTION ERRORTgrT297855 Session user loaded before session set up in GrowthExperimentsMentorManager service
 ResolvedAnomieT124414 MassMessage Fatal error: CAS update failed on user_touched
 Resolvedbd808T124406 s7 master is executing 54K transactions/s
 ResolvedAnomieT124453 Meta login fails
 Resolvedbd808T124510 Page preview response not being cached for history navigation in 1.27.0-wmf11
 ResolvedAnomieT124620 SessionManager breaks cookie support check in wikisource.org login
 OpenNoneT124641 Cover WebResponse::setCookie() with tests to prevent eg: Notice: Undefined variable: date in includes/WebResponse.php on line <i>144
 ResolvedAnomieT124468 CentralAuth is not logging the user into loginwiki anymore
 ResolvedAnomieT124821 SessionManager: unexpectedly logged out after visiting another wiki
 ResolvedPRODUCTION ERRORAnomieT124971 Sessions can only be imported when none is active.
 DeclinedNoneT125054 Sharp dip in MediaWiki.site.users metric since wmf11 roll-out
 ResolvedAnomieT125133 Accounts are not autocreated on loginwiki
 ResolvedAnomieT125139 Login to login.wikimedia.org fails with "No active login attempt is in progress for your session."
 ResolvedAnomieT125114 Accounts with user_token not set can't login to wmf.11 ("cookies not set" error)
 ResolvedTgrT125151 Fatal Call to a member function getTitle() on a non-object (NULL) following wmf11 to all wikis
Restricted Task
 ResolvedAnomieT125194 Possibly getting logged out within the same session after inactivity
 ResolvedoriT125267 ~3000% increase in session redis memory usage, causing evictions and session loss
 Resolved• csteippT125283 Users occasionally logged in as different users after SessionManager deployment
 ResolvedTgrT125313 Session error message when trying to execute sysop/CU/OS actions
 Resolvedbd808T125452 Review and enhance the debug logging for SessionManager
 DeclinedNoneT125455 Track ip addresses associated with a session and log when anomalous
 ResolvedPleaseStandT126495 IPSet::__construct() in gets into infinite loop when called from curl on a CI host
 ResolvedLegoktmT128167 Tag versions of IPSet in git
 ResolvedLegoktmT128169 Bump MediaWiki wikimedia/ip-set version to include fix for xdebug.max_nesting_level = 100
 OpenNoneT125599 Create some end-to-end tests for SessionManager
 ResolvedTgrT126069 Collect information about session pollution during the previous SessionManager rollouts
 ResolvedTgrT124440 Invalidate all users sessions
 ResolvedAnomieT124409 Logging out immediately logs you back in
 DuplicateNoneT126550 Central login from Commons/Meta mobile domain broken with SessionManager
 ResolvedAnomieT49647 meta.m.wikimedia.org user login doesn't work
 Resolvedbd808T126680 Huggle3 getting "WrongToken" response to authentication attempt against MW 1.27.0-wmf.13
 ResolvedTgrT70012 CentralAuthHooks::attemptAddUser: failed with message Username entered already in use. on loginwiki
 InvalidAnomieT126724 mw1.27#wmf13 update breaks GlobalReplace: "result: WrongToken"
 ResolvedTgrT127233 Endpoints which do not need to authenticate users should set MW_NO_SESSION
 ResolvedJdlrobsonT127860 MobileFrontend using ResourceLoaderGetConfigVars hook with User dependent data
 Resolvedbd808T127864 CitoidDataModule depends on request data
 ResolvedNoneT127866 WikimediaMessagesHooks::onMobileLicenseLink() unstubs $wgUser during ResourceLoaderGetConfigVars hook
 ResolvedTgrT127870 QuickSurveys\Hooks::onResourceLoaderRegisterModules() depends on request data
 ResolvedNoneT127871 MobileFrontendSkinHooks::getPluralLicenseInfo() unstubs $wgUser during ResourceLoaderGetConfigVars hook
 ResolvedNoneT127872 Wikibase\SitesModule depends on request data
 Resolvedbd808T127916 CiteDataModule depends on request data
 ResolvedLegoktmT129397 FlowHooks::onMessageCacheGet() may be called during load.php and depends on the session user language
 DeclinedAnomieT130720 Have load.php set $wgLang and the RequestContext language
 ResolvedLegoktmT131176 Wikibase\Repo\Hooks\LinkBeginHookHandler unstubs $wgLang unnecessarily during LinkBegin hook
 DeclinedNoneT134562 SMW triggers "Sessions are disabled for this entry point"
 ResolvedAnomieT135389 opensearch_desc calls Title::getLocalURL which unstubs wgUser on wikis with a variant
Restricted Task

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Tgr mentioned this in T124252: NEED_TOKEN error spike when 1.27-wmf.11 SessionManager was deployed to group1.Jan 21 2016, 12:45 PM
Tgr added subtasks: T74791: Newly created accounts are not global (at least, according to OAuth), T124356: Incorrect TOC and section edit links rendering in Vector due to ParserCache corruption via ParserOutput::setText( ParserOutput::getText() ), T124335: bot_passwords table expected to exist despite wgEnableBotPasswords = false.Jan 21 2016, 10:29 PM
Tgr added subtasks: T124371: Clean up usage of $_SESSION in WMF-deployed extensions, T124367: User::loadFromSession called before the end of Setup.php.Jan 21 2016, 11:25 PM
Tgr edited subtasks, added: T124384: [Panic] Login broken in app?; removed: T124356: Incorrect TOC and section edit links rendering in Vector due to ParserCache corruption via ParserOutput::setText( ParserOutput::getText() ).Jan 22 2016, 6:43 AM
Legoktm closed subtask T74791: Newly created accounts are not global (at least, according to OAuth) as Resolved.Jan 22 2016, 6:01 PM
Legoktm reopened subtask T74791: Newly created accounts are not global (at least, according to OAuth) as Open.Jan 22 2016, 6:18 PM
Tgr added subtasks: T124414: MassMessage Fatal error: CAS update failed on user_touched, T124406: s7 master is executing 54K transactions/s.Jan 22 2016, 7:08 PM
Tgr added a subtask: T124453: Meta login fails.
Legoktm closed subtask T74791: Newly created accounts are not global (at least, according to OAuth) as Resolved.Jan 22 2016, 9:57 PM
Tgr reopened this task as Open.Jan 23 2016, 3:28 AM

This week's deployment was rolled back unfortunately, so we can as well as reopen this.

Tgr removed a subtask: T124384: [Panic] Login broken in app?.Jan 23 2016, 5:39 PM
jeremyb-phone added a subscriber: jeremyb.Jan 23 2016, 5:46 PM
Tgr added a subtask: T124409: Logging out immediately logs you back in.Jan 23 2016, 5:59 PM
Anomie closed subtask T124126: Can neither load the session nor create an empty session as Resolved.Jan 23 2016, 7:10 PM
Tgr added a subtask: T124510: Page preview response not being cached for history navigation in 1.27.0-wmf11.Jan 23 2016, 7:14 PM
bd808 subscribed.Jan 24 2016, 5:46 AM
Tgr added a subtask: T124620: SessionManager breaks cookie support check in wikisource.org login.Jan 24 2016, 7:56 PM
bd808 added a subtask: T124641: Cover WebResponse::setCookie() with tests to prevent eg: Notice: Undefined variable: date in includes/WebResponse.php on line <i>144.Jan 25 2016, 4:05 PM
bd808 moved this task from Backlog to In Dev/Progress on the Reading-Infrastructure-Team-Old (Don't use) board.Jan 25 2016, 5:37 PM
Anomie closed subtask T124620: SessionManager breaks cookie support check in wikisource.org login as Resolved.Jan 26 2016, 12:34 AM
bd808 closed subtask T124510: Page preview response not being cached for history navigation in 1.27.0-wmf11 as Resolved.Jan 26 2016, 2:04 AM
bd808 added a subtask: T124468: CentralAuth is not logging the user into loginwiki anymore.
Tgr added a subtask: T124821: SessionManager: unexpectedly logged out after visiting another wiki.Jan 26 2016, 8:51 PM
Anomie closed subtask T124821: SessionManager: unexpectedly logged out after visiting another wiki as Resolved.Jan 27 2016, 5:22 PM
Tgr added a subtask: T124971: Sessions can only be imported when none is active..Jan 27 2016, 8:47 PM
Tgr added a subtask: T125054: Sharp dip in MediaWiki.site.users metric since wmf11 roll-out.Jan 28 2016, 10:23 AM
Anomie closed subtask T124971: Sessions can only be imported when none is active. as Resolved.Jan 28 2016, 5:14 PM
bd808 added a subtask: T125133: Accounts are not autocreated on loginwiki.Jan 28 2016, 7:22 PM
bd808 added a subtask: T125139: Login to login.wikimedia.org fails with "No active login attempt is in progress for your session.".Jan 28 2016, 8:04 PM
Tgr added a subtask: T125114: Accounts with user_token not set can't login to wmf.11 ("cookies not set" error).Jan 28 2016, 8:07 PM
Tgr added a subtask: T125151: Fatal Call to a member function getTitle() on a non-object (NULL) following wmf11 to all wikis.Jan 28 2016, 9:59 PM
Tgr reopened subtask T124414: MassMessage Fatal error: CAS update failed on user_touched as Open.Jan 28 2016, 10:14 PM
Jdforrester-WMF closed subtask T125114: Accounts with user_token not set can't login to wmf.11 ("cookies not set" error) as Resolved.Jan 28 2016, 10:23 PM
Liuxinyu970226 added a project: User-notice.Jan 29 2016, 1:16 AM
Liuxinyu970226 moved this task from To Triage to In current Tech/News draft on the User-notice board.
Tgr added a subtask: Restricted Task.Jan 29 2016, 2:15 AM
Luke081515 closed this task as Resolved.Jan 29 2016, 3:03 PM
Luke081515 subscribed.

Group 2 deployed yesterday.

bd808 reopened this task as Open.Jan 29 2016, 4:37 PM
In T123451#1981596, @Luke081515 wrote:

Group 2 deployed yesterday.

It certainly did, but we have a few cleanup tasks still to stay on top of as the blockers for this task show.

bd808 added a subtask: T125194: Possibly getting logged out within the same session after inactivity.Jan 29 2016, 4:56 PM
Anomie closed subtask T125133: Accounts are not autocreated on loginwiki as Resolved.Jan 29 2016, 6:03 PM
Anomie closed subtask T124453: Meta login fails as Resolved.Jan 29 2016, 9:11 PM
bd808 added a subtask: T125267: ~3000% increase in session redis memory usage, causing evictions and session loss.Jan 30 2016, 1:17 AM
Anomie closed subtask T125194: Possibly getting logged out within the same session after inactivity as Resolved.Jan 30 2016, 1:44 AM
ori closed subtask T125267: ~3000% increase in session redis memory usage, causing evictions and session loss as Resolved.Jan 30 2016, 8:50 AM
Tgr added a subtask: T125283: Users occasionally logged in as different users after SessionManager deployment.Jan 30 2016, 9:57 AM
Tgr closed subtask Restricted Task as Resolved.
Tgr closed subtask T125151: Fatal Call to a member function getTitle() on a non-object (NULL) following wmf11 to all wikis as Resolved.Jan 30 2016, 10:00 AM
Tgr added a subtask: T125313: Session error message when trying to execute sysop/CU/OS actions.Jan 31 2016, 12:45 AM
Aklapper mentioned this in T125143: Blockers to deploying 1.27-wmf.11.Feb 1 2016, 3:48 PM
bd808 added a subtask: T125599: Create some end-to-end tests for SessionManager.Feb 3 2016, 12:37 AM
Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Feb 3 2016, 1:17 PM
Johan moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Feb 3 2016, 1:21 PM
Anomie closed subtask T125139: Login to login.wikimedia.org fails with "No active login attempt is in progress for your session." as Resolved.Feb 4 2016, 4:33 PM
Anomie closed subtask T124409: Logging out immediately logs you back in as Resolved.Feb 4 2016, 4:43 PM
Anomie closed subtask T124252: NEED_TOKEN error spike when 1.27-wmf.11 SessionManager was deployed to group1 as Resolved.Feb 4 2016, 4:57 PM
• MZMcBride subscribed.Feb 4 2016, 7:37 PM
Krenair changed the status of subtask T125313: Session error message when trying to execute sysop/CU/OS actions from Open to Stalled.Feb 7 2016, 12:56 AM
Anomie closed subtask T124414: MassMessage Fatal error: CAS update failed on user_touched as Resolved.Feb 8 2016, 4:09 PM
bd808 added a subtask: T126069: Collect information about session pollution during the previous SessionManager rollouts.Feb 8 2016, 8:45 PM
bd808 added a subtask: T124440: Invalidate all users sessions.Feb 8 2016, 8:55 PM
bd808 closed subtask T125452: Review and enhance the debug logging for SessionManager as Resolved.Feb 8 2016, 11:57 PM
Tgr closed subtask T124440: Invalidate all users sessions as Resolved.Feb 10 2016, 9:42 PM
Tgr added a subtask: T126550: Central login from Commons/Meta mobile domain broken with SessionManager.Feb 10 2016, 10:37 PM
bd808 added a subtask: T49647: meta.m.wikimedia.org user login doesn't work.Feb 10 2016, 11:43 PM
bd808 triaged this task as High priority.Feb 11 2016, 1:10 AM
bd808 closed subtask T49647: meta.m.wikimedia.org user login doesn't work as Resolved.Feb 11 2016, 2:02 AM
bd808 added a subtask: T126680: Huggle3 getting "WrongToken" response to authentication attempt against MW 1.27.0-wmf.13.Feb 11 2016, 10:15 PM
Tgr added a subtask: T70012: CentralAuthHooks::attemptAddUser: failed with message Username entered already in use. on loginwiki.Feb 11 2016, 10:52 PM
hashar added a subtask: T126724: mw1.27#wmf13 update breaks GlobalReplace: "result: WrongToken".Feb 12 2016, 11:32 AM
hashar mentioned this in T126724: mw1.27#wmf13 update breaks GlobalReplace: "result: WrongToken".Feb 12 2016, 11:35 AM
Anomie closed subtask T126724: mw1.27#wmf13 update breaks GlobalReplace: "result: WrongToken" as Invalid.Feb 12 2016, 2:54 PM
bd808 closed subtask T126680: Huggle3 getting "WrongToken" response to authentication attempt against MW 1.27.0-wmf.13 as Resolved.Feb 12 2016, 10:05 PM
Luke081515 changed the status of subtask T125313: Session error message when trying to execute sysop/CU/OS actions from Stalled to Open.Feb 14 2016, 4:07 PM
bd808 added a subtask: T127233: Endpoints which do not need to authenticate users should set MW_NO_SESSION.Feb 23 2016, 4:46 PM
Tgr closed subtask T125455: Track ip addresses associated with a session and log when anomalous as Declined.Feb 24 2016, 1:13 AM
Tgr closed subtask T70012: CentralAuthHooks::attemptAddUser: failed with message Username entered already in use. on loginwiki as Resolved.Mar 4 2016, 1:49 AM
Tgr closed subtask T125313: Session error message when trying to execute sysop/CU/OS actions as Resolved.Mar 4 2016, 1:57 AM
Tgr added a subtask: Restricted Task.
Tgr closed subtask T126069: Collect information about session pollution during the previous SessionManager rollouts as Resolved.Mar 4 2016, 2:00 AM
Tgr changed the status of subtask T125283: Users occasionally logged in as different users after SessionManager deployment from Open to Stalled.Mar 9 2016, 7:35 PM
Anomie closed this task as Resolved.Mar 14 2016, 5:54 PM

This is obviously resolved since SessionManager had been deployed for about a month now.

• csteipp closed subtask T125283: Users occasionally logged in as different users after SessionManager deployment as Resolved.Apr 19 2016, 5:13 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 5:13 PM
Bawolff closed subtask Restricted Task as Resolved.Jun 27 2016, 9:35 AM
Aklapper closed subtask T125054: Sharp dip in MediaWiki.site.users metric since wmf11 roll-out as Declined.Nov 18 2016, 12:17 PM
• Fjalapeno edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Reading-Infrastructure-Team-Old (Don't use).Jun 7 2017, 2:57 PM
RuyP reopened subtask T125133: Accounts are not autocreated on loginwiki as Open.Aug 16 2017, 3:49 AM
Anomie closed subtask T125133: Accounts are not autocreated on loginwiki as Resolved.Aug 16 2017, 7:09 PM
Anomie closed subtask T127233: Endpoints which do not need to authenticate users should set MW_NO_SESSION as Resolved.Oct 11 2018, 2:01 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 6:37 PM
Aklapper closed subtask T124367: User::loadFromSession called before the end of Setup.php as Resolved.Jul 18 2021, 1:02 PM
Tgr reopened subtask T124367: User::loadFromSession called before the end of Setup.php as Open.Jul 18 2021, 3:39 PM
Umherirrender closed subtask T124367: User::loadFromSession called before the end of Setup.php as Resolved.Dec 28 2021, 11:11 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits