Page MenuHomePhabricator
Create Task
Maniphest T129397

FlowHooks::onMessageCacheGet() may be called during load.php and depends on the session user language
Closed, ResolvedPublic
Actions

Description

URL: https://test2.wikipedia.org/w/load.php?debug=false&lang=fr&modules=startup&only=scripts&skin=vector
URL: https://www.mediawiki.org/w/load.php?debug=false&lang=he&modules=startup&only=scripts&skin=vector

/srv/mediawiki/php-1.27.0-wmf.16/includes/session/SessionManager.php:296
/srv/mediawiki/php-1.27.0-wmf.16/includes/session/SessionManager.php:230
/srv/mediawiki/php-1.27.0-wmf.16/includes/session/SessionManager.php:184
/srv/mediawiki/php-1.27.0-wmf.16/includes/WebRequest.php:664
/srv/mediawiki/php-1.27.0-wmf.16/includes/user/User.php:1214
/srv/mediawiki/php-1.27.0-wmf.16/includes/user/User.php:402
/srv/mediawiki/php-1.27.0-wmf.16/includes/user/User.php:5127
/srv/mediawiki/php-1.27.0-wmf.16/includes/user/User.php:2750
/srv/mediawiki/php-1.27.0-wmf.16/includes/context/RequestContext.php:368
/srv/mediawiki/php-1.27.0-wmf.16/includes/StubObject.php:204
/srv/mediawiki/php-1.27.0-wmf.16/includes/StubObject.php:160
/srv/mediawiki/php-1.27.0-wmf.16/includes/StubObject.php:104
/srv/mediawiki/php-1.27.0-wmf.16/includes/StubObject.php:179
/srv/mediawiki/php-1.27.0-wmf.16/includes/cache/MessageCache.php:824
/srv/mediawiki/php-1.27.0-wmf.16/includes/cache/MessageCache.php:767
/srv/mediawiki/php-1.27.0-wmf.16/includes/Message.php:1148
/srv/mediawiki/php-1.27.0-wmf.16/includes/Message.php:910
/srv/mediawiki/php-1.27.0-wmf.16/extensions/Flow/Hooks.php:1060
/srv/mediawiki/php-1.27.0-wmf.16/includes/Hooks.php:195
/srv/mediawiki/php-1.27.0-wmf.16/includes/cache/MessageCache.php:759
/srv/mediawiki/php-1.27.0-wmf.16/includes/Message.php:1148
/srv/mediawiki/php-1.27.0-wmf.16/includes/Message.php:771
/srv/mediawiki/php-1.27.0-wmf.16/includes/Message.php:874
/srv/mediawiki/php-1.27.0-wmf.16/includes/cache/MessageBlobStore.php:220
/srv/mediawiki/php-1.27.0-wmf.16/includes/cache/MessageBlobStore.php:240
/srv/mediawiki/php-1.27.0-wmf.16/includes/cache/MessageBlobStore.php:163
/srv/mediawiki/php-1.27.0-wmf.16/includes/cache/MessageBlobStore.php:116
/srv/mediawiki/php-1.27.0-wmf.16/includes/resourceloader/ResourceLoader.php:152
/srv/mediawiki/php-1.27.0-wmf.16/includes/resourceloader/ResourceLoaderStartUpModule.php:392
/srv/mediawiki/php-1.27.0-wmf.16/includes/resourceloader/ResourceLoaderStartUpModule.php:374
/srv/mediawiki/php-1.27.0-wmf.16/includes/resourceloader/ResourceLoaderModule.php:707
/srv/mediawiki/php-1.27.0-wmf.16/includes/resourceloader/ResourceLoader.php:622
{"function":"Closure$ResourceLoader::getCombinedVersion","args":["startup"]}
/srv/mediawiki/php-1.27.0-wmf.16/includes/resourceloader/ResourceLoader.php:623
/srv/mediawiki/php-1.27.0-wmf.16/includes/resourceloader/ResourceLoader.php:675
/srv/mediawiki/php-1.27.0-wmf.16/load.php:44
/srv/mediawiki/w/load.php:3

I note most requests don't seem to hit this, it probably depends on stuff expiring from MessageBlobStore's cache.

I don't know why this code exists in Flow in the first place, instead of being part of WikimediaMessagesHooks::onMessageCacheGet().

Details

SubjectRepoBranchLines +/-
Remove Wikimedia-specific MessageCache::get hook handlermediawiki/extensions/Flowmaster+0 -39
Add Flow terms of use messages to onMessageCacheGet hook handlermediawiki/extensions/WikimediaMessagesmaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Anomie created this task.Mar 9 2016, 8:12 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 9 2016, 8:12 PM
• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Mar 9 2016, 8:46 PM
gerritbot added a comment.Mar 30 2016, 9:48 PM

Change 280587 had a related patch set uploaded (by Legoktm):
Add Flow terms of use messages to onMessageCacheGet hook handler

https://gerrit.wikimedia.org/r/280587

gerritbot added a project: Patch-For-Review.Mar 30 2016, 9:48 PM

Change 280588 had a related patch set uploaded (by Legoktm):
Remove Wikimedia-specific MessageCache::get hook handler

https://gerrit.wikimedia.org/r/280588

Legoktm claimed this task.Mar 30 2016, 9:55 PM
gerritbot added a comment.Mar 31 2016, 2:41 AM

Change 280587 merged by jenkins-bot:
Add Flow terms of use messages to onMessageCacheGet hook handler

https://gerrit.wikimedia.org/r/280587

gerritbot added a comment.Mar 31 2016, 2:50 AM

Change 280588 merged by jenkins-bot:
Remove Wikimedia-specific MessageCache::get hook handler

https://gerrit.wikimedia.org/r/280588

Legoktm closed this task as Resolved.Mar 31 2016, 2:55 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Mar 31 2016, 9:02 AM
Rical unsubscribed.Mar 31 2016, 12:34 PM
Legoktm mentioned this in T115680: FlowHooks::onMessageCacheGet() should not have Wikimedia-specific code.Sep 12 2018, 6:03 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits