Wikibase\Repo\Hooks\LinkBeginHookHandler unstubs $wgLang unnecessarily during LinkBegin hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Mar 29 2016, 6:04 PM

Description

/srv/mediawiki/php-1.27.0-wmf.18/includes/session/SessionManager.php:186
/srv/mediawiki/php-1.27.0-wmf.18/includes/WebRequest.php:683
/srv/mediawiki/php-1.27.0-wmf.18/includes/user/User.php:1208
/srv/mediawiki/php-1.27.0-wmf.18/includes/user/User.php:402
/srv/mediawiki/php-1.27.0-wmf.18/includes/user/User.php:5122
/srv/mediawiki/php-1.27.0-wmf.18/includes/user/User.php:2744
/srv/mediawiki/php-1.27.0-wmf.18/includes/context/RequestContext.php:368
/srv/mediawiki/php-1.27.0-wmf.18/extensions/Wikidata/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php:193
/srv/mediawiki/php-1.27.0-wmf.18/extensions/Wikidata/extensions/Wikibase/repo/includes/Hooks/LinkBeginHookHandler.php:69
/srv/mediawiki/php-1.27.0-wmf.18/extensions/Wikidata/extensions/Wikibase/repo/includes/Hooks/LinkBeginHookHandler.php:97
/srv/mediawiki/php-1.27.0-wmf.18/includes/Hooks.php:195
/srv/mediawiki/php-1.27.0-wmf.18/includes/Linker.php:213
/srv/mediawiki/php-1.27.0-wmf.18/includes/parser/LinkHolderArray.php:420
/srv/mediawiki/php-1.27.0-wmf.18/includes/parser/LinkHolderArray.php:271
/srv/mediawiki/php-1.27.0-wmf.18/includes/parser/Parser.php:5291
/srv/mediawiki/php-1.27.0-wmf.18/includes/parser/Parser.php:1315
/srv/mediawiki/php-1.27.0-wmf.18/includes/parser/Parser.php:449
/srv/mediawiki/php-1.27.0-wmf.18/includes/cache/MessageCache.php:1090
/srv/mediawiki/php-1.27.0-wmf.18/includes/Message.php:1109
/srv/mediawiki/php-1.27.0-wmf.18/includes/Message.php:791
/srv/mediawiki/php-1.27.0-wmf.18/includes/Message.php:847
/srv/mediawiki/php-1.27.0-wmf.18/extensions/MobileFrontend/includes/modules/MFResourceLoaderParsedMessageModule.php:47
/srv/mediawiki/php-1.27.0-wmf.18/extensions/MobileFrontend/includes/modules/MFResourceLoaderParsedMessageModule.php:78
/srv/mediawiki/php-1.27.0-wmf.18/includes/resourceloader/ResourceLoaderModule.php:588
/srv/mediawiki/php-1.27.0-wmf.18/includes/resourceloader/ResourceLoaderModule.php:556
/srv/mediawiki/php-1.27.0-wmf.18/includes/resourceloader/ResourceLoader.php:973
/srv/mediawiki/php-1.27.0-wmf.18/includes/resourceloader/ResourceLoader.php:702
/srv/mediawiki/php-1.27.0-wmf.18/load.php:47
/srv/mediawiki/w/load.php:3

More specifically, this occurs when a ResourceLoader module parses a message on wikidata.org that contains a link. I note that the hook handler doesn't actually do anything in the load.php code path since there will be no Title set so shouldConvert() will return false.

Details

	Subject	Repo	Branch	Lines +/-
	Short-circuit LinkBegin hook if no title is set in the main context	mediawiki/extensions/Wikibase	master	+6 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Deskana	T75616 Tracking: API/backend issues blocking Wikipedia app development
Resolved		Anomie	T32788 Allow triggering of user password reset email via the API
Open		None	T90925 General authentication improvements for MediaWiki
Resolved		Anomie	T48179 Allow a challenge stage during authentication
Open		None	T5709 Refactoring to make external authentication and identity systems easier
Resolved		Tgr	T43201 UserLoadFromSession considered evil
Resolved		Anomie	T67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
Open	Feature	None	T55156 Provide option to force a login session to end within a certain time
Open		None	T89459 Modernize MediaWiki authentication system (AuthManager)
Resolved		Anomie	T123451 Deploy SessionManager and bot passwords
Resolved		Tgr	T127233 Endpoints which do not need to authenticate users should set MW_NO_SESSION
Resolved		Legoktm	T131176 Wikibase\Repo\Hooks\LinkBeginHookHandler unstubs $wgLang unnecessarily during LinkBegin hook

Event Timeline

Anomie created this task.Mar 29 2016, 6:04 PM

Krinkle unsubscribed.Mar 29 2016, 9:33 PM

Anomie added a subscriber: daniel.Apr 2 2016, 7:09 AM

Legoktm claimed this task.Apr 6 2016, 9:17 PM

Change 282064 had a related patch set uploaded (by Legoktm):
Short-circuit LinkBegin hook if no title is set in the main context

https://gerrit.wikimedia.org/r/282064

gerritbot added a project: Patch-For-Review.Apr 6 2016, 9:54 PM

Change 282064 merged by jenkins-bot:
Short-circuit LinkBegin hook if no title is set in the main context

https://gerrit.wikimedia.org/r/282064

hoo closed this task as Resolved.Apr 6 2016, 10:34 PM

hoo edited projects, added MediaWiki-extensions-WikibaseRepository; removed Patch-For-Review.

When can we expect this fix to be deployed to WMF wikis?

It was synced from Wikibase to Wikidata in 264ab0627068 on 2016-04-07. Should be in prod this week.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM

Wikibase\Repo\Hooks\LinkBeginHookHandler unstubs $wgLang unnecessarily during LinkBegin hookClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Wikibase\Repo\Hooks\LinkBeginHookHandler unstubs $wgLang unnecessarily during LinkBegin hook
Closed, ResolvedPublic
Actions

Related Objects
Search...