"User::loadFromSession called before the end of Setup.php" warning due to Echo
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Something deep inside Echo is using a Message object with the default $wgLang language despite being called during account auto-creation when $wgUser and $wgLang is not yet available.

Stack trace:

/srv/mediawiki/php-1.28.0-wmf.9/includes/user/User.php:5305
/srv/mediawiki/php-1.28.0-wmf.9/includes/user/User.php:2876
/srv/mediawiki/php-1.28.0-wmf.9/includes/context/RequestContext.php:363
/srv/mediawiki/php-1.28.0-wmf.9/includes/Message.php:364
/srv/mediawiki/php-1.28.0-wmf.9/includes/Message.php:1182
/srv/mediawiki/php-1.28.0-wmf.9/includes/Message.php:944
/srv/mediawiki/php-1.28.0-wmf.9/extensions/Echo/includes/ForeignNotifications.php:227
/srv/mediawiki/php-1.28.0-wmf.9/extensions/Echo/includes/ForeignNotifications.php:207
/srv/mediawiki/php-1.28.0-wmf.9/extensions/Echo/includes/ForeignWikiRequest.php:48
/srv/mediawiki/php-1.28.0-wmf.9/extensions/Echo/includes/ForeignWikiRequest.php:25
/srv/mediawiki/php-1.28.0-wmf.9/extensions/Echo/includes/NotifUser.php:710
/srv/mediawiki/php-1.28.0-wmf.9/extensions/Echo/includes/NotifUser.php:741
/srv/mediawiki/php-1.28.0-wmf.9/extensions/Echo/includes/NotifUser.php:488
/srv/mediawiki/php-1.28.0-wmf.9/extensions/Echo/Hooks.php:1147
/srv/mediawiki/php-1.28.0-wmf.9/includes/Hooks.php:195
/srv/mediawiki/php-1.28.0-wmf.9/includes/user/User.php:3952
/srv/mediawiki/php-1.28.0-wmf.9/includes/auth/AuthManager.php:1678
/srv/mediawiki/php-1.28.0-wmf.9/includes/Setup.php:861
/srv/mediawiki/php-1.28.0-wmf.9/includes/WebStart.php:137
/srv/mediawiki/php-1.28.0-wmf.9/index.php:40
/srv/mediawiki/w/index.php:3

Options to resolve this include:

Don't even run the hook when called during account autocreation (I suspect it's not necessary there).
Don't load messages in this code path (you don't seem to be actually using the result).
Test $wgUser->isSafeToLoad(), and when false use ->inLanguage() to set the Message's language to $wgContLang or some other constant.

Details

	Subject	Repo	Branch	Lines +/-
	ForeignWikiRequest: Also check User::isSafeToLoad()	mediawiki/extensions/Echo	master	+3 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Deskana	T75616 Tracking: API/backend issues blocking Wikipedia app development
Resolved		Anomie	T32788 Allow triggering of user password reset email via the API
Open		None	T90925 General authentication improvements for MediaWiki
Resolved		Anomie	T48179 Allow a challenge stage during authentication
Open		None	T5709 Refactoring to make external authentication and identity systems easier
Resolved		Tgr	T43201 UserLoadFromSession considered evil
Resolved		Anomie	T67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
Open	Feature	None	T55156 Provide option to force a login session to end within a certain time
Open		None	T89459 Modernize MediaWiki authentication system (AuthManager)
Resolved		Anomie	T123451 Deploy SessionManager and bot passwords
Resolved	PRODUCTION ERROR	None	T124367 User::loadFromSession called before the end of Setup.php
Resolved	PRODUCTION ERROR	Catrope	T139665 "User::loadFromSession called before the end of Setup.php" warning due to Echo

Event Timeline

Anomie created this task.Jul 7 2016, 9:12 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 7 2016, 9:12 PM

• Mattflaschen-WMF added a project: Collab-Team-2016-Apr-Jun-Q4.Jul 7 2016, 9:21 PM

• Mattflaschen-WMF edited projects, added Collab-Team-Q1-July-Sep-2016; removed Collab-Team-2016-Apr-Jun-Q4.Jul 7 2016, 9:41 PM

Anomie updated the task description. (Show Details)Jul 12 2016, 1:52 PM

Change 299673 had a related patch set uploaded (by Catrope):
ForeignWikiRequest: Also check User::isSafeToLoad()

https://gerrit.wikimedia.org/r/299673

gerritbot added a project: Patch-For-Review.Jul 18 2016, 9:52 PM

My patch avoids going into this code path at all if $wgUser->isSafeToLoad() is false.

• Mattflaschen-WMF subscribed.Jul 19 2016, 12:19 AM

Change 299673 merged by jenkins-bot:
ForeignWikiRequest: Also check User::isSafeToLoad()

https://gerrit.wikimedia.org/r/299673

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)).Jul 19 2016, 1:00 AM

SBisson moved this task from Needs Review to QA Review on the Collab-Team-Q1-July-Sep-2016 board.Jul 19 2016, 2:55 PM

Checked user auto-creation in betalabs - no problems found.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-Q1-July-Sep-2016 board.Jul 19 2016, 11:22 PM

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jul 20 2016, 1:44 AM

• jmatazzoni closed this task as Resolved.Jul 20 2016, 8:57 PM

Reedy removed a project: Patch-For-Review.May 17 2019, 9:47 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM

DannyS712 mentioned this in T243732: Echo needs uses of global $wgUser removed.Jan 27 2020, 1:51 AM

Reedy mentioned this in T262110: ForeignWikiRequest uses $wgUser (causes test failure).Sep 5 2020, 2:31 AM

Aklapper removed subscribers: • Mattflaschen-WMF, Anomie.Oct 16 2020, 5:42 PM

"User::loadFromSession called before the end of Setup.php" warning due to EchoClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related ObjectsSearch...

Event Timeline

"User::loadFromSession called before the end of Setup.php" warning due to Echo
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Related Objects
Search...