Echo needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Description

See parent task

The use of $wgUser was added as part of T139665: "User::loadFromSession called before the end of Setup.php" warning due to Echo
However, that patch added a check for both $wgUser->isSafeToLoad() and $this->user->isSafeToLoad(). Only the second should be needed, since the user is the context user that would be loaded

Details

	Subject	Repo	Branch	Lines +/-
	Remove use of global $wgUser	mediawiki/extensions/Echo	master	+2 -3
	NotificationsTest: No need to set $wgUser	mediawiki/extensions/Echo	master	+0 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved	DannyS712	T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
Resolved	DannyS712	T243732 Echo needs uses of global $wgUser removed
Resolved	Reedy	T262110 ForeignWikiRequest uses $wgUser (causes test failure)

Event Timeline

DannyS712 triaged this task as Medium priority.Jan 27 2020, 1:51 AM

DannyS712 created this task.

Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptJan 27 2020, 1:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 567374 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Remove use of global $wgUser

https://gerrit.wikimedia.org/r/567374

gerritbot added a project: Patch-For-Review.Jan 27 2020, 1:52 AM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jan 27 2020, 1:53 AM

DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Jan 28 2020, 8:50 PM

DannyS712 added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Feb 23 2020, 10:29 PM

DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.

Reedy added a subtask: T262110: ForeignWikiRequest uses $wgUser (causes test failure).Sep 5 2020, 2:46 AM

Reedy closed subtask T262110: ForeignWikiRequest uses $wgUser (causes test failure) as Resolved.Sep 5 2020, 3:39 AM

Reedy mentioned this in T262110: ForeignWikiRequest uses $wgUser (causes test failure).

DannyS712 removed DannyS712 as the assignee of this task.Sep 5 2020, 6:03 AM

Change 627224 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] NotificationsTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/627224

Change 627224 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] NotificationsTest: No need to set $wgUser

https://gerrit.wikimedia.org/r/627224

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 15 2020, 2:00 AM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM

Change 567374 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Remove use of global $wgUser

https://gerrit.wikimedia.org/r/567374

DannyS712 closed this task as Resolved.Jul 15 2021, 4:09 AM

DannyS712 claimed this task.

DannyS712 removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 15 2021, 5:00 AM