[GOAL] Emit deprecation warnings reading from $wgUser
Closed, ResolvedPublic
Actions

Description

This is the final step of deprecating read access. Subtasks are the specific blockers. Of note, this does not require that all uses be removed, as extensions that are not deployed or extensions that write to $wgUser do not need to be fixed before reads can be deprecated.

Use of $wgUser was officially (soft) deprecated in 1.35

Details

Subject	Repo	Branch	Lines +/-
Emit deprecation warnings reading from $wgUser	mediawiki/core	REL1_37	+382 -47
Emit deprecation warnings reading from $wgUser	mediawiki/core	master	+382 -47
StubObject: add magic __get() and __set()	mediawiki/core	master	+263 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
		Restricted Task
		· · ·

Event Timeline

DannyS712 triaged this task as Medium priority.Nov 15 2020, 12:23 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to Not yet on the Technical-Debt (Deprecation process) board.

DannyS712 added a project: Goal.

DannyS712 moved this task from Unsorted to Later on the User-DannyS712 board.

DannyS712 added subtasks: T243708: Mediawiki core needs uses of global $wgUser removed, T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].

DannyS712 added a subtask: Restricted Task.Nov 15 2020, 12:26 AM

JJMC89 moved this task from Backlog to Other on the MediaWiki-User-management board.Nov 28 2020, 4:37 PM

Urbanecm closed subtask Restricted Task as Resolved.Feb 18 2021, 1:59 AM

Change 702807 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] StubObject: add magic __get() and __set()

https://gerrit.wikimedia.org/r/702807

gerritbot added a project: Patch-For-Review.Jul 15 2021, 4:08 AM

DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Jul 15 2021, 4:11 AM

DannyS712 moved this task from Not yet to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.Sep 4 2021, 5:30 AM

DannyS712 moved this task from Later to In progress on the User-DannyS712 board.

We should get this in as part of 1.37 so that it can be removed in 1.38
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/701274 is my WIP for emitting the actually warnings, split https://gerrit.wikimedia.org/r/c/mediawiki/core/+/702807 (StubObject: add magic __get() and __set()) into a separate patch for review - once that merges I'll update the patch to actually emit.

All deployed extensions that interact with $wgUser do so to write to it, and can continue to do so for 1.37 - writes will be removed in 1.38

DannyS712 closed subtask T245959: WMF deployed extensions need uses of global $wgUser removed [tracking] as Resolved.Sep 4 2021, 5:36 AM

DannyS712 mentioned this in T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].

Change 702807 merged by jenkins-bot:

[mediawiki/core@master] StubObject: add magic __get() and __set()

https://gerrit.wikimedia.org/r/702807

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 4 2021, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2021, 7:10 AM

Change 718414 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Emit deprecation warnings reading from $wgUser

https://gerrit.wikimedia.org/r/718414

gerritbot added a project: Patch-For-Review.Sep 4 2021, 7:19 PM