Page MenuHomePhabricator

Create some end-to-end tests for SessionManager
Open, MediumPublic


Per the plan:

"6) Rest of week: Brad and Bryan to get some more end-to-end tests running with Dan"

Event Timeline

greg created this task.Feb 2 2016, 11:01 PM
greg assigned this task to Anomie.
greg raised the priority of this task from to Medium.
greg updated the task description. (Show Details)
greg added subscribers: greg, Aklapper, dduvall.
greg added subscribers: bd808, Tgr.Feb 2 2016, 11:43 PM
bd808 added a comment.Feb 3 2016, 12:10 AM

@greg I completely agree that this ended up in the planning email but both @Anomie and I are a bit at a loss as to what @dduvall was suggesting for the new tests to do. I guess the first thing we need to do is work that out? I remember him saying something about a series of tests that would run with massive parallelism?

greg added a comment.Feb 3 2016, 12:12 AM

Yep, that's the first step: clarifying purpose and plan.

It was sort of a stab in the dark, but my thought was to try performing a high number of concurrent logins on testwiki or test2wiki—or somewhere else we can have a setup that's close enough to production and has both SessionManager and CentralAuth in the mix, like mw1017. I would need a pool of user accounts (maybe ~100 to start) and somewhere I could set up and run Gatling.

It's admittedly a very brute force approach so, since y'all know the nature of this code much more intimately, let me know if this is categorically a waste of time and I won't bother with it.

In general and in light of this particular case, I do think it's a good idea to broaden our end-to-end test cases for authentication and exercise them regularly against production wikis—I'd also like to make this a formal part of the train process to verify group0 and group1. Right now, we have 5 end-to-end test scenarios and they only run against BC; one scenario had also been falsely failing for over a month before I fixed it late last week so I kind of doubt we would have seen a useful failure had it occurred.

Anomie reassigned this task from Anomie to dduvall.Feb 3 2016, 10:12 PM
Anomie set Security to None.
Tgr added a comment.EditedFeb 4 2016, 11:22 PM

Not sure what benefit to expect from parallel logins, but having test for the various CA scenarios would be very useful. Some scenarios with significantly different code paths that come to mind:

  • login on loginwiki
  • login on another wiki
  • autologin on a $wgCentralAuthAutoLoginWikis wiki after logging in to a wiki on the same second-level domain
  • same with a browser that does not support third-party cookies
  • autologin on a $wgCentralAuthAutoLoginWikis wiki after logging in to a wiki on a different second-level domain
  • autologin on a non-$wgCentralAuthAutoLoginWikis wiki
  • autologin on a non-$wgCentralAuthAutoLoginWikis wiki with Javascript disabled

+ most of the above with "remember me" cookie set, with or without an active central session
+ most of the above with account creation instead of login
+ most of the above with autocreation instead of autologin
+ most of the above with API requests instead of a browser

  • OAuth request
  • bot password request

Edit: also, there are lots of different expiration scenarios (token cookie exists but session cookie expired, redis session expired, redis central session expired, loginwiki session expired...)

Tgr added a comment.Feb 7 2016, 1:55 AM

Some more information about CentralAuth code paths:

Thanks, @Tgr! It's tremendously helpful to have such well-defined scenarios to work from.

In our meeting last week, we came to the conclusion that this testing would not necessarily block wmf.13 since it's very unlikely to reproduce the reported behavior(s)—our current WebDriver-based test suite for CA does not reproduce them—but we will commit to improving coverage for the scenarios you've laid out. Having broader end-to-end tests for session management and integrating review of such test results as part of a healthier MW train should help to surface future issues before deployment to group1 and group2.

@greg, I'm not sure about priority at this point but perhaps this is something @zeljkofilipin or I can coordinate on with @Tgr, @Anomie et al early the next quarter? (As part of our "better MW train" commitment/narrative.)

bd808 added a comment.Feb 8 2016, 8:15 PM

I think we need these tests before rolling out AuthManager which is hopefully going to deploy this quarter.

greg removed dduvall as the assignee of this task.May 16 2017, 3:48 PM