opensearch_desc calls Title::getLocalURL which unstubs wgUser on wikis with a variant
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	May 16 2016, 2:30 PM

Description

zh.wiktionary.org/w/opensearch_desc.php
/srv/mediawiki/php-1.28.0-wmf.1/includes/session/SessionManager.php:985 BadMethodCallException
Sessions are supposed to be disabled for this entry point
/srv/mediawiki/php-1.28.0-wmf.1/includes/session/SessionManager.php:301
/srv/mediawiki/php-1.28.0-wmf.1/includes/session/SessionManager.php:235
/srv/mediawiki/php-1.28.0-wmf.1/includes/session/SessionManager.php:185
/srv/mediawiki/php-1.28.0-wmf.1/includes/WebRequest.php:700
/srv/mediawiki/php-1.28.0-wmf.1/includes/user/User.php:1211
/srv/mediawiki/php-1.28.0-wmf.1/includes/user/User.php:405
/srv/mediawiki/php-1.28.0-wmf.1/includes/user/User.php:5171
/srv/mediawiki/php-1.28.0-wmf.1/includes/user/User.php:2793
/srv/mediawiki/php-1.28.0-wmf.1/includes/context/RequestContext.php:363
/srv/mediawiki/php-1.28.0-wmf.1/includes/StubObject.php:197
/srv/mediawiki/php-1.28.0-wmf.1/includes/StubObject.php:159
/srv/mediawiki/php-1.28.0-wmf.1/includes/StubObject.php:104
/srv/mediawiki/php-1.28.0-wmf.1/includes/StubObject.php:129
/srv/mediawiki/php-1.28.0-wmf.1/includes/Title.php:1752
/srv/mediawiki/php-1.28.0-wmf.1/includes/Title.php:1846
/srv/mediawiki/php-1.28.0-wmf.1/opensearch_desc.php:85
/srv/mediawiki/w/opensearch_desc.php:3

opensearch_desc.php needs to return a "template" URL for Special:Search on which browsers can do a string replacement to get the actual search URL. That includes calling Title::getLocalURL which might need to replace variant parameters in the URL for variant wikis, and for that it needs to check whether the page language matches the site language. For that it needs to access $wgContLang, and that seems to be an instance of StubUserLang. Not sure how that can happen.

Details

	Subject	Repo	Branch	Lines +/-
	Avoid unstubbing $wgLang in Title::getLocalURL	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Deskana	T75616 Tracking: API/backend issues blocking Wikipedia app development
Resolved		Anomie	T32788 Allow triggering of user password reset email via the API
Open		None	T90925 General authentication improvements for MediaWiki
Resolved		Anomie	T48179 Allow a challenge stage during authentication
Open		None	T5709 Refactoring to make external authentication and identity systems easier
Resolved		Tgr	T43201 UserLoadFromSession considered evil
Resolved		Anomie	T67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
Open	Feature	None	T55156 Provide option to force a login session to end within a certain time
Open		None	T89459 Modernize MediaWiki authentication system (AuthManager)
Resolved		Anomie	T123451 Deploy SessionManager and bot passwords
Resolved		Tgr	T127233 Endpoints which do not need to authenticate users should set MW_NO_SESSION
Resolved		Anomie	T135389 opensearch_desc calls Title::getLocalURL which unstubs wgUser on wikis with a variant

Event Timeline

Tgr created this task.May 16 2016, 2:30 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 16 2016, 2:30 PM

Tgr added a parent task: T127233: Endpoints which do not need to authenticate users should set MW_NO_SESSION.May 16 2016, 2:31 PM

The line in question is Title.php line 1752

&& $wgContLang->getCode() === $this->getPageLanguage()->getCode()

It's not $wgContLang in that line that's the problem, it's $this->getPageLanguage():

public function getPageLanguage() {
    global $wgLang, $wgLanguageCode;
    if ( $this->isSpecialPage() ) {
        // special pages are in the user language
        return $wgLang;
    }

Change 288985 had a related patch set uploaded (by Anomie):
Avoid unstubbing $wgLang in Title::getLocalURL

https://gerrit.wikimedia.org/r/288985

gerritbot added a project: Patch-For-Review.May 16 2016, 4:57 PM

Change 288985 merged by jenkins-bot:
Avoid unstubbing $wgLang in Title::getLocalURL

https://gerrit.wikimedia.org/r/288985

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)).May 16 2016, 6:00 PM

Was fixed a while ago.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM

opensearch_desc calls Title::getLocalURL which unstubs wgUser on wikis with a variantClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

opensearch_desc calls Title::getLocalURL which unstubs wgUser on wikis with a variant
Closed, ResolvedPublic
Actions

Related Objects
Search...