Update Wikibase not to use deprecated EditPageBeforeEditChecks hook
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	matmarex
	Mar 30 2017, 4:40 PM

Description

The hook was deprecated in https://gerrit.wikimedia.org/r/#/c/344805/ (MW 1.29).

Use 'EditPageGetCheckboxesDefinition' instead, or 'EditPage::showStandardInputs:options' if you don't actually care about checkboxes and just want to add some HTML to the page.

Details

	Subject	Repo	Branch	Lines +/-
	Do not use the deprecated EditPageBeforeEditChecks hook	mediawiki/extensions/Wikibase	wmf/1.29.0-wmf.19	+4 -5
	Do not use the deprecated EditPageBeforeEditChecks hook	mediawiki/extensions/Wikibase	master	+4 -5

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T161809 Update extensions not to use deprecated EditPageBeforeEditChecks hook
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T162885 Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13
Resolved		Jdforrester-WMF	T161815 Update Wikibase not to use deprecated EditPageBeforeEditChecks hook

Event Timeline

matmarex created this task.Mar 30 2017, 4:40 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 30 2017, 4:40 PM

Change 345624 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/Wikibase@master] Do not use the deprecated EditPageBeforeEditChecks hook

https://gerrit.wikimedia.org/r/345624

gerritbot added a project: Patch-For-Review.Mar 30 2017, 6:41 PM

Jdforrester-WMF claimed this task.Mar 30 2017, 6:43 PM

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF added a project: VisualEditor.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 345624 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Do not use the deprecated EditPageBeforeEditChecks hook

https://gerrit.wikimedia.org/r/345624

hoo closed this task as Resolved.Apr 7 2017, 10:00 AM

hoo removed a project: Patch-For-Review.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 7 2017, 10:00 AM

Jdforrester-WMF set the point value for this task to 1.Apr 12 2017, 8:16 PM

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Apr 12 2017, 11:53 PM

Change 348079 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/extensions/Wikibase@wmf/1.29.0-wmf.19] Do not use the deprecated EditPageBeforeEditChecks hook

https://gerrit.wikimedia.org/r/348079

gerritbot added a project: Patch-For-Review.Apr 13 2017, 2:46 PM

Change 348079 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.29.0-wmf.19] Do not use the deprecated EditPageBeforeEditChecks hook

https://gerrit.wikimedia.org/r/348079

Jdforrester-WMF mentioned this in T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Apr 13 2017, 3:56 PM

Jdforrester-WMF added a parent task: T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Apr 13 2017, 4:17 PM

Ryasmeen moved this task from Verified to Non verifiable/Task on the User-Ryasmeen board.Apr 13 2017, 9:11 PM