Remove deprecated User::makeGroupLinkWiki() calls in SpecialGlobalUsers
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Actual error message from MediaWiki's CentralAuth extension:

Use of User::makeGroupLinkWiki was deprecated in MediaWiki 1.29. [Called from GlobalUsersPager::getUserGroups in /srv/mediawiki/php-1.31.0-wmf.10/extensions/CentralAuth/includes/specials/SpecialGlobalUsers.php at line 270]

We have to replace User::makeGroupLinkWiki() by the equivalent methods on the [[ https://doc.wikimedia.org/mediawiki-core/master/php/classUserGroupMembership.html | UserGroupMembership ]] class.

Details

	Subject	Repo	Branch	Lines +/-
	SpecialGlobalUsers: Replace User::makeGroupLinkWiki with newer function	mediawiki/extensions/CentralAuth	master	+5 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	PRODUCTION ERROR	None	T181834 Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01
		Resolved	PRODUCTION ERROR	rafidaslam	T181829 Remove deprecated User::makeGroupLinkWiki() calls in SpecialGlobalUsers

Event Timeline

• demon created this task.Dec 1 2017, 6:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2017, 6:25 PM

Jdforrester-WMF edited parent tasks, added: T181834: Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01; removed: T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Dec 1 2017, 6:46 PM

Jdforrester-WMF mentioned this in T181834: Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01.Dec 1 2017, 8:28 PM

Aklapper updated the task description. (Show Details)Dec 1 2017, 11:02 PM

Aklapper moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2017 board.

I'll mentor this for GCI.

@Legoktm Are you mentoring this task for GCI?

Thanks! Imported as https://codein.withgoogle.com/tasks/4566242679586816/

I'll work on this (claimed on Google Code-in)

Change 396077 had a related patch set uploaded (by Rafidaslam; owner: Rafid Aslam):
[mediawiki/extensions/CentralAuth@master] SpecialGlobalUsers: Replace User::makeGroupLinkWiki with newer function

https://gerrit.wikimedia.org/r/396077

gerritbot added a project: Patch-For-Review.Dec 7 2017, 6:35 PM

Change 396077 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] SpecialGlobalUsers: Replace User::makeGroupLinkWiki with newer function

https://gerrit.wikimedia.org/r/396077

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 8 2017, 4:01 PM

xSavitar mentioned this in T182445: Getting the "userName" to use in the UserGroupMembership::getLink().Dec 8 2017, 4:10 PM