Page MenuHomePhabricator

No line beneath title. Update vertical spacing beneath header once we're hiding this line.
Closed, InvalidPublic

Description

In mock below, note there is no horizontal divider below "January 22".

featured.png (1×750 px, 349 KB)

Note: horizontal dividers *remain* above nearby cells.

nearby.png (1×750 px, 212 KB)

Event Timeline

Mhurd raised the priority of this task from to Needs Triage.
Mhurd updated the task description. (Show Details)
Mhurd moved this task to Needs Triage on the Wikipedia-iOS-App-Backlog board.
Mhurd subscribed.
Mhurd updated the task description. (Show Details)

@Nirzar is that correct? You want horizontal lines for some headers but not others?

JMinor triaged this task as Lowest priority.Feb 3 2016, 1:04 AM

@JMinor this is very important. Let's not execute a visual design half way. IMO this is high priority for headers. The visual design change is sort of based on this. I would even want to revert to old headers without this.

The nearby is an (only) exception to this because of the layout of nearby cells, we will fix that inconsistency in 5.1

@JMinor - I don't believe @Nirzar's mock implies there are horizontal lines for some but not others, although at first glance it may appear so. Take another peek at the second screenshot. Those horizontal lines are above each *nearby* cell, not below the header. In this one case it just appears that the line in the nearby screenshot is part of the header, but it's actually part of the top nearby cell.

Yeah, no problem, just wanted to be sure the nearby being different wasn't just an oversight.

@Nirzar @JMinor I don't think if we should remove lines for everything but for nearby - this looks weird.

Let's not execute a visual design half way.

I wholeheartedly agree with this - to me this means NOT changing the design of every section EXCEPT nearby and then updating nearby in 5.1. Lets be self-consistent. If we want to remove
the lines, lets execute it in one go.

Also I think we should discus MVP and design freeze - this looks nice - but we really need to put finalize the scope of design changes for 5.0 - I want to app to look good for launch but I also want to launch.

Did we solve the issue of having an inconsistent line on nearby but not on any other headers?

cmadeo subscribed.

I am closing this as Invalid as we've since redesigned the feed.