Page MenuHomePhabricator

[Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions
Closed, ResolvedPublic1 Story Points

Description

See for yourself:

The height CSS on ve-ce-focusableNode-invisible seems to be the culprit:

Note both screenshots have been taken from https://www.mediawiki.org/wiki/Extension:Graph/Demo

Details

Related Gerrit Patches:
VisualEditor/VisualEditor : masterFocusableNode: watch for image loaded/layout changes for invisible icons
mediawiki/extensions/VisualEditor : wmf/1.27.0-wmf.12Default extensions to not use the 'invisible icon'
mediawiki/extensions/VisualEditor : masterDefault extensions to not use the 'invisible icon'
mediawiki/extensions/Graph : masterVE: Never use invisible icon

Event Timeline

ferdbold raised the priority of this task from to Needs Triage.
ferdbold updated the task description. (Show Details)
ferdbold added a subscriber: ferdbold.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 4 2016, 5:48 AM
ferdbold renamed this task from FocusableNode invisibles produces weird results with graphs to FocusableNode invisibles produces weird results with graph, templates and transclusions.Feb 4 2016, 5:48 AM
ferdbold added a project: VisualEditor.
ferdbold set Security to None.
ferdbold updated the task description. (Show Details)

Change 268429 had a related patch set uploaded (by Esanders):
VE: Never use invisible icon

https://gerrit.wikimedia.org/r/268429

DLynch added a subscriber: DLynch.Feb 4 2016, 6:23 PM

Glancing at this happening to Math, briefly, it seems like the issue is that when this.hasRendering() is checked, the math elements don't technically have a width / height yet.

We could adjust this check to happen later in the rendering, after the browser has time to decide how it feels about things like images. Or we could perhaps whitelist some node-types as "yeah, this'll be visible, don't need to check"?

Change 268437 had a related patch set uploaded (by DLynch):
Don't just rely on jQuery width / height for hasRendering

https://gerrit.wikimedia.org/r/268437

Ryasmeen renamed this task from FocusableNode invisibles produces weird results with graph, templates and transclusions to [Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions.Feb 4 2016, 7:07 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 268429 merged by jenkins-bot:
VE: Never use invisible icon

https://gerrit.wikimedia.org/r/268429

Change 268449 had a related patch set uploaded (by Esanders):
Default extensions to not use the 'invisible icon'

https://gerrit.wikimedia.org/r/268449

Change 268453 had a related patch set uploaded (by Jforrester):
Default extensions to not use the 'invisible icon'

https://gerrit.wikimedia.org/r/268453

Change 268449 merged by jenkins-bot:
Default extensions to not use the 'invisible icon'

https://gerrit.wikimedia.org/r/268449

Change 268453 merged by jenkins-bot:
Default extensions to not use the 'invisible icon'

https://gerrit.wikimedia.org/r/268453

Esanders closed this task as Resolved.Feb 5 2016, 7:36 PM
Esanders added a subscriber: Esanders.

This isn't resolved, just worked around, until https://gerrit.wikimedia.org/r/#/c/268437/ is merged, right?

Change 268437 merged by jenkins-bot:
FocusableNode: watch for image loaded/layout changes for invisible icons

https://gerrit.wikimedia.org/r/268437