Page MenuHomePhabricator
Create Task
Maniphest T125767

[Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
DLynch
Authored By
• ferdbold
Feb 4 2016, 5:48 AM
Tags
Referenced Files
F3308840: Capture d’écran 2016-02-04 à 00.46.16.png
Feb 4 2016, 5:48 AM
F3308845: Capture d’écran 2016-02-04 à 00.47.56.png
Feb 4 2016, 5:48 AM
Subscribers
Aklapper
DLynch
Esanders
• ferdbold
gerritbot
Jdforrester-WMF
StudiesWorld

Description

See for yourself:

Capture d’écran 2016-02-04 à 00.46.16.png (1×1 px, 516 KB)

The height CSS on ve-ce-focusableNode-invisible seems to be the culprit:

Capture d’écran 2016-02-04 à 00.47.56.png (1×1 px, 462 KB)

Note both screenshots have been taken from https://www.mediawiki.org/wiki/Extension:Graph/Demo

Details

SubjectRepoBranchLines +/-
FocusableNode: watch for image loaded/layout changes for invisible iconsVisualEditor/VisualEditormaster+53 -17
Default extensions to not use the 'invisible icon'mediawiki/extensions/VisualEditorwmf/1.27.0-wmf.12+0 -2
Default extensions to not use the 'invisible icon'mediawiki/extensions/VisualEditormaster+0 -2
VE: Never use invisible iconmediawiki/extensions/Graphmaster+2 -0
Customize query in gerrit

Event Timeline

• ferdbold created this task.Feb 4 2016, 5:48 AM
• ferdbold raised the priority of this task from to Needs Triage.
• ferdbold updated the task description. (Show Details)
• ferdbold subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 4 2016, 5:48 AM
• ferdbold renamed this task from FocusableNode invisibles produces weird results with graphs to FocusableNode invisibles produces weird results with graph, templates and transclusions.Feb 4 2016, 5:48 AM
• ferdbold added a project: VisualEditor.
• ferdbold set Security to None.
• ferdbold updated the task description. (Show Details)
gerritbot subscribed.Feb 4 2016, 6:13 PM

Change 268429 had a related patch set uploaded (by Esanders):
VE: Never use invisible icon

https://gerrit.wikimedia.org/r/268429

gerritbot added a project: Patch-For-Review.Feb 4 2016, 6:13 PM
DLynch subscribed.Feb 4 2016, 6:23 PM

Glancing at this happening to Math, briefly, it seems like the issue is that when this.hasRendering() is checked, the math elements don't technically have a width / height yet.

We could adjust this check to happen later in the rendering, after the browser has time to decide how it feels about things like images. Or we could perhaps whitelist some node-types as "yeah, this'll be visible, don't need to check"?

gerritbot added a comment.Feb 4 2016, 6:42 PM

Change 268437 had a related patch set uploaded (by DLynch):
Don't just rely on jQuery width / height for hasRendering

https://gerrit.wikimedia.org/r/268437

Ryasmeen renamed this task from FocusableNode invisibles produces weird results with graph, templates and transclusions to [Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions.Feb 4 2016, 7:07 PM
Jdforrester-WMF assigned this task to DLynch.Feb 4 2016, 7:11 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).
gerritbot added a comment.Feb 4 2016, 7:36 PM

Change 268429 merged by jenkins-bot:
VE: Never use invisible icon

https://gerrit.wikimedia.org/r/268429

gerritbot added a comment.Feb 4 2016, 7:38 PM

Change 268449 had a related patch set uploaded (by Esanders):
Default extensions to not use the 'invisible icon'

https://gerrit.wikimedia.org/r/268449

gerritbot added a comment.Feb 4 2016, 7:49 PM

Change 268453 had a related patch set uploaded (by Jforrester):
Default extensions to not use the 'invisible icon'

https://gerrit.wikimedia.org/r/268453

gerritbot added a comment.Feb 4 2016, 7:59 PM

Change 268449 merged by jenkins-bot:
Default extensions to not use the 'invisible icon'

https://gerrit.wikimedia.org/r/268449

gerritbot added a comment.Feb 5 2016, 6:23 PM

Change 268453 merged by jenkins-bot:
Default extensions to not use the 'invisible icon'

https://gerrit.wikimedia.org/r/268453

Esanders closed this task as Resolved.Feb 5 2016, 7:36 PM
Esanders subscribed.
Jdforrester-WMF subscribed.Feb 5 2016, 7:37 PM

This isn't resolved, just worked around, until https://gerrit.wikimedia.org/r/#/c/268437/ is merged, right?

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)).Feb 8 2016, 6:02 PM
gerritbot added a comment.Feb 11 2016, 1:04 AM

Change 268437 merged by jenkins-bot:
FocusableNode: watch for image loaded/layout changes for invisible icons

https://gerrit.wikimedia.org/r/268437

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits