Page MenuHomePhabricator
Create Task
Maniphest T125945

Wikitech login token form field should use mw-ui-input so it's obvious it is an input field
Closed, ResolvedPublic
Actions

Assigned To
Florian
Authored By
Jdlrobson
Feb 5 2016, 6:04 AM
Tags
Referenced Files
F3313568: result.PNG
Feb 5 2016, 5:12 PM
F3313496: IMG_3115.PNG
Feb 5 2016, 4:37 PM
F3312408: token.PNG
Feb 5 2016, 8:06 AM
Subscribers
Aklapper
Andrew
bd808
Florian
gerritbot
Glaisher
Jdlrobson
View All 13 Subscribers

Description

It's currently not obvious that the token is an input field. Let's get that fixed!

Details

SubjectRepoBranchLines +/-
Don't limit mw-ui-input border on Special:UserLoginmediawiki/extensions/MobileFrontendmaster+10 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Feb 5 2016, 6:04 AM
Jdlrobson renamed this task from Wikitech login token should use mw-ui-input to Wikitech login token form field should use mw-ui-input so it's obvious it is an input field.
Jdlrobson raised the priority of this task from to Low.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Cloud-Services, Mobile, wikitech.wikimedia.org, Wikimedia-Extension-setup.
Jdlrobson set Security to None.
Jdlrobson added subscribers: bd808, gerritbot, Krenair and 10 others.
Peachey88 edited projects, added MediaWiki-extensions-OATHAuth; removed Wikimedia-Extension-setup, Mobile.Feb 5 2016, 7:47 AM
Peachey88 subscribed.

how is Mobile relevant to this task?

How is T87633 as a blocker relevant to this task?

Florian added a comment.Feb 5 2016, 8:06 AM

Do I misunderstand something? The token field already has mw-ui-input:

token.PNG (438×1 px, 83 KB)

bd808 added a comment.Feb 5 2016, 4:37 PM

The styling looks right when I visit the mobile view of Wikitech from my desktop, but from my iPhone it's not styled correctly:

IMG_3115.PNG (1×640 px, 67 KB)

Florian claimed this task.Feb 5 2016, 5:00 PM

Oha, you're right. It's the login page "for small screens". Let me see if I can fix that :)

Florian added a project: MobileFrontend.Feb 5 2016, 5:00 PM
gerritbot added a comment.Feb 5 2016, 5:11 PM

Change 268696 had a related patch set uploaded (by Florianschmidtwelzow):
Don't limit mw-ui-input border on Special:UserLogin

https://gerrit.wikimedia.org/r/268696

gerritbot added a project: Patch-For-Review.Feb 5 2016, 5:11 PM
Florian added a comment.Feb 5 2016, 5:12 PM

Result of the above change:

result.PNG (642×362 px, 27 KB)

Luke081515 moved this task from Triage to In Progress on the Cloud-Services board.Feb 5 2016, 5:24 PM
gerritbot added a comment.Feb 5 2016, 7:13 PM

Change 268696 merged by jenkins-bot:
Don't limit mw-ui-input border on Special:UserLogin

https://gerrit.wikimedia.org/r/268696

Florian closed this task as Resolved.Feb 5 2016, 7:34 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)).Feb 8 2016, 8:02 PM
Dzahn unsubscribed.Feb 8 2016, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL