Page MenuHomePhabricator

Wikitech login token form field should use mw-ui-input so it's obvious it is an input field
Closed, ResolvedPublic

Description

It's currently not obvious that the token is an input field. Let's get that fixed!

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterDon't limit mw-ui-input border on Special:UserLogin

Event Timeline

Jdlrobson created this task.Feb 5 2016, 6:04 AM
Jdlrobson renamed this task from Wikitech login token should use mw-ui-input to Wikitech login token form field should use mw-ui-input so it's obvious it is an input field.
Jdlrobson raised the priority of this task from to Low.
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson added subscribers: bd808, gerritbot, Krenair and 10 others.
Peachey88 added a subscriber: Peachey88.

how is Mobile relevant to this task?

How is T87633 as a blocker relevant to this task?

Do I misunderstand something? The token field already has mw-ui-input:

The styling looks right when I visit the mobile view of Wikitech from my desktop, but from my iPhone it's not styled correctly:

Florian claimed this task.Feb 5 2016, 5:00 PM

Oha, you're right. It's the login page "for small screens". Let me see if I can fix that :)

Change 268696 had a related patch set uploaded (by Florianschmidtwelzow):
Don't limit mw-ui-input border on Special:UserLogin

https://gerrit.wikimedia.org/r/268696

Result of the above change:

Luke081515 moved this task from Triage to In Progress on the Cloud-Services board.Feb 5 2016, 5:24 PM

Change 268696 merged by jenkins-bot:
Don't limit mw-ui-input border on Special:UserLogin

https://gerrit.wikimedia.org/r/268696

Florian closed this task as Resolved.Feb 5 2016, 7:34 PM
Dzahn removed a subscriber: Dzahn.Feb 8 2016, 9:00 PM