Page MenuHomePhabricator

TemplateData display table should not be sortable when there's zero or one parameter
Open, LowestPublic1 Story Points


When <templatedata> element is shown on template documentation page, the table for params is always sortable.

That looks ridiculous if only one parameter is present.


rETDA /TemplateDataBlob.php #L696

Add sortable class if and only if count( (array)$data->params ) > 1

Event Timeline

PerfektesChaos raised the priority of this task from to Needs Triage.
PerfektesChaos updated the task description. (Show Details)
PerfektesChaos added a project: TemplateData.
PerfektesChaos added a subscriber: PerfektesChaos.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 7 2016, 8:02 AM
Krenair added a subscriber: Krenair.Feb 7 2016, 1:44 PM

I really don't think it's that bad

I really don't think it's that bad

But I do, and I received complaints.

Even worse:

If a template does not expect any parameters, but provides a description of the purpose, you end up in a meaningless table which has sortable head cells but only one spread out line which tells you that no parameters were supplied.

However, params must not be omitted since that produces an invalid JSON block.

Please convince me:

  • How and why should I sort one or zero parameters?
  • How is the definition of templates expected with no parameters but telling me its purpose?
Elitre added a subscriber: Elitre.Feb 10 2016, 4:17 PM
Jdforrester-WMF renamed this task from Table should not be sortable for one parameter only to TemplateData display table should not be sortable when there's zero or one parameter.Mar 1 2016, 7:37 PM
Jdforrester-WMF triaged this task as Lowest priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.