Template (puzzle) icon displaces images/templates
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

For a simple template which simply embeds and image I encountered the following strange behaviour.

When entering VE the puzzle icon is placed where the image is normally situated pushing that image downwards. Since the template is used in lists and since displacing the image does not increase the line hight the results are a bit weird as can be seen in the example below.

Possible solutions:

Make the puzzle-icon not appear (it doesn't appear for all templates but I could find no documentation on what triggers it's appearance).
Force line hight to be increased by the height of the puzzle-icon (while the end result will still look weird you won't have images overlapping each other.

Details

	Subject	Repo	Branch	Lines +/-
	Make surface measurable while activating	mediawiki/extensions/VisualEditor	master	+8 -1

Customize query in gerrit

Related Objects

Mentioned In: T128391: Visible template (flagicon) is showing puzzle piece icon

Event Timeline

Lokal_Profil created this task.Feb 18 2016, 3:31 PM

Restricted Application added subscribers: StudiesWorld, Josve05a, Aklapper. · View Herald TranscriptFeb 18 2016, 3:31 PM

Possibly the problem is related to VE thinking that an image is a hidden template. If I modify the template by having it also add some random text the issue (i.e. puzzle icon) disappears.

Lokal_Profil updated the task description. (Show Details)Feb 18 2016, 3:53 PM

Lokal_Profil updated the task description. (Show Details)

This will have been fixed by https://gerrit.wikimedia.org/r/#/c/268437/

Jdforrester-WMF assigned this task to DLynch.Feb 23 2016, 4:49 PM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF added projects: MW-1.27-release (WMF-deploy-2016-02-16_(1.27.0-wmf.14)), VisualEditor-ContentEditable.

Jdforrester-WMF set the point value for this task to 8.

Still occurring on beta labs for flag icons, so clearly not: http://en.wikipedia.beta.wmflabs.org/wiki/English_language?action=edit

Part of the problem will be hasRendering, which iterates using this.$element.each which only checks first level descendants of this.$element. If the image is wrapped in a few spans it won't get detected.

The other issue is one that's come up a few times, which is that in MW, the first setup of nodes happens which the surface is hidden, and therefore not measurable. We may want to consider hiding it in a way that preserves layout (e.g. wrapped in a height:0; overflow:hidden;).

Change 272763 had a related patch set uploaded (by Esanders):
Make surface measurable while activating

https://gerrit.wikimedia.org/r/272763

gerritbot added a project: Patch-For-Review.Feb 23 2016, 5:05 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Feb 23 2016, 8:10 PM

Change 272763 merged by jenkins-bot:
Make surface measurable while activating

https://gerrit.wikimedia.org/r/272763

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 24 2016, 2:00 AM

Jdforrester-WMF mentioned this in T128391: Visible template (flagicon) is showing puzzle piece icon.Feb 29 2016, 10:54 PM

Jdforrester-WMF closed this task as Resolved.Mar 22 2016, 7:13 PM

Jdforrester-WMF merged a task: T128391: Visible template (flagicon) is showing puzzle piece icon.

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF added subscribers: Jdforrester-WMF, • Whatamidoing-WMF.