The following is what happens when I have a thank notification from User:Jdforrester (WMF) on commonswiki (an English-speaking wiki) and view it on hewiki:
Note the broken parentheses because of mixed directionality.
Catrope | |
Feb 19 2016, 1:05 AM |
F3764064: Screen Shot 2016-03-28 at 11.15.13 AM.png | |
Mar 28 2016, 6:18 PM |
F3764061: Screen Shot 2016-03-28 at 11.05.53 AM.png | |
Mar 28 2016, 6:18 PM |
F3764068: Screen Shot 2016-03-28 at 11.15.01 AM.png | |
Mar 28 2016, 6:18 PM |
F3716483: Screen Shot 2016-03-25 at 1.47.19 PM.png | |
Mar 25 2016, 11:48 PM |
F3716480: Screen Shot 2016-03-25 at 1.32.56 PM.png | |
Mar 25 2016, 11:48 PM |
F3372682: notif-username-rtl.png | |
Feb 19 2016, 1:05 AM |
The following is what happens when I have a thank notification from User:Jdforrester (WMF) on commonswiki (an English-speaking wiki) and view it on hewiki:
Note the broken parentheses because of mixed directionality.
Change 272934 had a related patch set uploaded (by Catrope):
Bidi-isolate secondary link labels and notification bodies
Change 272935 had a related patch set uploaded (by Catrope):
Wrap $1 (user name) in {{bidi:}} in notification-header-* messages.
https://gerrit.wikimedia.org/r/272934 takes care of bidi-isolation in the interface. We still have to do bidi-isolation of user names where they appear in notification text though, using {{bidi:$1}} in the i18n message. This can easily be automated and done for all languages. I submitted https://gerrit.wikimedia.org/r/272935 as an example against the Thanks extension, and I'll wait for feedback from the localization people before I build more patches like that against other extensions.
To test 272934:
To test 272935:
Change 272935 abandoned by Catrope:
Wrap $1 (user name) in {{bidi:}} in notification-header-* messages.
Reason:
Abandoning this because doing this in code means I have to do it in a different repo (Echo). Thanks for the suggestion!
Change 273113 had a related patch set uploaded (by Catrope):
Bidi-embed formatter user names (the $1 parameter) in notification messages
These same things are now fixed by 273113 instead.
I still need to write a patch to bidi-isolate section names, and look at what else might need it.
Change 273113 merged by jenkins-bot:
Bidi-embed formatter user names (the $1 parameter) in notification messages
Change 273968 had a related patch set uploaded (by Catrope):
Bidi-embed user names and page names in secondary links
Change 273968 merged by jenkins-bot:
Bidi-embed user names and page names in secondary links
Change 276388 had a related patch set uploaded (by Mooeypoo):
Bidi isolate content items in notification header text
Change 276388 merged by jenkins-bot:
Bidi isolate content items in notification header text
Change 276693 had a related patch set uploaded (by Catrope):
Bidi-embed topic titles in notifications
Change 276694 had a related patch set uploaded (by Catrope):
Bidi-embed course names in notifications
Change 276695 had a related patch set uploaded (by Catrope):
Bidi-embed instance names in notifications
I went through notifications in extensions (other than Echo) and added bidi-embedding where needed. In most cases it wasn't needed because generic functions from EchoEventPresentationModel were being used.
ET((V
ET(III)
ET\99\
Note: additional testing needs to be done for cross-wiki notifications (temporarily not displayed in betalabs)
Adding screenshots for cross-wiki notifications- username Bob (QRT) is displayed correctly in RTL context :