Page MenuHomePhabricator
Create Task
Maniphest T127956

Introduce WatchedItemStore
Closed, ResolvedPublic13 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Move WatchedItem logic to WatchedItemStoremediawiki/coremaster+2 K -465
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.Feb 24 2016, 1:43 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 24 2016, 1:43 PM
Tobi_WMDE_SW added a parent task: T100508: Watchlist expiry: Watch pages for a specified time frame (2013).Feb 24 2016, 1:44 PM
Tobi_WMDE_SW triaged this task as High priority.Feb 24 2016, 2:15 PM
Addshore updated the task description. (Show Details)Feb 24 2016, 3:04 PM
Addshore added a project: Patch-For-Review.Feb 24 2016, 3:07 PM

Patches currently in review:

https://gerrit.wikimedia.org/r/#/c/266524/
https://gerrit.wikimedia.org/r/#/c/267259/
https://gerrit.wikimedia.org/r/#/c/266572/
https://gerrit.wikimedia.org/r/#/c/268650/
https://gerrit.wikimedia.org/r/#/c/268652/

gerritbot subscribed.Feb 29 2016, 10:47 AM

Change 267259 had a related patch set uploaded (by Addshore):
Move WatchedItem logic to WatchedItemStore

https://gerrit.wikimedia.org/r/267259

Tobi_WMDE_SW moved this task from Proposed to Review on the TCB-Team-Sprint-2016-03-02 board.Mar 2 2016, 12:37 PM
Tobi_WMDE_SW moved this task from Review to Proposed on the TCB-Team-Sprint-2016-03-02 board.
Tobi_WMDE_SW moved this task from Proposed to Doing on the TCB-Team-Sprint-2016-03-02 board.Mar 2 2016, 1:33 PM
Tobi_WMDE_SW set the point value for this task to 13.Mar 2 2016, 1:37 PM
gerritbot added a comment.Mar 8 2016, 6:04 PM

Change 267259 merged by jenkins-bot:
Move WatchedItem logic to WatchedItemStore

https://gerrit.wikimedia.org/r/267259

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).Mar 8 2016, 7:00 PM
Addshore updated the task description. (Show Details)Mar 9 2016, 9:28 AM
gerritbot added a comment.Mar 9 2016, 9:28 AM

Change 266572 had a related patch set uploaded (by Addshore):
Move counting of watchers to WatchedItemStore

https://gerrit.wikimedia.org/r/266572

Addshore updated the task description. (Show Details)Mar 9 2016, 9:32 AM
gerritbot added a comment.Mar 9 2016, 9:45 AM

Change 268650 had a related patch set uploaded (by Addshore):
Move countVisitingWatchers to WatchedItemStore

https://gerrit.wikimedia.org/r/268650

Addshore added a comment.Mar 10 2016, 11:34 AM

Once the following 2 patches are merged InfoAction will be done:

This will also probably be the most untangled ApiQueryInfo can be at this stage..

gerritbot added a comment.Mar 10 2016, 12:05 PM

Change 276441 had a related patch set uploaded (by Addshore):
Add countUnreadNotifications to WatchedItemStore

https://gerrit.wikimedia.org/r/276441

Addshore added a comment.Mar 10 2016, 12:10 PM

Again, looking at:

  • ApiQueryWatchlist
  • ApiQueryWatchlistRaw

These look far to tangled to try and factor the watchlist table logic out, so they will probably not be tackled.

Tobi_WMDE_SW added a comment.Mar 10 2016, 3:00 PM

Refactoring other parts of the code to make use of WatchedItemStore is not tracked in T129478.

Tobi_WMDE_SW updated the task description. (Show Details)Mar 10 2016, 3:01 PM
Tobi_WMDE_SW moved this task from Doing to Done on the TCB-Team-Sprint-2016-03-02 board.
Addshore added a comment.Mar 10 2016, 3:07 PM
In T127956#2107032, @Tobi_WMDE_SW wrote:

Refactoring other parts of the code to make use of WatchedItemStore is not tracked in T129478.

*now

Addshore closed this task as Resolved.Mar 10 2016, 3:08 PM

Marking as resolved as this has indeed been introduced!

Tobi_WMDE_SW added a parent task: T129478: Refactor watchlist related code to use WatchedItemStore.Mar 10 2016, 3:11 PM
Ricordisamoa subscribed.Mar 10 2016, 3:39 PM

Open Gerrit changes associated with this task:

Tobi_WMDE_SW added a comment.Mar 10 2016, 3:45 PM

thx @Ricordisamoa, we'll update commit messages

Addshore added a comment.Mar 10 2016, 3:53 PM
In T127956#2107211, @Tobi_WMDE_SW wrote:

thx @Ricordisamoa, we'll update commit messages

Yup, Will do!

Tobi_WMDE_SW moved this task from Incoming to Done on the TCB-Team (now WMDE-TechWish) board.Mar 17 2016, 2:01 PM
Tobi_WMDE_SW moved this task from Incoming to Done on the German-Community-Wishlist board.May 9 2016, 10:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits