Page MenuHomePhabricator

Plain paste (Ctrl+Shift+V) of external content into a non-paragraph node breaks, shows ☂ and/or ☀
Closed, ResolvedPublic1 Estimated Story Points

Description

  1. Open a page in VE
  2. Create a new heading or preformatted with the text "Foo"
  3. Type the text "Bar" into the search bar, select it, and copy it (Ctrl+C)
  4. Place the cursor at the (beginning|middle|end) of Foo
  5. Press Ctrl+Shift+V
  6. See breakage and funny Unicode characters

The result depends on step 3: pasting at the beginning will create a new paragraph with "Bar☂" before it; pasting at the end will create a new paragraph with "☀Bar" after it; and pasting in the middle will split the heading/preformatted and create a paragraph with "☀bar☂" in between the two. However, if you use a paragraph in step 2, then you will get the correct result ("BarFoo, "FooBar" or "FoBaro").

Event Timeline

Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 277232 had a related patch set uploaded (by Esanders):
Sanitize the paste context in the same way as the paste data

https://gerrit.wikimedia.org/r/277232

Change 277232 merged by jenkins-bot:
Sanitize the paste context in the same way as the paste data

https://gerrit.wikimedia.org/r/277232

jrbs subscribed.

This just happened again to me. I pasted text into a table in VisualEditor and it output an umbrella icon when creating a new line.

SS 2017-01-10 at 12.03.26 pm.png (183×206 px, 8 KB)

For example (see screenshot) - the first "Browne" in each line pastes fine, but the second results in the icon when wrapping to a new line.

This might not be the same bug - where did you copy the text from?

This might not be the same bug - where did you copy the text from?

I believe it was from Google Sheets. Though I'm trying to replicate this now and it's no longer giving me this error. I'm not sure what's changed this now.

jrbs lowered the priority of this task from High to Low.Jan 29 2017, 9:43 PM

Since I'm struggling to replicate (and foolishly didn't provide more accurate instructions in my comment), I'm lowering priority ahead of another closure.

Deskana subscribed.

I can't reproduce this any more, so it seems it was fixed.