Page MenuHomePhabricator

"Unresponsive script" warning after copying and pasting content several times in tables
Closed, ResolvedPublic8 Estimated Story Points

Description

Copying from one cell and pasting to another, performed several times, gets slower and slower until it eventually leads to the "Unresponsive script" warning.
You can test in my sandbox if you want.
I'm getting this in both FF and Chrome.

Event Timeline

Hmm, I think maybe the internalList isn't merging properly and is therefore doubling in size each time.

That is the problem. I think it is because newFromDocumentInsertion doesn't consolidate duplicate internal items. This is why we don't copy over the internal list to surface widgets, hence existing references are not available in image captions. Paging @Catrope.

Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 8.

Change 277318 had a related patch set uploaded (by Esanders):
Table import: Only import the internal list on external paste

https://gerrit.wikimedia.org/r/277318

Change 277318 merged by jenkins-bot:
Table import: Only import the internal list on external paste

https://gerrit.wikimedia.org/r/277318