Page MenuHomePhabricator

Use standard URL index.php?title= ... for background requests
Open, MediumPublic

Description

When the MediaWiki code generates an URL to something other than the default view of a wiki page, especially if the URL is then requested in the background, the URL should be in standard fullurl format, for instance /w/index.php?title=Special:BackofficeStuff&foo=bar instead of /wiki/Special:BackofficeStuff?foo=bar .

This sometimes doesn't happen, see T116609: View counts in squid logs, webstatscollector 2.0 and hive are very dissimilar for several projects. [5 pts]. We'd need to make a list of files where URLs are generated manually or hardcoded in a non-standard way.

Event Timeline

Change 250384 had a related patch set uploaded (by Nemo bis):
Use full URL in $wgNoticeHideUrls

https://gerrit.wikimedia.org/r/250384

@awight or @Nuria: As @Nemo_bis doesn't wish to overview patch deployments during SWAT, could you schedule it on a SWAT window at https://wikitech.wikimedia.org/wiki/Deployments?

Sure thing, thanks for the note! I've scheduled the deployment for tomorrow at 23:00 UTC.

Also, I appreciate @Nemo_bis letting us take our time and not rushing through the deployment last November--the hide mechanism is fragile and very important to our fundraising campaigns. Failure to hide banners during the December "Big English" drive would have caused a huge donor relations fiasco...

Change 250384 merged by jenkins-bot:
Use full URL in $wgNoticeHideUrls

https://gerrit.wikimedia.org/r/250384

Mentioned in SAL [2016-06-01T23:21:11Z] <dereckson@tin> Synchronized wmf-config/CommonSettings.php: Use full URL in $wgNoticeHideUrls (T130442) (duration: 00m 23s)

Nemo_bis triaged this task as Medium priority.Jun 2 2016, 2:20 PM
Nemo_bis removed a project: Patch-For-Review.