Additional error handling needed in OATHAuthHooks::schemaUpdateOldUsers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• dpatrick
	Mar 23 2016, 5:21 PM

Description

In the event that database format upgrade fails because row data cannot be unserialized, the script errors fatally. Additional error handling is needed, or perhaps detection of row format to determine if the row data has already been upgraded.

Details

	Subject	Repo	Branch	Lines +/-
	Suppress unserialize errors	mediawiki/extensions/OATHAuth	master	+2 -0

Customize query in gerrit

Event Timeline

• dpatrick created this task.Mar 23 2016, 5:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2016, 5:21 PM

			MediaWiki\suppressWarnings();
			$scratchTokens = unserialize( base64_decode( $row->scratch_tokens ) );
			MediaWiki\restoreWarnings();

would be enough to stop the noise, but isn't really checking for whether things are already migrated

Change 311201 had a related patch set uploaded (by Reedy):
Suppress unserialize errors

https://gerrit.wikimedia.org/r/311201

gerritbot added a project: Patch-For-Review.Sep 16 2016, 11:06 PM

Change 311201 merged by jenkins-bot:
Suppress unserialize errors

https://gerrit.wikimedia.org/r/311201

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 30 2016, 9:00 PM

Reedy removed projects: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review.Oct 31 2016, 2:42 PM

Reedy triaged this task as Low priority.Oct 31 2016, 2:45 PM

@Reedy, is more work still required here ?

In T130740#3277030, @TheDJ wrote:

@Reedy, is more work still required here ?

Maybe, but it's probably not worth the time. My previous change stopped it fatal-ing in most cases

Reedy closed this task as Resolved.May 19 2017, 4:56 PM

sbassett moved this task from Incoming to Our Part Is Done on the Security-Team board.Jun 11 2019, 7:07 PM

Additional error handling needed in OATHAuthHooks::schemaUpdateOldUsersClosed, ResolvedPublicActions

Description

Details

Event Timeline

Additional error handling needed in OATHAuthHooks::schemaUpdateOldUsers
Closed, ResolvedPublic
Actions