Page MenuHomePhabricator
Create Task
Maniphest T130810

VisualEditor gave me the "The page has been restored" post-edit notification after a perfectly regular edit
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I just edited https://en.wikipedia.org/wiki/List_of_Oval_Office_desks and after saving my changes, I was shown the "The page has been restored." post-edit notification. (Not visible in the screenshot, because it disappeared, bu you can still see the "venotify=restored" in the URL.)

pasted_file (946×1 px, 550 KB)

The edit was done after switching from wikitext editor, editing a single section (VE originally loaded with this URL: https://en.wikipedia.org/w/index.php?title=List_of_Oval_Office_desks&section=2&veaction=edit&oldid=706030293&wteswitched=1).

This has happened in the past a few times.

Details

SubjectRepoBranchLines +/-
ArticleTarget: Don't assume an explicit oldid is old; check against currentmediawiki/extensions/VisualEditormaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Mar 24 2016, 6:20 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 24 2016, 6:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Mar 25 2016, 4:32 AM

Change 279576 had a related patch set uploaded (by Alex Monk):
Don't assume an explicit oldid is old - check it against the current ID

https://gerrit.wikimedia.org/r/279576

gerritbot added a project: Patch-For-Review.Mar 25 2016, 4:32 AM
• AlexMonk-WMF claimed this task.Mar 25 2016, 4:32 AM
Jdforrester-WMF renamed this task from VisualEditor gave me the "The page has been restored." post-edit notification after a perfectly regular edit to VisualEditor gave me the "The page has been restored" post-edit notification after a perfectly regular edit.Mar 26 2016, 12:41 AM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)); removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Mar 26 2016, 12:49 AM

Change 279576 merged by jenkins-bot:
ArticleTarget: Don't assume an explicit oldid is old; check against current

https://gerrit.wikimedia.org/r/279576

• AlexMonk-WMF mentioned this in T117662: Say "Your edit has been saved" instead of "The page has been restored" when editing an oldid that happens to also be the current.Apr 7 2016, 10:20 PM
Jdforrester-WMF closed this task as a duplicate of T117662: Say "Your edit has been saved" instead of "The page has been restored" when editing an oldid that happens to also be the current.Apr 26 2016, 6:15 PM
Jdforrester-WMF changed the task status from Duplicate to Resolved.Apr 26 2016, 6:37 PM
Jdforrester-WMF merged a task: T117662: Say "Your edit has been saved" instead of "The page has been restored" when editing an oldid that happens to also be the current.
Jdforrester-WMF added subscribers: ori, Devirk, • AlexMonk-WMF and 5 others.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits