Say "Your edit has been saved" instead of "The page has been restored" when editing an oldid that happens to also be the current
Closed, DuplicatePublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Nnemo
	Nov 4 2015, 9:13 AM

Description

I am on an article on fr.wikipedia.org
I go to the history of the article.
I click on the link, with the date and time, for the current version.
I get the current version of the article.
I click modifier
I get the Web visual editor of Wikipedia.
I do a change.
I save my edit. Or, variant: I switch to the wikicode editor with keeping my changes, I do a change and I save my edit.

My edit gets saved.

I get the brief message: "La page a été restaurée" ("The page has been restored").

This is incorrect and disturbing. I did not restore anything. I edited the last version of the page.

It would be better to show the usual message instead: "Votre modification a été enregistrée" ("Your edit has been saved"). This message would be correct.

Thank you for correcting this bug.

Nnemo

Details

	Subject	Repo	Branch	Lines +/-
	Reworded the message when editing the current version of an article	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Invalid	None	T40638 [DO NOT USE] Interface messages needing rewording or documentation and other issues with existing messages [superseded by #Voice_&_Tone]
Duplicate	• AlexMonk-WMF	T117662 Say "Your edit has been saved" instead of "The page has been restored" when editing an oldid that happens to also be the current
		· · ·

Event Timeline

Nnemo created this task.Nov 4 2015, 9:13 AM

Nnemo raised the priority of this task from to Needs Triage.

Nnemo updated the task description. (Show Details)

Nnemo added projects: MediaWiki-Page-diffs, MediaWiki-Page-editing, VisualEditor.

Nnemo subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 4 2015, 9:13 AM

Nnemo awarded a token.Nov 4 2015, 9:13 AM

Aklapper added a parent task: T40638: [DO NOT USE] Interface messages needing rewording or documentation and other issues with existing messages [superseded by #Voice_&_Tone].Nov 4 2015, 9:41 AM

Liuxinyu970226 set Security to None.Nov 4 2015, 9:44 AM

The introduction of a different text was explicitly requested, because if you're undoing someone's edit it's not "your edit" that was saved. Can you argue with them and agree?

Aklapper changed the task status from Open to Stalled.Nov 5 2015, 10:54 AM

Aklapper triaged this task as Lowest priority.

In T117662#1781741, @Jdforrester-WMF wrote:

The introduction of a different text was explicitly requested, because if you're undoing someone's edit it's not "your edit" that was saved.

But I am not undoing someone's edit. I am editing the current version of the article.

In T117662#1793078, @Nnemo wrote:

In T117662#1781741, @Jdforrester-WMF wrote:

The introduction of a different text was explicitly requested, because if you're undoing someone's edit it's not "your edit" that was saved.

But I am not undoing someone's edit. I am editing the current version of the article.

Ah, I see. OK.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 12 2015, 3:59 PM

darthbhyrava subscribed.Dec 5 2015, 6:56 AM

Nemo_bis added projects: I18n, good first task.Dec 8 2015, 7:57 PM

I'll fix this. :)

Devirk claimed this task.Jan 5 2016, 1:34 PM

Change 262701 had a related patch set uploaded (by Devirk):
Reworded the message when editing the current version of an article

https://gerrit.wikimedia.org/r/262701

gerritbot added a project: Patch-For-Review.Jan 27 2016, 1:54 PM

darthbhyrava unsubscribed.Mar 4 2016, 5:52 PM

This just happened to me on mediawikiwiki when editing Wikimedia Engineering/2015-16 Q4 Goals. I agree that it is incorrect and disturbing.

As @Jdforrester-WMF said on Gerrit, Devirk's patch does not fix the bug. The bug is that VisualEditor misclassifies an edit to the most recent revision of an article. The code that makes that determination was last touched by @Esanders in rEVED9a347220bcc9: Target loading: Only parse oldid if it is non-null, AFAICT.

Was T130810 (which we recently fixed) a dupe of this?

Yes, it looks like it. I encountered this bug five hours ago on mediawikiwiki, so it must not be fully fixed. Note that the change by Ed which I mentioned above touched the same code after the fix was applied.

Side note: using '!!' in compound conditional expressions is really confusing.