Page MenuHomePhabricator

Special:ApiSandbox URL field must have ltr direction
Open, MediumPublic


Special:ApiSandbox URL field must have ltr direction. The URL is left-to-right by nature.

I just found this on the morning of Hackathon 2016, and it's a great bug for beginners!

Event Timeline

Amire80 created this task.Apr 1 2016, 7:25 AM
Restricted Application added a project: I18n. · View Herald TranscriptApr 1 2016, 7:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 updated the task description. (Show Details)
Esanders added a subscriber: Esanders.EditedApr 1 2016, 7:47 AM

It seems like there would be other parameters that should probably be LTR as well, such as callback?

Yeah, quite possibly.

And you probably meant LTR :)

I did! Already fixed :)

Anomie added a subscriber: Anomie.Apr 1 2016, 8:20 AM

There's a decent chance that you'll have to add either a new value for ApiBase::PARAM_TYPE or a new constant to indicate LTR directionality; which one depends on which fields, exactly, this might apply to (e.g. URL fields would make sense as a new "url" type, while something like the callback parameter probably wouldn't make sense as a new type unless it's extremely generic like "ltrstring").

Then you'd need to update the return values from getAllowedParams() for all the applicable API modules, and the ApiSandbox JS to apply the correct directionality to the widgets.

Anomie moved this task from Unsorted to Needs Code on the MediaWiki-API board.Apr 1 2016, 8:53 AM
Florian triaged this task as Medium priority.Apr 1 2016, 9:14 PM
Florian moved this task from To triage to SpecialPage system on the MediaWiki-Special-pages board.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 15 2016, 10:33 PM
Amire80 moved this task from Untriaged to RTL on the I18n board.Feb 27 2018, 7:13 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM