Page MenuHomePhabricator

Special:ApiSandbox URL field must have ltr direction
Open, MediumPublic

Description

Special:ApiSandbox URL field must have ltr direction. The URL is left-to-right by nature.

I just found this on the morning of Hackathon 2016, and it's a great bug for beginners!

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It seems like there would be other parameters that should probably be LTR as well, such as callback?

Yeah, quite possibly.

And you probably meant LTR :)

There's a decent chance that you'll have to add either a new value for ApiBase::PARAM_TYPE or a new constant to indicate LTR directionality; which one depends on which fields, exactly, this might apply to (e.g. URL fields would make sense as a new "url" type, while something like the callback parameter probably wouldn't make sense as a new type unless it's extremely generic like "ltrstring").

Then you'd need to update the return values from getAllowedParams() for all the applicable API modules, and the ApiSandbox JS to apply the correct directionality to the widgets.

Florian triaged this task as Medium priority.Apr 1 2016, 9:14 PM
Florian moved this task from To triage to SpecialPage system on the MediaWiki-Special-pages board.