Page MenuHomePhabricator
Create Task
Maniphest T132647

Prettify URLs in API/FormatHTML only works on Wikipedia links
Closed, ResolvedPublic
Actions

Description

The method prettifyUrls in api/FormatHtml.php tries to match the following RegEx:

'/(https?:)?\/\/((\w+)\.wikipedia\.org\/w\/index\.php\?title=(.*)&oldid=(.*))/

But since T131344 we now support other sites than Wikipedia. For ru: we are getting from Wikivoyage, resulting in links like //ru.wikipedia.org/w/index.php?title=Title&oldid=162698 which do not match

Details

SubjectRepoBranchLines +/-
Support non-Wikipedia projects in pretty urlslabs/tools/heritagemaster+21 -3
[NOT FULLY TESTED] Better support for sister projectslabs/tools/heritagemaster+175 -28
Customize query in gerrit

Related Objects

Event Timeline

JeanFred created this task.Apr 13 2016, 11:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2016, 11:52 PM
JeanFred added a comment.Apr 13 2016, 11:52 PM

@Lokal_Profil, shall we keep this as an Easy task?

JeanFred mentioned this in T131739: Remove hard coded http in api.Apr 13 2016, 11:55 PM
JeanFred moved this task from Incoming to API on the Wiki-Loves-Monuments board.
Lokal_Profil added a comment.Apr 19 2016, 2:46 PM
In T132647#2205541, @JeanFred wrote:

@Lokal_Profil, shall we keep this as an Easy task?

Yes this should be fairly easy (at least if you know regexp)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 2:46 PM
Lokal_Profil mentioned this in T132029: Html output of api should de-urlencode link titles and pagenames for display.Apr 20 2016, 1:43 PM
gerritbot subscribed.Apr 29 2016, 1:53 PM

Change 286156 had a related patch set uploaded (by Lokal Profil):
[NOT TESTED] Better support for sister projects

https://gerrit.wikimedia.org/r/286156

gerritbot added a project: Patch-For-Review.Apr 29 2016, 1:53 PM
Lokal_Profil added a comment.May 4 2016, 7:59 AM

Change 286156 only deals with part of this issue. To test THAT change

  • Go to this link and ensure that the title is now a link to ru.wiktionary.
  • Then go to this link and ensure <link> no longer mentions wikipedia.
gerritbot added a comment.May 4 2016, 8:03 AM

Change 286156 merged by jenkins-bot:
[NOT FULLY TESTED] Better support for sister projects

https://gerrit.wikimedia.org/r/286156

gerritbot added a comment.May 4 2016, 9:02 AM

Change 286798 had a related patch set uploaded (by Lokal Profil):
Support non-Wikipedia projects in pretty urls

https://gerrit.wikimedia.org/r/286798

Lokal_Profil added a comment.May 4 2016, 9:22 AM

To test 286798 this link should have a nicely formated link (similar to this one).

gerritbot added a comment.May 4 2016, 11:07 AM

Change 286798 merged by jenkins-bot:
Support non-Wikipedia projects in pretty urls

https://gerrit.wikimedia.org/r/286798

Lokal_Profil moved this task from API to Awaiting deployment on the Wiki-Loves-Monuments board.May 6 2016, 12:05 PM
Stashbot mentioned this in T134236: Drop use of preg_replace(): with the /e modifier.May 6 2016, 12:16 PM
Stashbot subscribed.

Mentioned in SAL [2016-05-06T12:15:49Z] <JeanFred> Deployed latest from Git: db46042, c765e76, b5a731a, 7c27207, d4de720 (T134236), e7823ab & c83003b (T132647), 615ab28

JeanFred closed this task as Resolved.May 6 2016, 12:17 PM
JeanFred claimed this task.

This link is now working :)
https://tools.wmflabs.org/heritage/api/api.php?action=search&format=html&limit=10&srcountry=ru&srlang=ru&srid=000001&props=source

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL