⚓ T132765 [Feeds] Implement Content Service endpoint for "featured picture of the day"

Subject	Repo	Branch	Lines +/-
Picture of the Day card, pt. 1	apps/android/wikipedia	master	+511 -193
Update Picture of the Day endpoint	mediawiki/services/mobileapps	master	+131 -58
Picture of the day	mediawiki/services/mobileapps	master	+306 -3

Status	Assigned	Task
Resolved	Dbrant	T129076 Implement Feeds in the Android app.
Resolved	• Mholloway	T132814 Tapping the "picture of the day" card should launch Gallery, loaded with previous pictures-of-the-day.
Resolved	• Mholloway	T130962 [Feeds] Implement "picture of the day" card.
Resolved	• bearND	T132340 [EPIC] [Feeds] Implement Content Service endpoint for retrieving specific feed content.
Resolved	• bearND	T132765 [Feeds] Implement Content Service endpoint for "featured picture of the day"

Dbrant created this task.Apr 15 2016, 1:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2016, 1:24 PM

Dbrant added a parent task: T130962: [Feeds] Implement "picture of the day" card..Apr 15 2016, 1:30 PM

• bearND moved this task from Incoming to Backlog on the Mobile-Content-Service board.Apr 15 2016, 3:50 PM

• bearND added a parent task: T132340: [EPIC] [Feeds] Implement Content Service endpoint for retrieving specific feed content..Apr 15 2016, 6:11 PM

MBinder_WMF moved this task from Backlog to Large on the Android-app-feature-Feeds board.Apr 15 2016, 6:48 PM

Dbrant updated the task description. (Show Details)Apr 15 2016, 7:08 PM

Dbrant updated the task description. (Show Details)Apr 15 2016, 7:33 PM

Dbrant updated the task description. (Show Details)Apr 15 2016, 7:36 PM

Dbrant updated the task description. (Show Details)Apr 16 2016, 1:54 AM

MBinder_WMF set the point value for this task to 3.May 13 2016, 6:15 PM

Dbrant added a project: Wikipedia-Android-App-Backlog.May 13 2016, 6:35 PM

Dbrant moved this task from Needs Triage to Product Backlog on the Wikipedia-Android-App-Backlog board.May 13 2016, 6:38 PM

• MZMcBride subscribed.May 14 2016, 2:33 AM

Dbrant added a project: Mobile-App-Android-Sprint-86-Radon.Jun 20 2016, 6:35 PM

• bearND claimed this task.Jun 22 2016, 10:17 PM

• bearND edited projects, added Mobile-App-Android-Sprint-85-Astatine, Unplanned-Sprint-Work; removed Mobile-App-Android-Sprint-86-Radon.

• bearND moved this task from To Do to Doing on the Mobile-App-Android-Sprint-85-Astatine board.

Change 296266 had a related patch set uploaded (by BearND):
Picture of the day

https://gerrit.wikimedia.org/r/296266

gerritbot added a project: Patch-For-Review.Jun 27 2016, 8:02 PM

• bearND moved this task from Doing to Code Review on the Mobile-App-Android-Sprint-85-Astatine board.Jun 28 2016, 5:00 AM

Change 296266 merged by jenkins-bot:
Picture of the day

https://gerrit.wikimedia.org/r/296266

• bearND moved this task from Code Review to Ready for Signoff on the Mobile-App-Android-Sprint-85-Astatine board.Jun 29 2016, 8:10 PM

• bearND moved this task from Backlog to To Deploy on the Mobile-Content-Service board.Jun 29 2016, 8:25 PM

Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Android-Sprint-85-Astatine board.Jun 30 2016, 6:55 PM

It looks like this is currently designed to fail the request if the image caption isn't available in the language for the requested domain.[1] I don't think we should fail in such a case, but instead fall back to English or no caption. What do you think?

[1] It actually doesn't fail in the way it's meant to, which is a bug I found this morning and I'm working on fixing. There's a test to check that a 504 for an unsupported language (French) is thrown, which is only passing because mwapi.checkForQueryPagesInResponse is improperly returning an error with a 200 status code, triggering the successful response branch of the test, which contains no checks, rather than the error branch, which checks for the 504.

MBinder_WMF edited projects, added Mobile-App-Android-Sprint-86-Radon; removed Unplanned-Sprint-Work.Jul 4 2016, 7:02 PM

MBinder_WMF moved this task from To Do to Done on the Mobile-App-Android-Sprint-86-Radon board.Jul 4 2016, 7:05 PM

Change 297278 had a related patch set uploaded (by Mholloway):
Update Picture of the Day endpoint

https://gerrit.wikimedia.org/r/297278

I've filed T139314: [Bug] iiextmetadatamultilang does not return all available POTD description translations which is relevant to this endpoint.

• Mholloway moved this task from Done to Code Review on the Mobile-App-Android-Sprint-86-Radon board.Jul 4 2016, 9:12 PM

All right, a few more words on image description translations, probably mostly for posterity's sake:

My update patch above leverages the iiextmetadatamultilang query paramater to get a set of translations for the image description, but other translations exist that the query doesn't pick up. This is because the query looks to the descriptions template transcluded into the POTD template page to see which languages are available. The visible list on that, page, however, is a transclusion of a list of pages generated with Special:PrefixIndex, e.g.:

https://commons.wikimedia.org/wiki/Special:PrefixIndex/Template:Potd/2016-07-03

If we really wanted to get every possible translation we could probably scrape the titles/lang codes from either the POTD template page or the transcluded Special:PrefixIndex page, but for now, at least for the MVP, I'd favor just relying on iiextmetadatamultilang.