Page MenuHomePhabricator
Create Task
Maniphest T133134

Abbreviated timestamps not shown in notifications on mobile
Closed, ResolvedPublic
Actions

Assigned To
Catrope
Authored By
Catrope
Apr 20 2016, 12:45 AM
Tags
Referenced Files
F3906132: IMG_0643.PNG
Apr 21 2016, 10:47 PM
F3906231: IMG_0653.PNG
Apr 21 2016, 10:47 PM
F3906130: IMG_0644.PNG
Apr 21 2016, 10:47 PM
F3906134: IMG_0642.PNG
Apr 21 2016, 10:47 PM
Subscribers
Aklapper
Catrope
Etonkovidova
gerritbot
Mooeypoo
TerraCodes

Description

The relevant code is in ext.echo.init.js inside an mw.loader.using( 'ext.echo.ui.desktop' ) block, so it seems clear that it wouldn't be loaded on mobile. But I don't know where it should go instead.

Details

SubjectRepoBranchLines +/-
Apply momentjs hack for short relative times on mobile toomediawiki/extensions/Echomaster+27 -23
Customize query in gerrit

Event Timeline

Catrope created this task.Apr 20 2016, 12:45 AM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptApr 20 2016, 12:45 AM
Catrope moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 20 2016, 12:45 AM
Catrope claimed this task.Apr 20 2016, 12:50 AM
Catrope moved this task from Ready for Pickup to In Development on the Collab-Team-2016-Apr-Jun-Q4 board.
Catrope added a subscriber: Mooeypoo.
gerritbot subscribed.Apr 20 2016, 12:53 AM

Change 284380 had a related patch set uploaded (by Catrope):
Apply momentjs hack for short relative times on mobile too

https://gerrit.wikimedia.org/r/284380

gerritbot added a project: Patch-For-Review.Apr 20 2016, 12:53 AM
Catrope moved this task from In Development to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 20 2016, 12:53 AM
gerritbot added a comment.Apr 20 2016, 1:50 AM

Change 284380 merged by jenkins-bot:
Apply momentjs hack for short relative times on mobile too

https://gerrit.wikimedia.org/r/284380

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)).Apr 20 2016, 2:01 AM
SBisson moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 20 2016, 12:27 PM
Etonkovidova subscribed.Apr 21 2016, 10:47 PM

Before the fix

IMG_0644.PNG (1×640 px, 87 KB)

IMG_0643.PNG (1×640 px, 86 KB)

IMG_0642.PNG (1×640 px, 130 KB)

After the fix - timestamps are abbreviated. The screenshot below shows abbreviated timestamps for cross-wiki notifications too.

IMG_0653.PNG (1×640 px, 107 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 21 2016, 10:47 PM
• jmatazzoni closed this task as Resolved.Apr 22 2016, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL