Page MenuHomePhabricator
Create Task
Maniphest T134634

Replace phplot graphs with JavaScript library solution
Closed, ResolvedPublic
Actions

Description

This will make the data better reusable as it will be exposed in machine readable format. With JavaScript we also do not need to worry about fonts and we can make prettier and more interactive graphs.

Details

SubjectRepoBranchLines +/-
Ignore empty array options when generating TranslationStats template codemediawiki/extensions/Translatemaster+3 -0
Add Chart.js in Special:TranslationStatsmediawiki/extensions/Translatemaster+16 K -342
Add API to fetch translation statsmediawiki/extensions/Translatemaster+118 -16
Add a common interface to query translation statisticsmediawiki/extensions/Translatemaster+164 -105
Refactor stats data fetching logic into TranslationStatsDataProvidermediawiki/extensions/Translatemaster+233 -224
Create separate classes for different graph typesmediawiki/extensions/Translatemaster+496 -459
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.May 7 2016, 7:39 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 7 2016, 7:39 AM
Ricordisamoa subscribed.May 7 2016, 11:30 AM

ContentTranslation uses Chart.js, MediaWiki-extensions-Graph has D3.js.

Arthur2e5 subscribed.May 11 2016, 7:34 PM
Nikerabbit triaged this task as Low priority.Jun 14 2016, 2:02 PM
Nikerabbit added a project: patch-welcome.
Nikerabbit moved this task from Backlog to Statistics on the MediaWiki-extensions-Translate board.
Liuxinyu970226 subscribed.Jan 6 2017, 9:09 AM
Pginer-WMF added a project: Language-Team (Language-2020-July-September).Aug 6 2020, 4:42 PM
abi_ claimed this task.Aug 12 2020, 4:39 AM
abi_ moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2020-July-September) board.
gerritbot added a comment.Aug 17 2020, 4:32 PM

Change 620736 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] [WIP] Add Chart.js in Special:TranslationStats

https://gerrit.wikimedia.org/r/620736

gerritbot added a project: Patch-For-Review.Aug 17 2020, 4:32 PM
abi_ added a comment.Aug 20 2020, 4:06 PM

Screenshot from a quick POC -

image.png (925×870 px, 27 KB)

Will discuss with Niklas further.

gerritbot added a comment.Aug 26 2020, 11:41 AM

Change 622546 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Create separate classes for different graph types

https://gerrit.wikimedia.org/r/622546

gerritbot added a comment.Aug 26 2020, 11:41 AM

Change 622547 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Refactor stats data fetching logic into TranslationStatsDataProvider

https://gerrit.wikimedia.org/r/622547

gerritbot added a comment.Aug 26 2020, 11:41 AM

Change 622548 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Add a common interface to query graph options

https://gerrit.wikimedia.org/r/622548

gerritbot added a comment.Aug 30 2020, 8:58 AM

Change 623169 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Add API to fetch translation stats

https://gerrit.wikimedia.org/r/623169

gerritbot added a comment.Sep 2 2020, 8:31 AM

Change 622546 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Create separate classes for different graph types

https://gerrit.wikimedia.org/r/622546

gerritbot added a comment.Sep 2 2020, 11:07 AM

Change 622547 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Refactor stats data fetching logic into TranslationStatsDataProvider

https://gerrit.wikimedia.org/r/622547

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 2 2020, 12:00 PM
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2020-July-September) board.Sep 7 2020, 2:45 AM
gerritbot added a comment.Sep 9 2020, 8:50 AM

Change 622548 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add a common interface to query translation statistics

https://gerrit.wikimedia.org/r/622548

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.9; 2020-09-15); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 9 2020, 9:00 AM
gerritbot added a comment.Sep 15 2020, 11:06 AM

Change 627477 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Ignore empty array options when generating TranslationStats template code

https://gerrit.wikimedia.org/r/627477

gerritbot added a comment.Sep 15 2020, 11:57 AM

Change 623169 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add API to fetch translation stats

https://gerrit.wikimedia.org/r/623169

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 15 2020, 12:00 PM
gerritbot added a comment.Sep 15 2020, 1:43 PM

Change 620736 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add Chart.js in Special:TranslationStats

https://gerrit.wikimedia.org/r/620736

gerritbot added a comment.Sep 15 2020, 1:43 PM

Change 627477 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Ignore empty array options when generating TranslationStats template code

https://gerrit.wikimedia.org/r/627477

Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2020-July-September) board.Sep 16 2020, 6:22 AM
Nikerabbit removed a project: Patch-For-Review.
Nikerabbit mentioned this in T263004: Enable Special:TranslationStats on Wikimedia production.Sep 16 2020, 7:47 AM
Nikerabbit added a parent task: T263004: Enable Special:TranslationStats on Wikimedia production.Sep 16 2020, 7:50 AM
abi_ added a subtask: T263092: TranslationStats graphs should be oriented horizontally.Sep 17 2020, 4:24 AM
abi_ added a subtask: T263095: TranslationStats: Refactor TranslationStatsGraphOptions.Sep 17 2020, 6:22 AM
gerritbot added a comment.Sep 17 2020, 6:28 AM

Change 627984 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Align translation stats graphs horizontally

https://gerrit.wikimedia.org/r/627984

gerritbot added a project: Patch-For-Review.Sep 17 2020, 6:28 AM
abi_ removed a project: Patch-For-Review.Sep 17 2020, 6:33 AM
abi_ added a comment.EditedSep 17 2020, 7:18 AM

This is now deployed on Translatewiki.net. We've removed the dependency on PHPlot and are now rendering the graph using Chart.js. While working on this, we've also added an API (translationstats) that is queried to fetch the data for the graph.

We're going to file some follow-up tasks to do some bug fixes and other code improvements that were identified while working on this task.

abi_ added a subtask: T263106: TranslationStats: Numbers in the graph are not properly formatted.Sep 17 2020, 9:20 AM
Nikerabbit removed a project: patch-welcome.Sep 21 2020, 3:54 PM
abi_ removed a subtask: T263111: Convert SpecialTranslationStats to use OOUI.Sep 23 2020, 12:07 PM
abi_ closed subtask T263106: TranslationStats: Numbers in the graph are not properly formatted as Resolved.Sep 28 2020, 10:55 AM
abi_ closed subtask T263092: TranslationStats graphs should be oriented horizontally as Resolved.Sep 28 2020, 10:59 AM
abi_ moved this task from Recheck after deployment to In Progress on the Language-Team (Language-2020-July-September) board.Sep 28 2020, 11:16 AM
abi_ removed a subtask: T263095: TranslationStats: Refactor TranslationStatsGraphOptions.
abi_ mentioned this in T263095: TranslationStats: Refactor TranslationStatsGraphOptions.
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2020-July-September) board.Oct 1 2020, 12:28 PM
abi_ added a comment.Oct 1 2020, 12:40 PM

Development on all tasks (and bugs) under this task is done and deployed. Currently waiting for QA on T263543: Improve accessibility for the Translation statistics and configuration change for T264158: Stat type registrations is too slow for Wikimedia production

Pginer-WMF edited projects, added Language-Team (Language-2020-October-December); removed Language-Team (Language-2020-July-September).Oct 2 2020, 9:03 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2020-October-December) board.
Nikerabbit closed subtask T263543: Improve accessibility for the Translation statistics as Resolved.Oct 8 2020, 12:34 PM
Nikerabbit closed subtask T264158: Stat type registrations is too slow for Wikimedia production as Resolved.Oct 21 2020, 11:40 AM
Nikerabbit closed this task as Resolved.Oct 21 2020, 11:43 AM
Nikerabbit moved this task from In Review to Done on the Language-Team (Language-2020-October-December) board.

All sub-tasks have been resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits