Page MenuHomePhabricator
Create Task
Maniphest T134669

Make Refreshed skin less specific to Brickimedia
Closed, ResolvedPublic
Actions

Description

The Refreshed skin should be less brickimedia specific so other wikis don't have to download unnecessary files they're not going to use (files should only be there if they're going to be used globally otherwise local files should be on our own local site), this means:

  • Logo images on wiki instead of in repo: T142156
  • Custom font on wiki instead of in repo: T142157
  • Remove the .png wordmark fallbacks since we're officially not supporting IE 8 anymore. Also helps with performance since loading less files that aren't being used
  • Requires some rewriting of Refreshed header component
  • Since this breaks directory paths, this should be counted as a major patch instead of a minor patch. So instead of 3.1.1, this should be included in 4.1.1 and should be reflected on the Refreshed.php file ( Note: I found a good way of versioning that I like in of these comments at https://github.com/alrra/browser-logos/issues/76 )
  • Reflect these changes on mw docs https://www.mediawiki.org/wiki/Skin:Refreshed

Original comments and issue at Github: https://github.com/Brickimedia/brickimedia/issues/451

Details

SubjectRepoBranchLines +/-
Allow the dropdown menu to be configured onwiki instead of in LocalSettings.phpmediawiki/skins/Refreshedmaster+171 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

SamanthaNguyen created this task.May 7 2016, 10:53 PM
Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 7 2016, 10:53 PM
SamanthaNguyen moved this task from Backlog to Feedback / Suggestions on the Brickimedia board.May 7 2016, 10:53 PM
SamanthaNguyen moved this task from Backlog to Feedback / Suggestions on the Refreshed board.May 8 2016, 3:25 PM
SamanthaNguyen moved this task from Feedback / Suggestions to Refreshed on the Brickimedia board.May 8 2016, 3:54 PM
MacFan4000 changed the task status from Open to Stalled.Jul 11 2016, 4:54 PM
MacFan4000 triaged this task as Medium priority.
MacFan4000 subscribed.
MacFan4000 removed a subscriber: Zppix.Jul 11 2016, 5:52 PM
georgebarnick removed georgebarnick as the assignee of this task.Jul 11 2016, 6:48 PM
georgebarnick subscribed.
ashley added a project: ShoutWiki.Jul 27 2016, 6:43 PM
ashley subscribed.

I agree that there's basically no reason why Brickimedia-specific wordmarks are bundled with Refreshed (other than historical reasons, that is). The bigger question, of course, is that where should we put them and when; caching needs to be taken into account so we can't just drop 'em right away. (Granted, it doesn't save much disk space, but still.)

For ShoutWiki (our T89) a more pressing concern is the header element. I'd really like to get rid of $wgRefreshedHeader altogether or at least provide an on-wiki way of configuring it (which can be hidden behind a global if necessary). We want to give the users more control over the way how their wiki looks like, and that's not what's happening here if and when they'd need to file a support ticket (Special:Contact) for each and every change request. The feature itself is nevertheless nifty and simply axing it would be the easy but dirty way out, which I don't want us to take.

SamanthaNguyen added a comment.Jul 28 2016, 1:29 AM

We can host the brickimedia logos on brickimedia.org/images instead of mw-skin-Refreshed/Refreshed/images. As for $wgRefreshedHeader, we can replace it with an on-wiki MediaWiki:Refreshed-wiki-dropdown.

Syntax

* wiki name, serves as alt
** wiki logo URL
** wiki link URL

Example

* Meta
** <meta logo>
** http://meta.brickimedia.org/wiki/Main_Page
* Brickipedia
** <brickipedia logo>
** http://en.brickimedia.org/wiki/Main_Page
* Customs
** <customs logo
** http://customs.brickimedia.org/wiki/Main_Page
ashley mentioned this in T141318: Close Customs, Ideas, and Meta wikis on the Brickimedia Farm .Jul 31 2016, 2:34 PM
SamanthaNguyen added a comment.Aug 1 2016, 7:30 AM

Updating the above comment, forgot about the mobileimg array key introduced sometime in Refreshed 3.x (https://www.mediawiki.org/wiki/Skin:Refreshed#Mobile_logo) - Here's the new version with somewhat different syntax (also more explanation on how it'd work) down below. Also actually meant images.brickimedia.org, not brickimedia.org/images, oops. :P

Syntax

The first super-bullet (*) is the first wiki that appears, the rest of the super-bullets are served in the dropdown menu. The alt mentioned is the alt attribute in the img element.

* wiki name, serves as alt
** wiki link URL
** wiki logo URL
** mobile wiki logo URL
gerritbot subscribed.Aug 2 2016, 11:57 AM

Change 302417 had a related patch set uploaded (by Jack Phoenix):
Allow the dropdown menu to be configured onwiki instead of in LocalSettings.php

https://gerrit.wikimedia.org/r/302417

ashley mentioned this in R1893:75025726dff9: Allow the dropdown menu to be configured onwiki instead of in LocalSettings.php.Aug 2 2016, 11:59 AM
ashley mentioned this in R1893:ca5658894000: Allow the dropdown menu to be configured onwiki instead of in LocalSettings.php.Aug 4 2016, 10:56 PM
ashley mentioned this in R1893:4f290986cc05: Allow the dropdown menu to be configured onwiki instead of in LocalSettings.php.Aug 4 2016, 11:15 PM
gerritbot added a comment.Aug 4 2016, 11:18 PM

Change 302417 merged by Jack Phoenix:
Allow the dropdown menu to be configured onwiki instead of in LocalSettings.php

https://gerrit.wikimedia.org/r/302417

SamanthaNguyen added subtasks: T142157: Make Refreshed less-specific to Brickimedia: Custom font for skin should be definable on wiki instead of the repo, T142156: Make Refreshed less-specific to Brickimedia: Logo images should be self-hosted onwiki instead of in the repo.Aug 4 2016, 11:57 PM
SamanthaNguyen updated the task description. (Show Details)Aug 5 2016, 12:00 AM
SamanthaNguyen updated the task description. (Show Details)
SamanthaNguyen updated the task description. (Show Details)Aug 16 2016, 10:57 PM
SamanthaNguyen mentioned this in T143381: Remove Customs, Ideas, Meta and related code from LocalSettings repo at GitHub.Aug 19 2016, 4:38 AM
SamanthaNguyen mentioned this in T146003: DeepSea list of wikis should be configurable onwiki.Sep 19 2016, 2:36 AM
SamanthaNguyen moved this task from Feedback / Suggestions to Feedback on the Refreshed board.Sep 19 2016, 2:55 AM
SamanthaNguyen added a subtask: T146008: Make Refreshed less specific to Brickimedia: Remove studs-tile-refreshed.png from the source code.Sep 19 2016, 4:16 AM
SamanthaNguyen closed subtask T146008: Make Refreshed less specific to Brickimedia: Remove studs-tile-refreshed.png from the source code as Resolved.Dec 29 2016, 2:32 AM
SamanthaNguyen closed subtask T142156: Make Refreshed less-specific to Brickimedia: Logo images should be self-hosted onwiki instead of in the repo as Resolved.Jun 3 2017, 9:11 PM
SamanthaNguyen added a project: Technical-Debt.
SamanthaNguyen updated the task description. (Show Details)
SamanthaNguyen moved this task from Unsorted to Cleanup on the Technical-Debt board.
SamanthaNguyen removed subscribers: gerritbot, Brickimedia.
MtMNC closed this task as Resolved.Jan 5 2020, 10:46 PM
MtMNC claimed this task.
MtMNC closed subtask T142157: Make Refreshed less-specific to Brickimedia: Custom font for skin should be definable on wiki instead of the repo as Resolved.
MtMNC subscribed.

Closing since Refreshed 4 resolves T142157.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL