| • Niedzielski | |
| May 10 2016, 5:01 PM |
| F3991960: screenshot-2016-05-10-10-58-46-023655167.png | |
| May 10 2016, 5:01 PM |
No matches found message appears below edit text.
No matches found message overlaps edit text.
App version: c27b9351b0ee85df53c5a9974ebe1266d432c293
Android OS versions: API 23
Device model: Nexus 6P
Device language: English
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fixes T134906. Prevent No matches found message from overlapping. | apps/android/wikipedia | master | +11 -11 |
This could be fixed by moving the error to a shared layout with the list itself, so that the error displays in the centre of that layout rather than the centre of the entire screen (therefore sometimes overlapping the search box). Does that sound like a sane approach?
I think so. Right now it seems to be centered in the outermost View. If the message could appear at the same View hierarchy depth as the list, maybe both could be offset below the text input.
Change 317758 had a related patch set uploaded (by Anirudh24seven):
Fixes T134906. Prevent No matches found message from overlapping.
Change 317758 had a related patch set uploaded (by Niedzielski):
Fixes T134906. Prevent No matches found message from overlapping.
Change 317758 merged by jenkins-bot:
Fixes T134906. Prevent No matches found message from overlapping.