Page MenuHomePhabricator
Create Task
Maniphest T135266

Gate cross-wiki preferences entirely (default off)
Closed, ResolvedPublic
Actions

Description

Gate the cross-wiki feature entirely with a $wg.

If off, cross-wiki notifications are always off, $wgEchoUseCrossWikiBetaFeature should be ignored, and the preference should not be registered.

This can be done already (by setting the preference off and hiding it), but that should be the default, since most wikis using Echo are probably not cross-wiki.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/EchoREL1_27+87 -47Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications
operations/mediawiki-configmaster+0 -5Remove HiddenPrefs hack for turning off cross-wiki notifications
mediawiki/extensions/Echowmf/1.28.0-wmf.1+100 -59Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications
mediawiki/extensions/Echomaster+100 -59Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications
operations/mediawiki-configmaster+1 -0Set $wgEchoCrossWikiNotifications to true on CentralAuth wikis
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.May 13 2016, 8:16 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 13 2016, 8:16 PM
• Mattflaschen-WMF mentioned this in T135246: Wrong notification counts being shown due to cache pollution coming from non-SUL wikis.May 13 2016, 8:16 PM
Catrope claimed this task.May 13 2016, 8:17 PM
gerritbot added a subscriber: gerritbot.May 13 2016, 8:48 PM

Change 288697 had a related patch set uploaded (by Catrope):
Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications

https://gerrit.wikimedia.org/r/288697

gerritbot added a project: Patch-For-Review.May 13 2016, 8:48 PM
gerritbot added a comment.May 13 2016, 8:55 PM

Change 288701 had a related patch set uploaded (by Catrope):
Set $wgEchoCrossWikiNotifications to true on CentralAuth wikis

https://gerrit.wikimedia.org/r/288701

gerritbot added a comment.May 13 2016, 8:55 PM

Change 288702 had a related patch set uploaded (by Catrope):
Remove HiddenPrefs hack for turning off cross-wiki notifications

https://gerrit.wikimedia.org/r/288702

gerritbot added a comment.May 13 2016, 9:01 PM

Change 288701 merged by jenkins-bot:
Set $wgEchoCrossWikiNotifications to true on CentralAuth wikis

https://gerrit.wikimedia.org/r/288701

gerritbot added a comment.May 13 2016, 9:33 PM

Change 288697 merged by jenkins-bot:
Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications

https://gerrit.wikimedia.org/r/288697

gerritbot added a comment.May 13 2016, 9:34 PM

Change 288707 had a related patch set uploaded (by Catrope):
Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications

https://gerrit.wikimedia.org/r/288707

gerritbot added a comment.May 13 2016, 9:49 PM

Change 288707 merged by jenkins-bot:
Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications

https://gerrit.wikimedia.org/r/288707

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)), MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)).May 13 2016, 10:00 PM
SBisson moved this task from Untriaged to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 16 2016, 1:08 PM
Etonkovidova added a subscriber: Etonkovidova.Jun 8 2016, 11:33 PM

Checked as general regressions testing for Preferences; also checked in vagrant for $wgEchoUseCrossWikiBetaFeature and $wgEchoCrossWikiNotifications.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 8 2016, 11:34 PM
• jmatazzoni closed this task as Resolved.Jun 9 2016, 5:14 PM
gerritbot added a comment.Jun 9 2016, 11:37 PM

Change 288702 merged by jenkins-bot:
Remove HiddenPrefs hack for turning off cross-wiki notifications

https://gerrit.wikimedia.org/r/288702

Stashbot added a subscriber: Stashbot.Jun 9 2016, 11:47 PM

Mentioned in SAL [2016-06-09T23:47:45Z] <dereckson@tin> Synchronized wmf-config/CommonSettings.php: Remove HiddenPrefs hack for turning off cross-wiki notifications (T135266) (duration: 00m 27s)

gerritbot added a comment.Jun 19 2016, 9:45 AM

Change 295113 had a related patch set uploaded (by Catrope):
Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications

https://gerrit.wikimedia.org/r/295113

gerritbot added a comment.Jun 20 2016, 4:22 PM

Change 295113 merged by Catrope:
Add $wgEchoCrossWikiNotifications flag to disable cross-wiki notifications

https://gerrit.wikimedia.org/r/295113

Kghbln mentioned this in T138132: UPO on "Special:Preferences" for cross wiki notifications should not show on stand alone wiki.Jun 21 2016, 11:45 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL