Page MenuHomePhabricator

Don't interrupt userpage editing with ContentTranslation pop-ups
Closed, ResolvedPublic

Description

In several recent wiki editing workshops I conducted (with a total of a couple hundreds attendees, I think), the main obstacle users encountered in creating their user page was the ContentTranslation popup which absurdly suggests to translate the userpage from another language.

There are very few cases where ContentTranslation may be userful in the User namespace, and none when one is editing (creating) a userpage (i.e. non-subpage page in User namespace).

Event Timeline

Amire80 renamed this task from Don't interrupt userpage editing with ContentTranslation pupups to Don't interrupt userpage editing with ContentTranslation pop-ups.May 19 2016, 7:35 AM
Amire80 lowered the priority of this task from High to Medium.EditedMay 19 2016, 7:45 AM
Amire80 subscribed.

Thanks. I can reproduce this, but only when editing the user page with VE. It's indeed unnecessary anywhere outside the main namespace.

We should probably run $out->addModules( 'ext.cx.campaigns.newarticle.veloader' ); only in the main namespace.

Other opinions?

Also, for some reason ext.cx.campaigns.newarticle.veloader and ext.cx.campaigns.newarticle are loaded in different hooks, which is odd. I guess that I did at long ago when we were creating the campaigns, I'm not sure why, and I suspect that it must be fixed and loaded in the same hook.

Change 289602 had a related patch set uploaded (by Amire80):
Show the newarticle CX campaign to VE users only in the main namespace

https://gerrit.wikimedia.org/r/289602

Also, for some reason ext.cx.campaigns.newarticle.veloader and ext.cx.campaigns.newarticle are loaded in different hooks, which is odd. I guess that I did at long ago when we were creating the campaigns, I'm not sure why, and I suspect that it must be fixed and loaded in the same hook.

... OK, it's because of different hooks :/

I sent a simple patch and added a comment about this.

Change 289602 merged by jenkins-bot:
Show the newarticle CX campaign to VE users only in the main namespace

https://gerrit.wikimedia.org/r/289602

Arrbee moved this task from QA to Done on the Language-Q4-2016-Sprint 3 board.