Thanks logs page id 0
Open, Needs TriagePublic


I just noticed that when I thanked someone for their edit on my own talk page, the value for logging.log_page field was 0, rather than the page ID of my talk page. This is bad behavior; the correct page ID should be logged.

A quick look at the database shows that 0 is in fact the most common page id with log_type = 'thanks' which means a lot of the log_page information logged by thanks is junk.

I think this should be fixed in two parts: (a) the correct page id is always logged, never a 0, and (b) the update script will find the page id for previous thank events and replace 0 with correct id to the best of its ability.

Huji created this task.May 23 2016, 10:35 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 23 2016, 10:35 PM
Legoktm closed this task as Invalid.May 23 2016, 11:15 PM
Legoktm added a subscriber: Legoktm.

This is intentional, you're not supposed to be able to correlate a thanks log entry with the specific edit that the thank was for.

Huji reopened this task as Open.May 24 2016, 12:40 AM

Reopening. What you just said doesn't answer this issue. For all other pages, except for one's own talk page, the page ID is stored. Why not for one's own talk page?

Note that we are talking "page" ID, not "edit" ID.

I think (I could be wrong, since I'm new to the code.) that logging.log_page is the page ID of the user page for the user being thanked. If that user doesn't have such a page, it's 0.

Yoland10 closed this task as Resolved.Mon, Oct 8, 12:42 PM
Yoland10 triaged this task as Normal priority.
Yoland10 set Due Date to Sun, Oct 7, 11:00 PM.
Restricted Application added a project: Growth-Team. · View Herald TranscriptMon, Oct 8, 12:42 PM
Restricted Application changed the subtype of this task from "Task" to "Deadline". · View Herald Transcript
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptMon, Oct 8, 12:50 PM
Aklapper reopened this task as Open.EditedMon, Oct 8, 1:55 PM
Aklapper raised the priority of this task from Normal to Needs Triage.

@Yoland10: Please do not resolve tasks when they are not resolved. Resetting priority as this is up to developers who work on resolving this task.

@Aklapper okay... I'm sorry about that i was having problems editing a task