Page MenuHomePhabricator

Special Search namespaces selection block displayed behind the search box
Closed, ResolvedPublic

Description

It happens when no results are displayed:

  • direct access to Special:Search
  • Search error
  • No result found

This was certainly introduced by T136945

Event Timeline

dcausse created this task.Jun 8 2016, 10:02 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 8 2016, 10:02 AM
dcausse updated the task description. (Show Details)Jun 8 2016, 10:04 AM

So since this is blocking train rollout, is a sane course of action to revert https://gerrit.wikimedia.org/r/#/c/292571/ ?

dcausse added a subscriber: Florian.EditedJun 8 2016, 8:20 PM

I'm ok to revert and keep the extra line break until we fix it correctly, @Florian what do you think?

ping @Jdforrester-WMF as the original proponent of the updated search box feature

@dcausse: I think an extra line break is better as the current result. However, it would be possible to fix the problem with a single line fix, so I let the decision up to you, if you want to merge a revert or backport a fix (and review it), I'll upload one nonetheless :)

Background: As far as I remember from my thoughts about a fix for the root problem (which result in the change https://gerrit.wikimedia.org/r/#/c/292571/ ), I'm pretty sure, that the float:left; was there before I converted Special:Search to OOUI, but I'm not sure anymore :)

Florian claimed this task.Jun 8 2016, 8:30 PM
Florian triaged this task as High priority.
Florian added a project: Design.

Change 293416 had a related patch set uploaded (by Florianschmidtwelzow):
Add a visual clear to Special:Search input box and profile-tabs

https://gerrit.wikimedia.org/r/293416

@Florian I'm ok with whatever solution you propose, if you have a one-line fix I can try to review (at least test it). My UX skills are too rusty to be of any help here :)

Change 293422 had a related patch set uploaded (by Florianschmidtwelzow):
Add a visual clear to Special:Search input box and profile-tabs

https://gerrit.wikimedia.org/r/293422

Change 293416 merged by jenkins-bot:
Add a visual clear to Special:Search input box and profile-tabs

https://gerrit.wikimedia.org/r/293416

Change 293422 merged by jenkins-bot:
Add a visual clear to Special:Search input box and profile-tabs

https://gerrit.wikimedia.org/r/293422

thcipriani closed this task as Resolved.Jun 8 2016, 9:06 PM

Fix is now deployed live on wmf.5