Improve primary buttons' and ToggleSwitchWidget's (on) focus state
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Jun 12 2016, 9:07 AM

Description

Focus state of primary buttons and ToggleSwitchWidget on follows 1px inset #fff style rule. It should stay that way but leave 2px distance to appear harmonious with normal buttons and widget's focus states, as @RHo rightfully pointed out.

Current	Improved

Details

	Subject	Repo	Branch	Lines +/-
	MediaWiki theme: Improve focus states of primary buttons & ToggleSwitchWidget	oojs/ui	master	+45 -55

Customize query in gerrit

Related Objects

Mentioned In: T115293: Standardize on component focus states

Event Timeline

Volker_E created this task.Jun 12 2016, 9:07 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 12 2016, 9:07 AM

Volker_E added a subscriber: Pginer-WMF.Jun 12 2016, 8:15 PM

Volker_E updated the task description. (Show Details)Jun 12 2016, 8:23 PM

Change 294014 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Improve focus states of primary buttons & ToggleSwitchWidget

https://gerrit.wikimedia.org/r/294014

gerritbot added a project: Patch-For-Review.Jun 12 2016, 8:27 PM

Volker_E mentioned this in T115293: Standardize on component focus states.Jun 12 2016, 8:32 PM

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Jun 13 2016, 3:34 PM

Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.Jun 25 2016, 11:08 AM

• Prtksxna closed this task as Resolved.Jun 25 2016, 11:32 AM

• Prtksxna moved this task from Review to Done on the UI-Standardization-Kanban board.

Change 294014 merged by jenkins-bot:
MediaWiki theme: Improve focus states of primary buttons & ToggleSwitchWidget

https://gerrit.wikimedia.org/r/294014

Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.17.5 on the OOUI board.Jun 25 2016, 2:32 PM

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.5); removed OOUI.

Volker_E removed a project: Patch-For-Review.Feb 7 2017, 8:25 PM

	F4158507: T137658 focus-states OOjs UI Demos 2016-06-12.png
	Jun 12 2016, 8:23 PM

	F4158505: T137658 focus-states improved OOjs UI Demos 2016-06-12.png
	Jun 12 2016, 8:23 PM

Improve primary buttons' and ToggleSwitchWidget's (on) focus stateClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Improve primary buttons' and ToggleSwitchWidget's (on) focus state
Closed, ResolvedPublic
Actions