MassMessage is no longer accepting lists in the MassMessageList content model
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xaosflux
	Jul 4 2016, 4:57 PM

Description

The Special:MassMessage function no longer appears to accept a Page containing list of pages to leave a message on, if the page is in the MassMessageList content model.

This is reproducible on enwiki and test2wiki.

Pages in wikitext format still function.

Example pages:
wikitext (works): https://en.wikipedia.org/wiki/User:Xaosflux/SandboxMMS
wikitext (works): https://test2.wikipedia.org/wiki/User:Xaosflux/SandboxMMS
MML (does not work): https://en.wikipedia.org/wiki/User:Xaosflux/SandboxMMS2
MML (does not work): https://test2.wikipedia.org/wiki/User:Xaosflux/SandboxMMS2

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Show an error to the user if the spamlist has no targets on it"	mediawiki/extensions/MassMessage	wmf/1.28.0-wmf.8	+16 -45
	Revert "Show an error to the user if the spamlist has no targets on it"	mediawiki/extensions/MassMessage	master	+16 -45

Customize query in gerrit

Related Objects

Mentioned In: T139277: Can't send mass message
Mentioned Here: T139277: Can't send mass message

Event Timeline

Xaosflux created this task.Jul 4 2016, 4:57 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 4 2016, 4:57 PM

Xaosflux renamed this task from MassMessage is no longer accepting lists in the MassMessage content model to MassMessage is no longer accepting lists in the MassMessageList content model.Jul 4 2016, 5:02 PM

This is caused by https://gerrit.wikimedia.org/r/#/c/94691/, where a really old patch from pre-mmch days was revived and merged.

I assume T139277 is a duplicate of this task and could be merged into this?

CC'ing @Legoktm as per last comment (author of the patch that might have introduced this regression)

Xaosflux mentioned this in T139277: Can't send mass message.Jul 4 2016, 6:47 PM

wctaiwan merged a task: T139277: Can't send mass message.Jul 4 2016, 6:48 PM

wctaiwan added a subscriber: Shizhao.

Adding subscribers from enwiki WP:VPT

Xaosflux merged a task: T139277: Can't send mass message.Jul 4 2016, 6:52 PM

Xaosflux awarded a token.Jul 4 2016, 7:05 PM

Change 297285 had a related patch set uploaded (by Legoktm):
Revert "Show an error to the user if the spamlist has no targets on it"

https://gerrit.wikimedia.org/r/297285

Change 297291 had a related patch set uploaded (by Legoktm):
Revert "Show an error to the user if the spamlist has no targets on it"

https://gerrit.wikimedia.org/r/297291

Change 297285 merged by jenkins-bot:
Revert "Show an error to the user if the spamlist has no targets on it"

https://gerrit.wikimedia.org/r/297285

Change 297291 merged by jenkins-bot:
Revert "Show an error to the user if the spamlist has no targets on it"

https://gerrit.wikimedia.org/r/297291

Mentioned in SAL [2016-07-04T19:57:07Z] <legoktm@tin> Synchronized php-1.28.0-wmf.8/extensions/MassMessage/: MassMessage is no longer accepting lists in the MassMessageList content model - T139303 (duration: 00m 39s)

Kharkiv07 awarded a token.Jul 4 2016, 8:00 PM

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)), MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jul 4 2016, 8:00 PM

Revert should be deployed, please let @wctaiwan know if there are any more issues :) <3

Legoktm closed this task as Resolved.Jul 4 2016, 8:02 PM

Legoktm claimed this task.

Confirmed solved on enwiki, thank you!

MassMessage is no longer accepting lists in the MassMessageList content modelClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

MassMessage is no longer accepting lists in the MassMessageList content model
Closed, ResolvedPublic
Actions