Page MenuHomePhabricator
Create Task
Maniphest T140083

Introduce a generic term "all" for show parameter
Open, LowestPublic
Actions

Description

<maplink> and/or <mapframe>: Normally show parameter gets a comma-separated list of marker groups specifying which markers should be presented on a map. The group lists could be large. Therefore I propose an additional syntax with an all parameter:

  • show = "all" // presenting all markers named in an article
  • show = "all,-mask" // presenting all markers named in an article excluding the mask group
  • show = "all,nearby" // presenting all markers named in an article and markers for nearby articles (Wikimedia feature)

Even in case that "nearby" is not interpreted by maplink/mapframe directly it is used to activate an additional map layer.

This task was mentioned at Community-Wishlist-Survey-2017 (https://meta.wikimedia.org/wiki/2017_Community_Wishlist_Survey/Miscellaneous/Kartographer_improvements), which got the No.1 out of 214 proposals.

Details

SubjectRepoBranchLines +/-
Update wikimedia-mapdata to latest (0159e39)mediawiki/extensions/Kartographermaster+1 -1
Support show=all shorthand, cont.mapdatamaster+49 -22
Update wikimedia-mapdata to 1b90575mediawiki/extensions/Kartographermaster+29 -17
Support groups=all shorthandmapdatamaster+23 -9
Support show=all in maplink/mapframemediawiki/extensions/Kartographermaster+18 -4
Customize query in gerrit

Related Objects

Event Timeline

RolandUnger created this task.Jul 12 2016, 1:09 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptJul 12 2016, 1:09 PM
Restricted Application added a subscriber: Zppix. · View Herald Transcript
Yurik added a project: Maps (Kartographer).Jul 12 2016, 5:42 PM
Atsirlin subscribed.Jul 13 2016, 7:10 AM
MaxSem moved this task from All map-related tasks to Kartographer on the Maps board.Jul 16 2016, 11:15 PM
Yurik removed a project: Maps.Dec 15 2016, 4:40 AM
Liuxinyu970226 subscribed.Nov 27 2017, 10:23 AM
• jmatazzoni triaged this task as Low priority.Feb 21 2018, 7:17 PM
• jmatazzoni added projects: Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter).
• jmatazzoni subscribed.

I've added this to the board but marked it "Low" priority, as per our discussion in the maps triage meeting.

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Feb 21 2018, 7:18 PM
• jmatazzoni lowered the priority of this task from Low to Lowest.Feb 21 2018, 11:53 PM
• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).Feb 26 2018, 11:48 PM
• jmatazzoni renamed this task from <maplink> and/or <mapframe>: introduction of a generic term "all" for show parameter to Introduce a generic term "all" for show parameter.Feb 27 2018, 10:28 PM
• jmatazzoni updated the task description. (Show Details)
• jmatazzoni moved this task from Need Triage to In Progress on the Collaboration-Feature-Rollouts (Collaboration-Maps) board.Apr 11 2018, 11:51 PM
• Mholloway claimed this task.Apr 13 2018, 4:55 PM
• Mholloway moved this task from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot subscribed.Apr 13 2018, 9:27 PM

Change 426241 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/Kartographer@master] Support show=all in maplink/mapframe

https://gerrit.wikimedia.org/r/426241

gerritbot added a project: Patch-For-Review.Apr 13 2018, 9:27 PM
gerritbot added a comment.Apr 20 2018, 3:05 PM

Change 427918 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mapdata@master] Support show=all in maplink/mapframe

https://gerrit.wikimedia.org/r/427918

gerritbot added a comment.Apr 20 2018, 3:07 PM

Change 426241 abandoned by Mholloway:
Support show=all in maplink/mapframe

Reason:
see Ia673c5bb96f60c13ba7abaf17d4b4dc3d30dcee9

https://gerrit.wikimedia.org/r/426241

gerritbot added a comment.Apr 24 2018, 6:00 PM

Change 427918 merged by jenkins-bot:
[mapdata@master] Support groups=all shorthand

https://gerrit.wikimedia.org/r/427918

gerritbot added a comment.Apr 25 2018, 7:43 PM

Change 428994 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/Kartographer@master] Update wikimedia-mapdata to 1b90575

https://gerrit.wikimedia.org/r/428994

gerritbot added a comment.May 1 2018, 12:17 AM

Change 428994 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Update wikimedia-mapdata to 1b90575

https://gerrit.wikimedia.org/r/428994

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).May 1 2018, 1:00 AM
• Mholloway moved this task from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 7 2018, 1:38 PM
• Mholloway added a subscriber: Etonkovidova.May 11 2018, 7:24 PM

@Etonkovidova Sorry, this doesn't appear to be quite there yet. Not working in my demo pages:
https://en.wikivoyage.org/wiki/User:MHolloway_(WMF)/Sandbox
https://en.wikivoyage.beta.wmflabs.org/w/index.php?title=User:Mdholloway

On beta, requesting the demo page above throws this error in Kartotherian:

{"name":"kartotherian","hostname":"deployment-maps03","pid":14,"level":50,"levelPath":"error","msg":"GroupId not available","time":"2018-05-11T19:20:13.826Z","v":0}

• Mholloway moved this task from QA Review to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 11 2018, 7:24 PM
gerritbot added a comment.May 29 2018, 7:21 PM

Change 436090 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mapdata@master] Support show=all shorthand, cont.

https://gerrit.wikimedia.org/r/436090

• Mholloway moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 29 2018, 8:30 PM
gerritbot added a comment.May 30 2018, 11:19 PM

Change 436090 merged by jenkins-bot:
[mapdata@master] Support show=all shorthand, cont.

https://gerrit.wikimedia.org/r/436090

gerritbot added a comment.May 31 2018, 12:28 PM

Change 436518 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/Kartographer@master] Update wikimedia-mapdata to latest (0159e39)

https://gerrit.wikimedia.org/r/436518

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 1 2018, 5:29 PM
gerritbot added a comment.Jun 1 2018, 5:41 PM

Change 436518 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Update wikimedia-mapdata to latest (0159e39)

https://gerrit.wikimedia.org/r/436518

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)); removed MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Jun 1 2018, 6:00 PM
• Mholloway changed the task status from Open to Stalled.Jun 25 2018, 3:25 PM

Sorry, @Etonkovidova, still not fixed. Now with the new stuff deployed I'm seeing a new error: "Cannot read property 'failed' of undefined".

I'm going to mark this as stalled because it's probably going to take a back seat to other, more pressing work for the foreseeable future.

• Mholloway removed projects: Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery-ARCHIVED.Jun 25 2018, 3:28 PM
• Mholloway edited projects, added Maps; removed Maps (Kartographer).
• Mholloway edited projects, added Maps (Maps-data); removed Maps.Jun 25 2018, 3:30 PM
Liuxinyu970226 updated the task description. (Show Details)Oct 1 2018, 11:54 PM
Liuxinyu970226 awarded a token.Nov 11 2018, 9:57 AM
• Mholloway removed • Mholloway as the assignee of this task.Jul 8 2019, 3:28 PM
• Mholloway subscribed.
Aklapper changed the task status from Stalled to Open.Aug 16 2020, 2:03 PM

The previous comments don't explain who or what (task?) exactly this task is stalled on ("If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not be acted on"). Hence resetting task status.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits