Page MenuHomePhabricator
Create Task
Maniphest T140388

Get IABot to use new CheckIfDead package
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Once T140135 is finished, we should update the InternetArchiveBot code to use the new package via composer, rather than having it's own code for deadlink detection.

Related Objects
Search...

Event Timeline

kaldari created this task.Jul 14 2016, 5:43 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 14 2016, 5:43 PM
• DannyH moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jul 14 2016, 5:44 PM
• DannyH set the point value for this task to 5.
• DannyH triaged this task as Medium priority.Jul 14 2016, 5:46 PM
• DannyH moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
• DannyH added a parent task: T120433: Migrate dead external links to archives.Jul 19 2016, 6:14 PM
• DannyH edited projects, added Community-Tech-Sprint; removed Community-Tech.Aug 1 2016, 6:23 PM
• DannyH edited parent tasks, added: T140135: Break out CheckIfDead class into a separate GitHub repo; removed: T120433: Migrate dead external links to archives.Aug 1 2016, 6:38 PM
• DannyH removed a parent task: T140135: Break out CheckIfDead class into a separate GitHub repo.
• DannyH added a subtask: T140135: Break out CheckIfDead class into a separate GitHub repo.
• DannyH added a parent task: T120433: Migrate dead external links to archives.Aug 1 2016, 6:42 PM
Niharika claimed this task.Aug 3 2016, 1:12 AM
Niharika moved this task from Ready to In Development on the Community-Tech-Sprint board.
kaldari closed subtask T140135: Break out CheckIfDead class into a separate GitHub repo as Resolved.Aug 3 2016, 10:11 PM
kaldari reopened subtask T140135: Break out CheckIfDead class into a separate GitHub repo as Open.Aug 3 2016, 10:13 PM
Niharika moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Aug 5 2016, 12:29 AM

I put up a PR: https://github.com/wikimedia/Cyberbot_II/pull/2 although I don't really have a way of testing it. Ryan or Leon will have to do the honors.

• Phabricator_maintenance added a project: InternetArchiveBot.Aug 5 2016, 9:11 PM
kaldari moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Aug 12 2016, 11:04 PM
kaldari moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.

Has a merge conflict.

kaldari moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Aug 12 2016, 11:05 PM
Niharika added a comment.Aug 15 2016, 3:30 AM

Fixed.

Niharika moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Aug 15 2016, 3:30 AM
kaldari closed subtask T140135: Break out CheckIfDead class into a separate GitHub repo as Resolved.Aug 16 2016, 8:25 PM

I think this needs to be updated for the recent changes to the CheckIfDead class.

kaldari moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Aug 16 2016, 8:27 PM
Niharika added a comment.Aug 18 2016, 9:20 AM
In T140388#2558553, @kaldari wrote:

I think this needs to be updated for the recent changes to the CheckIfDead class.

It's been updated already. And the merge conflicts have been fixed too.

kaldari added a comment.Aug 18 2016, 4:12 PM

I'm confused. It looks like it's still using checkDeadlinks() instead of areLinksDead(). Is there another pull request?

Niharika added a comment.Aug 18 2016, 6:19 PM
In T140388#2564683, @kaldari wrote:

I'm confused. It looks like it's still using checkDeadlinks() instead of areLinksDead(). Is there another pull request?

Ah! You're right, I updated the format used but forgot to update the name. Fixed now.

Cyberpower678 moved this task from Inbox to Feature requests on the InternetArchiveBot board.Aug 19 2016, 3:50 PM
Cyberpower678 moved this task from Feature requests to New feature on the InternetArchiveBot board.Aug 19 2016, 11:03 PM
Cyberpower678 moved this task from New feature to v1.2 on the InternetArchiveBot board.Aug 21 2016, 2:12 AM
Cyberpower678 edited projects, added InternetArchiveBot (v1.2); removed InternetArchiveBot.
Cyberpower678 moved this task from Unsorted to New feature on the InternetArchiveBot (v1.2) board.
Niharika added a comment.Aug 22 2016, 8:58 AM

This PR needs to be tested before merging.

Niharika moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Aug 22 2016, 8:59 AM
Cyberpower678 edited parent tasks, added: T141347: Create and test v1.2 of InternetArchiveBot (tracking); removed: T120433: Migrate dead external links to archives.Aug 22 2016, 10:59 AM
Cyberpower678 subscribed.

What's the update in this? It looks like it's ready to be merged into IABot.

Niharika added a comment.Aug 22 2016, 11:01 AM
In T140388#2571277, @Cyberpower678 wrote:

What's the update in this? It looks like it's ready to be merged into IABot.

In T140388#2571143, @Niharika wrote:

This PR needs to be tested before merging.

Cyberpower678 added a comment.Aug 22 2016, 1:31 PM
In T140388#2571282, @Niharika wrote:
In T140388#2571277, @Cyberpower678 wrote:

What's the update in this? It looks like it's ready to be merged into IABot.

In T140388#2571143, @Niharika wrote:

This PR needs to be tested before merging.

Pull to the branch composer-test and I'll test it out.
https://github.com/cyberpower678/Cyberbot_II/tree/composer-test

kaldari added a comment.EditedAug 22 2016, 9:16 PM

@Niharika: A few more things...

  • Line 502 in Parser can be deleted now
  • Line 508 in Parser will need to be changed to $link['is_dead'] = $results[$link['url']];
  • Need to require the autoload file in parse.php
  • Need to update tests/Parser/parse.php
kaldari moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Aug 22 2016, 9:17 PM
Niharika added a comment.Aug 24 2016, 3:06 PM
In T140388#2573508, @kaldari wrote:

@Niharika: A few more things...

  • Need to update tests/Parser/parse.php

I don't understand this part. There doesn't seem to be any function which tests analyzePage. What am I missing?
New PR is up at https://github.com/cyberpower678/Cyberbot_II/pull/29 for @Cyberpower678 to test.

kaldari added a comment.Aug 24 2016, 4:29 PM

I don't understand this part. There doesn't seem to be any function which tests analyzePage. What am I missing?

Looks like you fixed it:
https://github.com/cyberpower678/Cyberbot_II/pull/29/files#diff-c710db55adb15404bde6dfaccd3a9124R4

kaldari closed this task as Resolved.Aug 24 2016, 4:43 PM
kaldari moved this task from In Development to Q1 2018-19 on the Community-Tech-Sprint board.
• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Aug 31 2016, 12:03 AM
• DannyH moved this task from Up Next (June 3-21) to Archive on the Community-Tech board.Aug 31 2016, 12:12 AM
Harej mentioned this in T157273: Checking dead links on all projects.Jan 19 2021, 11:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL