Page MenuHomePhabricator
Create Task
Maniphest T140950

Undefined property: CirrusSearch\InterwikiSearcher::$searchContext
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

We see in production this error in the logs:

Undefined property: CirrusSearch\InterwikiSearcher::$searchContext in /srv/mediawiki/php-1.28.0-wmf.11/extensions/CirrusSearch/includes/InterwikiSearcher.php on line 70

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix Searcher::$searchContext visibilitymediawiki/extensions/CirrusSearchwmf/1.28.0-wmf.11+1 -1
Fix Searcher::$searchContext visibilitymediawiki/extensions/CirrusSearchmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Dereckson created this task.Jul 20 2016, 9:07 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptJul 20 2016, 9:07 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
Dereckson claimed this task.Jul 20 2016, 9:09 PM
Dereckson added a subscriber: EBernhardson.

$searchContext is private in Searcher, should be protected to do what 2d3f3780 wants to do.

gerritbot subscribed.Jul 20 2016, 9:15 PM

Change 300168 had a related patch set uploaded (by Dereckson):
Fix Searcher::$searchContext visibility

https://gerrit.wikimedia.org/r/300168

gerritbot added a project: Patch-For-Review.Jul 20 2016, 9:15 PM
Dereckson moved this task from Untriaged to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.Jul 20 2016, 9:15 PM
gerritbot added a comment.Jul 20 2016, 10:09 PM

Change 300168 merged by jenkins-bot:
Fix Searcher::$searchContext visibility

https://gerrit.wikimedia.org/r/300168

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)).Jul 20 2016, 11:00 PM
gerritbot added a comment.Jul 21 2016, 4:33 PM

Change 300306 had a related patch set uploaded (by EBernhardson):
Fix Searcher::$searchContext visibility

https://gerrit.wikimedia.org/r/300306

EBernhardson triaged this task as Unbreak Now! priority.Jul 21 2016, 4:34 PM
EBernhardson merged a task: T140982: Italian Wikivoyage search feature doesn't work with non existing pages.
EBernhardson added subscribers: Andyrom75, Gehel, TerraCodes and 2 others.
gerritbot added a comment.Jul 21 2016, 4:40 PM

Change 300306 merged by jenkins-bot:
Fix Searcher::$searchContext visibility

https://gerrit.wikimedia.org/r/300306

Stashbot subscribed.Jul 21 2016, 4:46 PM

Mentioned in SAL [2016-07-21T16:46:51Z] <ebernhardson@tin> Synchronized php-1.28.0-wmf.11/extensions/CirrusSearch/includes/Searcher.php: T140950: Deploy UBN fix to CirruSearch (duration: 00m 31s)

EBernhardson added a comment.Jul 21 2016, 4:47 PM

patch deployed and verified search on it wikivoyage now works as expected

EBernhardson closed this task as Resolved.Jul 21 2016, 4:48 PM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)).Jul 21 2016, 5:00 PM
Danny_B unsubscribed.Jul 21 2016, 6:50 PM
Krinkle moved this task from Mar 2019 / 1.33wmf20-23 to Resolved on the Wikimedia-production-error board.Mar 19 2019, 3:46 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Gehel edited projects, added Discovery-Search (Current work); removed MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)), Discovery-Search.Feb 11 2025, 3:24 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 11 2025, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits