Page MenuHomePhabricator

Add Phabricator tasks to comments for buggy cosmetic changes
Closed, ResolvedPublic

Description

In source of cosmetic changes there are lines like this:

# FIXME: fix bugs and re-enable

and commented cosmetic changes underneath.

Could you add Phabricator issues into the comment too? It could look like this:

# FIXME: fix T123 and T456 and re-enable

Event Timeline

@Dvorapa: If Phabricator tasks exist anybody could link to them.
Did you find places where links to existing Phabricator tasks are missing?
Or is this a general request to developers which could have gone to the mailing list instead? As I would not see when to declare this task "resolved"...

@Dvorapa: If Phabricator tasks exist anybody could link to them.
Did you find places where links to existing Phabricator tasks are missing?
Or is this a general request to developers which could have gone to the mailing list instead? As I would not see when to declare this task "resolved"...

I talk about source code of cosmetic changes, where some important functions are commented because of some bugs, but nobody (and maybe developers too) don't know, which bugs to fix in order to uncomment these important functions. Specifically please see https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/pywikibot/cosmetic_changes.py;b798809f24a9874a5a040dd4d7f5083f9a837b0b$224

On Czech Wikipedia these three commented functions are the most important.

I wasn't able to find any reports regarding the first two, thus going ahead and re-enabling them seems to be the only possible action. Otherwise these will be sleeping forever. (It might not meet approval though.)

@matej_suchanek At least their re-enablement could help to find out that lost bugs if any.

History of translateMagicWords:

  1. f2645f856d1f - implemented in trunk/compat but disabled
  2. 6ac688fe74c1 - copied to rewrite/core (disabled)
  3. e7565a285feb - fixed and enabled in rewrite/core
  4. f27867b924a4 - disabled in rewrite/core as an update from trunk/compat which had the broken implementation though

All these changes were made by @Xqt.

Dvorapa triaged this task as Lowest priority.

The original issue was solved. The only missing in cc is isbn, which has got many issues.