cosmetic_changes.py and <code>
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Oct 5 2013, 4:45 AM

Description

Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1393/
Reported by: ganz-ru
Created on: 2012-01-14 17:37:31
Subject: cosmetic_changes.py and <code>
Original description:
Here:
http://ru.wikipedia.org/w/index.php?diff=40245627&oldid=39731202
http://ru.wikipedia.org/w/index.php?diff=40765267&oldid=39425330
cosmetic_changes.py replaced the internal internal html-text of <code>...<code> with unicode symbols. That's not good, since the tag <code> is for an original representation of codes, including the html-code. So, I propose to add this tag to the exception list of exceptions.

https://sourceforge.net/p/pywikipediabot/bugs/1393

Details

Reference: bz55222

	Subject	Repo	Branch	Lines +/-
	[bugfix] Re-enable resolveHtmlEntities	pywikibot/core	master	+13 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T141024 Add Phabricator tasks to comments for buggy cosmetic changes
Resolved	Dvorapa	T57222 cosmetic_changes.py and <code>
Resolved	Dvorapa	T195026 Merge regexes from removeDisabledParts with regexes from _create_default_regexes

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:27 AM

• bzimport added a project: Pywikibot-cosmetic-changes.py.

• bzimport set Reference to bz55222.

• bzimport added a subscriber: Unknown Object (????).

Legoktm created this task.Oct 5 2013, 4:45 AM

assigned_to: nobody --> xqt
status: open --> open-accepted

As I see, it just necessary to add this tag into arrays of exceptions and it does not requir editing of any other parts of code. So please accelerate the processing of of this bug.

Feel free to submit a patch.

@ganz-du: unfortunatelly this part of code does not use replaceExcept\(\) and we have no exceptions list where to add that tag.

assigned_to: xqt --> nobody

duplicated by bug \#3530791
raising prio.

priority: 5 --> 6

CosmeticChangesToolkit.resolveHtmlEntities\(\) deactivated in pyrev:10438 due to this bug

priority: 6 --> 7

priority: 7 --> 5

It happens because of the html2unicode function, it can be fixed either in textlib or cosmetic_changes.py

jayvdb lowered the priority of this task from Medium to Low.Nov 30 2014, 4:15 PM

jayvdb added projects: Pywikibot-compat, Pywikibot.

jayvdb set Security to None.

jayvdb removed a subscriber: Unknown Object (????).

jayvdb moved this task from Backlog to Deactivated code on the Pywikibot-cosmetic-changes.py board.Nov 30 2014, 4:23 PM

jayvdb updated the task description. (Show Details)Oct 16 2015, 7:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2015, 7:31 AM

I believe this should be fixed by adding 'code' to the list of exceptions for all of the cosmetic change rules which might reasonably alter something in <code>..</code>, IMO <code> should always be excluded. (as code is used for showing wikitext)

@jayvdb: as mentioned above unfortunatelly this part of code does not use replaceExcept\(\) and we have no exceptions list where to add that tag.

matej_suchanek added a parent task: T141024: Add Phabricator tasks to comments for buggy cosmetic changes.Feb 15 2017, 9:13 PM

Xqt removed a project: Pywikibot-compat.Jun 30 2017, 12:35 PM

Dvorapa added a project: good first task.May 20 2018, 2:51 PM

Restricted Application added a subscriber: Cyberpower678. · View Herald TranscriptMay 20 2018, 2:51 PM

Dvorapa added a subtask: T195026: Merge regexes from removeDisabledParts with regexes from _create_default_regexes.May 21 2018, 9:25 AM