[regression] height of search bar in language overlay changed
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Assigned To

Authored By

	• Nirzar
	Aug 19 2016, 5:39 PM

Description

Almost with every change, the height increases a little bit. and now it's too much

right now:

css fix:

.language-overlay .panel {
padding:7px; or 0.5em;
}

after:

Details

	Subject	Repo	Branch	Lines +/-
	Fix padding on language overlay search input	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rEMFRa00c58dc0b8a: Fix padding on language overlay search input

Event Timeline

• Nirzar created this task.Aug 19 2016, 5:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2016, 5:39 PM

Did we change anything here?

• Nirzar added a project: Design.Aug 23 2016, 5:59 PM

MBinder_WMF unsubscribed.Aug 25 2016, 6:19 PM

Jdlrobson triaged this task as Medium priority.Aug 25 2016, 8:43 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

dr0ptp4kt moved this task from Triaged but Future to Product Owner Backlog on the Web-Team-Backlog board.Aug 25 2016, 8:54 PM

Jdlrobson claimed this task.Aug 25 2016, 9:01 PM

Jdlrobson added projects: Unplanned-Sprint-Work, Reading-Web-Sprint-79-Uh-oh.

Change 306797 had a related patch set uploaded (by Jdlrobson):
Fix padding on language overlay search input

https://gerrit.wikimedia.org/r/306797

gerritbot added a project: Patch-For-Review.Aug 25 2016, 9:02 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-79-Uh-oh board.Aug 25 2016, 9:02 PM

@Jdlrobson: 0.5?

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-79-Uh-oh board.Aug 25 2016, 9:21 PM

@Nirzar: a00c58dc should be deployed to the Beta Cluster shortly.

Change 306797 merged by jenkins-bot:
Fix padding on language overlay search input

https://gerrit.wikimedia.org/r/306797

will keep an eye out.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)).Aug 25 2016, 10:00 PM

dr0ptp4kt moved this task from Product Owner Backlog to 2016-17 Q1 on the Web-Team-Backlog board.Aug 26 2016, 8:06 PM

@Nirzar, your turn - please resolve if you think it's okay. https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page

Looked as expected on Nexus 4 Opera Mini uncompressed, Nexus 4 Chrome, Nexus 7 Chrome, iPhone 5c Safari iOS 9, and Simulator iPad Air 2 Safari iOS 9. Nexus 4 UC Browser uncompressed the magnifying glass was a little off center, but that's a separate matter; Samsung Wave II also had the slightly off center magnifying glass but it otherwise looked okay. The en.m.wikipedia.beta.wmflabs.org cert was causing the usual expected cert warnings, which made it tough to get the modal up, but I imagine it would work about the same.

Looks good.

• Nirzar closed this task as Resolved.Aug 26 2016, 8:48 PM

[regression] height of search bar in language overlay changedClosed, ResolvedPublic0.5 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[regression] height of search bar in language overlay changed
Closed, ResolvedPublic0.5 Estimated Story Points
Actions