Page MenuHomePhabricator

Duplicate set of empty parameters can get added when editing some Infobox Film templates on de.wiki
Closed, ResolvedPublic1 Story Points

Description

At the German Wikipedia, some infobox film templates, if edited with VE, would result in a duplicate, empty set of parameters being added; to see this, try and VEdit the infobox at https://de.wikipedia.org/wiki/Alles_was_kommt. Others though don't seem to show this issue, https://de.wikipedia.org/wiki/Die_5._Welle for instance. I /think/ I have narrowed the problem down to "this happens when aliases are used for the template parameters", but those all seem to be valid aliases per https://de.wikipedia.org/wiki/Vorlage:Infobox_Film/Doku .

Details

Related Gerrit Patches:

Event Timeline

Elitre created this task.Aug 23 2016, 10:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2016, 10:49 AM
Jdforrester-WMF triaged this task as Medium priority.Aug 23 2016, 7:17 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

I think this is because https://gerrit.wikimedia.org/r/#/c/288650/ doesn't take into account suggested/required parameters that are already set under one of their alias names instead of their normal key

Change 313545 had a related patch set uploaded (by Alex Monk):
Don't try to add suggested/required parameters already set under alias names

https://gerrit.wikimedia.org/r/313545

Zache added a subscriber: Zache.Sep 30 2016, 7:25 AM

I made test page for this and it looks like that Alex Monk is correct.

Change 313545 merged by jenkins-bot:
Don't try to add suggested/required parameters already set under alias names

https://gerrit.wikimedia.org/r/313545