Wikibase\SqlIdGenerator::generateNewId: Explicit commit of implicit transaction.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

With 1.28.0-wmf.16 but maybe that happened earlier:

Wikibase\SqlIdGenerator::generateNewId: Explicit commit of implicit transaction.
Wikibase\SqlIdGenerator::generateNewId: Implicit transaction expected (DBO_TRX set).

And another similar serie:

Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages: Explicit commit of implicit transaction.
Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages: Explicit commit of implicit transaction.

Details

	Subject	Repo	Branch	Lines +/-
	Use atomic sections in EntityUsageTable	mediawiki/extensions/Wikibase	master	+4 -4
	Use atomic sections in SqlIdGenerator::generateNewId	mediawiki/extensions/Wikibase	master	+2 -8

Customize query in gerrit

Related Objects

Mentioned In: T144434: Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages: Implicit transaction already active (from DatabaseBase::query (Wikibase\Client\Usage\Sql\EntityUsageTable::queryUsages)).
T144398: wikibase-addUsagesForPage generates transaction error logs "Implicit transaction already active" "Explicit commit of implicit transaction" "Implicit transaction expected"
T141551: MW-1.28.0-wmf.16 deployment blockers

Event Timeline

hashar created this task.Aug 24 2016, 7:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2016, 7:14 PM

hashar updated the task description. (Show Details)Aug 24 2016, 7:16 PM

hashar added a project: MediaWiki-libs-Rdbms.

hashar added a parent task: T141551: MW-1.28.0-wmf.16 deployment blockers.

hashar mentioned this in T141551: MW-1.28.0-wmf.16 deployment blockers.

greg added a project: MediaWiki-extensions-WikibaseClient.Aug 24 2016, 8:31 PM

hoo claimed this task.Aug 24 2016, 8:33 PM

hoo added projects: MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2016-08-16.

Change 306544 had a related patch set uploaded (by Hoo man):
Use atomic sections in SqlIdGenerator::generateNewId

https://gerrit.wikimedia.org/r/306544

gerritbot added a project: Patch-For-Review.Aug 24 2016, 8:41 PM

Change 306544 merged by jenkins-bot:
Use atomic sections in SqlIdGenerator::generateNewId

https://gerrit.wikimedia.org/r/306544

Change 307271 had a related patch set uploaded (by Hoo man):
Use atomic sections in EntityUsageTable

https://gerrit.wikimedia.org/r/307271

hoo moved this task from Proposed to Review on the Wikidata-Sprint-2016-08-16 board.Aug 29 2016, 11:14 AM

Once the two remaining changes are merged, there are no further begin()/commit() calls in the Wikibase code base.

This was marked as blocking wmf.16, wmf.16 is now everywhere. What's the status?

Not actually a blocker.

thiemowmde triaged this task as Medium priority.Aug 30 2016, 12:47 PM

thiemowmde added a project: Wikidata-Sprint-2016-08-30.

Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-08-30 board.Aug 30 2016, 12:49 PM

Change 307271 merged by jenkins-bot:
Use atomic sections in EntityUsageTable

https://gerrit.wikimedia.org/r/307271

All changes merged.

hoo mentioned this in T144398: wikibase-addUsagesForPage generates transaction error logs "Implicit transaction already active" "Explicit commit of implicit transaction" "Implicit transaction expected".Sep 1 2016, 8:19 PM

hoo mentioned this in T144434: Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages: Implicit transaction already active (from DatabaseBase::query (Wikibase\Client\Usage\Sql\EntityUsageTable::queryUsages))..Sep 1 2016, 8:31 PM

Thank you for the quick fix. It is highly appreciated.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM

Wikibase\SqlIdGenerator::generateNewId: Explicit commit of implicit transaction.Closed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

Wikibase\SqlIdGenerator::generateNewId: Explicit commit of implicit transaction.
Closed, ResolvedPublicPRODUCTION ERROR
Actions